jouve / charts Goto Github PK

Hello!

I hope you are doing well!

We are a security research team. Our tool automatically detected a vulnerability in this repository. We want to disclose it responsibly. GitHub has a feature called Private vulnerability reporting, which enables security research to privately disclose a vulnerability. Unfortunately, it is not enabled for this repository.

Can you enable it, so that we can report it?

Thanks in advance!

PS: you can read about how to enable private vulnerability reporting here: https://docs.github.com/en/code-security/security-advisories/repository-security-advisories/configuring-private-vulnerability-reporting-for-a-repository

Description

Wrong indentation for items for projected volumes (io.k8s.api.core.v1.VolumeProjection) with the following error :

Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Deployment.spec.template.spec.volumes[0].projected.sources[1]): unknown field "items" in io.k8s.api.core.v1.VolumeProjection

Version of Helm used

version.BuildInfo{Version:"v3.12.3", GitCommit:"3a31588ad33fe3b89af5a2a54ee1d25bfe6eaa5e", GitTreeState:"clean", GoVersion:"go1.20.7"}

How to reproduce

Simply enable tls (mailpit.ui.tls.enabled=true) or other projected volumes.

It would be nice to have and option to set credential for smtp relay using secrets

My current usecase is to have LoadBalancerIP and different port than port 25 in mailpit smtp service. Please add loadbalancerIP part and ability to change port number.

Hi there,

by using a custom webroot, the service reference the wrong readiness and liveness endpoints and therefore fails.

Hello.

It looks like mailpit helm chart is broken:

$ helm repo add jouve https://jouve.github.io/charts/
$ helm template --version "0.7.2" mailpit jouve/mailpit
Error: template: mailpit/templates/smtp-service.yaml:6:14: executing "mailpit/templates/smtp-service.yaml" at <include "common.labels.standard" (dict "customLabels" .Values.commonLabels "context" $)>: error calling include: template: mailpit/charts/common/templates/_tplvalues.tpl:35:11: executing "common.tplvalues.merge" at <include "common.tplvalues.render" (dict "value" . "context" $.context "scope" $.scope)>: error calling include: template: mailpit/charts/common/templates/_tplvalues.tpl:19:8: executing "common.tplvalues.render" at <tpl $value .context>: error calling tpl: cannot retrieve Template.Basepath from values inside tpl function: app.kubernetes.io/version: '{{ .Values.image.tag }}': "BasePath" is not a value

Use --debug flag to render out invalid YAML

Thank you for looking at it...

When using alb ingress class the path must be /*.
When setting ingress.path to /* the image is not starting anymore:

Currently the CRDs are hosted in this repo, but they are not packaged in the helm chart. If the installation of the CRDs could be included in the Helm chart, and exposed through a Values options such as “installCRD: true” that would be helpful

It would be nice to be able to configure the port from the hardcoded value of 25 https://github.com/jouve/charts/blob/mailpit-0.15.3/charts/mailpit/templates/smtp-service.yaml#L23

Running helm install mailpit jouve/mailpit --values values.yaml with the following config:

ingress:
  enabled: true
  ingressClassName: "nginx-ingress-controller"
  hostname: "mail.example.domain"
  tls: true

The Ingress resource generated looks like this, no TLS config gets rendered:

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    meta.helm.sh/release-name: mailpit
    meta.helm.sh/release-namespace: default
  creationTimestamp: "2024-01-30T14:44:26Z"
  generation: 1
  labels:
    app.kubernetes.io/instance: mailpit
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: mailpit
    app.kubernetes.io/version: v1.13.0
    helm.sh/chart: mailpit-0.13.0
  name: mailpit
  namespace: default
  resourceVersion: "2111429"
  uid: ef91e520-e519-4d85-b312-84c77b19564a
spec:
  ingressClassName: nginx-ingress-controller
  rules:
  - host: mail.example.domain
    http:
      paths:
      - backend:
          service:
            name: mailpit-http
            port:
              name: http
        path: /
        pathType: ImplementationSpecific
status:
  loadBalancer:
    ingress:
    - ip: xxx.xxx.xxx.xxx