nodeshuttle-example's Issues
Currently any existing user will create a session regardless of password
First of all, I really appreciate this example app, I used it to help set up my own Next.js/Axum project. However, while working on my project I noticed that they way that the password is verified here with bcrypt results in any valid user being granted a session, even if the passwords don't match.
It seems to be that bcrypt::verify
returns a result, which here is left wrapped - so unless there is an error when you try to compare the hashed passwords, the session is created. I would suggest changing the code to something like:
if bcrypt::verify(password, res.get("password")).unwrap() == false {
println!("Unauthorized");
return Err(Error::RowNotFound);
}
I mean, maybe unwrap()
is not the right call, but this at least ensures that if the hashed passwords don't match, a session will not be created
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.