gitlint and gitlint-core v0.19.0 fail to build from sdist about gitlint HOT 13 CLOSED

I was just thinking about this: https://github.com/jorisroovers/gitlint/pull/418/files#r1131062741

@jorisroovers TL;DR to have a proper smoke-test, switch to invoking python -m build (without CLI args! it's important). It'll still use hatch's PEP 517 backend. This would build an sdist from Git checkout, followed by building a wheel from said sdist rather than from Git.
Additionally, you can make use of https://github.com/re-actors/checkout-python-sdist to run testing from sdist and not Git. This takes smoke-testing availability for the downstream packaging since they often use sdist as the source of truth.

from gitlint.

@jorisroovers I recommend releasing after merging #463 so that the fix is validated in the CI, not just locally.

Ack. I'll do it tomorrow morning then (CET), rather than trying to rush it out tonight and inevitably make a mistake.

from gitlint.

Already done :)

macports/macports-ports@3243c9c

Homebrew/homebrew-core#125315

from gitlint.

Awesome, thanks!

I created separate issues for everything else that was suggested here - thanks everyone. Closing this one!

from gitlint.

@harens This should be fixed now - I just tried a hatch build -t wheel on the sdist of the latest dev builds and it worked.

Can you confirm? Latest dev builds:
https://pypi.org/project/gitlint/0.19.1.dev2/
https://pypi.org/project/gitlint-core/0.19.1.dev2/

from gitlint.

@webknjaz would you be up for sending a PR to use that?

from gitlint.

Which part? using pypa/build? or testing from sdist? The latter would probably require some agreement and restructuring, while the former is straightforward.

from gitlint.

There is also this which I've heard good things about (and of course it's Hynek) https://github.com/hynek/build-and-inspect-python-package

from gitlint.

@ofek yes, I know about that action, but don't use it myself — it's too coupled for my taste.

FWIW I've made the small version of the PR: #463. https://github.com/re-actors/checkout-python-sdist can always be added later.

from gitlint.

@harens This should be fixed now - I just tried a hatch build -t wheel on the sdist of the latest dev builds and it worked.

Can you confirm? Latest dev builds: https://pypi.org/project/gitlint/0.19.1.dev2/ https://pypi.org/project/gitlint-core/0.19.1.dev2/

Seems to work fine, so I'll update the MacPorts portfile in the next stable release. Thanks for fixing @jorisroovers 👍

from gitlint.

Seems to work fine, so I'll update the MacPorts portfile in the next stable release. Thanks for fixing @jorisroovers 👍

Great. I'll try to release 0.19.1 with this fix later today so we can get the homebrew package out for 0.19.x and then look at the other suggestions afterwards.

from gitlint.

@jorisroovers I recommend releasing after merging #463 so that the fix is validated in the CI, not just locally.

from gitlint.

@harens just published 0.19.1! Can you retry?

Thanks!

from gitlint.