Code Monkey home page Code Monkey logo

Comments (3)

jorisroovers avatar jorisroovers commented on June 3, 2024

This makes sense - thanks for submitting.

Gitlint doesn't do warnings today (except for deprecation warnings). If we introduce them, there should probably be a way to suppress specific warnings.

I'll fix this, but not sure yet which route I'll end up going...

Thanks!

from gitlint.

jorisroovers avatar jorisroovers commented on June 3, 2024

So this also makes gitlint crash when passing anything in via stdin:

# Crashes
echo "foo" | gitlint
# Does not crash
echo "foo" | gitlint --staged

This is pretty bad. Working through some other things but will fix this soonish, probably without the warning since it would be unexpected for the warning to show up in this case.

edit: clarification that this only crashes when the user is using an ignore-by-author-name rule

from gitlint.

jorisroovers avatar jorisroovers commented on June 3, 2024

Fixed! I did end up adding a warning :) You can’t suppress it for now, maybe that’s something I’ll add in the future.

For (my own) reference: author-valid-email has a similar issue, but the rule is already silently ignored in case commit.author_name is not available. I think that’s ok (at least for now), since contrary to the ignore-by-author-name rule, the author-valid-email rule is enabled by default. Adding a warning now is likely just going to add a bunch of spam for users that are perfectly fine with the currently behavior.

from gitlint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.