Comments (3)
This makes sense - thanks for submitting.
Gitlint doesn't do warnings today (except for deprecation warnings). If we introduce them, there should probably be a way to suppress specific warnings.
I'll fix this, but not sure yet which route I'll end up going...
Thanks!
from gitlint.
So this also makes gitlint crash when passing anything in via stdin:
# Crashes
echo "foo" | gitlint
# Does not crash
echo "foo" | gitlint --staged
This is pretty bad. Working through some other things but will fix this soonish, probably without the warning since it would be unexpected for the warning to show up in this case.
edit: clarification that this only crashes when the user is using an ignore-by-author-name
rule
from gitlint.
Fixed! I did end up adding a warning :) You can’t suppress it for now, maybe that’s something I’ll add in the future.
For (my own) reference: author-valid-email
has a similar issue, but the rule is already silently ignored in case commit.author_name
is not available. I think that’s ok (at least for now), since contrary to the ignore-by-author-name
rule, the author-valid-email
rule is enabled by default. Adding a warning now is likely just going to add a bunch of spam for users that are perfectly fine with the currently behavior.
from gitlint.
Related Issues (20)
- [UX] Be more verbose about what is being checked HOT 1
- Parsing git message trailers HOT 3
- Modernizing gitlint's build and test tooling: discussion HOT 27
- [feature] Support PEP518 HOT 4
- [QUESTION] Is it possible to check for the total commit message length instead of just line length? HOT 2
- Ability to define more than one extra path HOT 2
- Ability to have user-defined rules disabled by default HOT 2
- Support for per-user configuration files and configuration inheritance HOT 9
- Ignore stdin by default in CI HOT 7
- Feature request: generate a junit or sarif report HOT 4
- Allow several --extra-path HOT 1
- v0.19.0dev tag should not be on the default branch HOT 7
- gitlint and gitlint-core v0.19.0 fail to build from sdist HOT 13
- 0.20.0 Release Plan
- Enable support for git archive installs HOT 7
- Consider adopting pypi-publish GHA instead of hatch publish
- Adopt GHA environments HOT 1
- Refactor GHA pipelines for improved security HOT 4
- Investigate smoke testing of sdist package for downstream packaging HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitlint.