jorge07 / ddd-playground Goto Github PK

The [Identifier] serializer group not being used for User.
In fact AggregatedRootId is also not using it:

Leos\Domain\Common\ValueObject\AggregateRootId:
    properties:
        uuid:
            expose: true
            groups: [Basic]

It is being used by the transition id, but the user is not using that ;)

Learn and use the document

Authentication is required to view Nelmio's Documentation @ api/doc:

{
code: 401,
message: "JWT Token not found"
}

Even though a api:doc:dump is being made by the build.xml it would be a good idea to allow access to the the docs without authentication.

docker-compose -f etc/infrastructure/dev/docker-compose.yml exec fpm bin/console rabbitmq:multiple-consumer events
ERROR: .IOError: [Errno 2] No such file or directory: u'.\\etc/infrastructure/dev/docker-compose.yml'

The User's Auth Roles are not persisted.
To fix that, we should add:
Infrastructure/SecurityBundle/Resources/config/persistence/ValueObject/AuthUser.orm.yml

    roles:
      type: json_array
      nullable: false

The UI/Controller tests check for an array in the role attribute response but do not check the content.
The Domain/User/testGetters doesn't test it at all, but testing it there will always pass, as it is set in the User entity.
Maybe it could be tested on the Infrastructure/Persistence level?

The auth/register (in the SecurityController) redirects and returns the response from get_user (in the UserController) [- Shouldn't this be decoupled?]

But the response is empty:

When try to call any API Endpoint that requires {version} it is not being validated and in fact you could use any value.

I.e GET /api/{version}/user/fc03e3ec-c3a1-11e6-a4a6-cec0c932ce01.json (empty/null value)

but also: GET /api/wrong_version/user/fc03e3ec-c3a1-11e6-a4a6-cec0c932ce01.json

Replace build steps for moby/moby#31257 when docker release it.

I noticed that User domain model has aggregation with Doctrine Array Collections, does not it violates DDD principles? We should create interface for collection in domain common bundle and the adapter for ArrayCollection in infrastrucutre layer, should not we?