jordan-prescott / odins_spear Goto Github PK

Change the requester to accept parameters and modify all GET and DELETE methods to change how attributes are passed to the requester.

This feature will return high level call statistics for all users in a single group. The data will then be outputted to a CSV file so the data is more human friendly.

Solution should have a rate limiting offering baked into the solution which will allow users to stay in agreed service contracts and ensure use of API does not negatively impact systems.

Huge chunks of the docstrings are missing or do not follow the correct format. Furthermore, the online docs are also missing for all methods that are in the docs.

Need to:

• Identify all docs inconsistences and correct
• Identify missing docs in code and online docs
• Write missing docs

Odin Patch Release 7.4.17 is now available
Greetings Odin users! This batch of release notes covers all the features, updates, and bug fixes published throughout July, 2024.

Normally, we segment releases into smaller chunks, but in this case the Odin team feels grouping the last few releases together makes the most sense, as many front and backend elements distrubuted across these releases work in concert.

Accordingly, we strongly advise any client wishing to upgrade beyond 7.4.13 to request an upgrade directly to 7.4.17.

As a reminder, all of these features are live and available for review in your instance of Odin via the Lab feature.

Please email [email protected] if you'd like to get on the schedule for an upgrade.

New Features
ODIN WEB

For User Bulk Features, the Voice Messaging User Screen CSV report download now includes 3 additional columns: sendVoiceMessageNotifyEmail, voiceMessageDeliveryEmailAddress, and voiceMessageCarbonCopyEmailAddress. [ADO-10600]
Enterprise and group admins can now enable and disable admins at their level of clearance or lower. [9863]
Updates
ODIN WEB

Improved the performance of the Service Utilization Report [ADO-8413]
Added the ability to filter the Group User Call Report to remove users who do not have any calls during the designated period [ADO-10633]
Odin group Devices and group Device Configuration as well as user Devices were in some cases requiring tag values. Odin now allows null Tag Values in all cases as well as correctly passes along "true" or "false" values. [ADO-10785]
While on the user landing page, the links to settings for calling features are now in focus order. [ADO-9665]
The downloadable CSV report User Bulk Features - Voice Messaging User Screen now includes an additional column: voiceMessageNotifyEmailAddress. [ADO-11272]
When using the "Enable Authentication" option of the user create callback, the system should update the user authentication and raise a "user.authentication.update" event regardless of whether or not the authentication service is previously enabled. [ADO-11585]
ODIN API

Performing a GET call on the call records user stats returns an empty array instead of an object with null properties when no matching records are found. [ADO-10847]
Bugfixes
ODIN WEB

Corrected a bug that was preventing hunt group agent reordering. [ADO-11439]
Fixed various bugs and implemented several optimizations for date picker. [ADO-10644]
ODIN API

Corrected issues with the Phonism Webhook fix for the user.busyLampField.update event. [ADO-10727]

put.py user_authentication_service()

is actually SIP not web

There are multiple imports throughout the codebase which uses the name of the library in the import. For example odins_spear import api in the odins_spear/store/data_store.py file, these all need to be changed to relevant paths.

This example should be '.. import api' therefore no matter where this is being used it will be look inside the package.

In functions like user_call_center() if the input UserID doesn't have an agent license the function will return with Http Error 400 instead of returning an empty Json value.

Current:

requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.api.com/api/v2/users/call-center?userId=userID@userID.com

Expected:

[]

If the Trunk Group service is not authorised against an Enterprise, then the "Service Provider Trunking Capacity" scripter will fail. Exception shown is:

When putting that failed URL through as a manual API request, the error received is:

{
    "error": "[Error 4398] Service Trunk Group is not authorized.",
    "status": 400,
    "path": "api/v2/service-providers/trunk-groups/call-capacity",
    "details": "ODIN API Error"
}

It's possible that this error could occur on groups which don't have the service authorised too. I haven't testedy that.

When running the user association script I ran into this error.

To fix add a exception

and also a print

.

I also noticed that the pickup group returns nothing when the user is in a pickup group.

Code:

Pickup Group

Running into an issue with the GraphvizModule.

Code:

Snip of error: