Code Monkey home page Code Monkey logo

python-opensky's People

Contributors

cdce8p avatar dependabot[bot] avatar joostlek avatar ozgav avatar renovate[bot] avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

ozgav pem884

python-opensky's Issues

Tags and version

Problem/Motivation

Tags contains no corresponding version entry in pyproject.toml, e.g., for v0.0.9 version = "0.0.0"

Expected behavior

Having a versioned setup when using the GitHub tags/releases.

Actual behavior

see above

Steps to reproduce

Clone the repo, choose a tag and install it.

Proposed changes

Add current version to pyproject.toml. This help users who are going for the GitHub releases and the distributions which needs to package it as it's a Home Assistant dependency.

Change request

First of all, I like to state that I highly respect the time and effort which has flown into this integration.
I personally think it is 100%, very good, and I am aware that this request is pretty cheeky, but never the less I think plenty of people will benefit from the following changes, and as I cannot do them myself, I am asking a lot here. :-(

I am not a Python Developer, but I can read and write code...

When I read your code it states that the refresh interval is 15 Minutes, which is 100% correct for "the blank case",
But looking at the Opensky website: https://openskynetwork.github.io/opensky-api/rest.html#api-credit-usage
It states that for requests under 500km radius, they only charge 1 credit (Interval=216 seconds only).
Could we make the scan interval dependant on the radius, or enter the scan interval as a parameter that can be user defined?

Next thing:
If the user has a name and password with opensky, she or he can get 4000 to 8000 credits.
Could we integrate something, so we are able to pass username and password as a parameter and based on that change the scan interval is recalculated, or as stated above add a paramter scan_interval, so that the admin can define the interval in the HA config?

I am not expecting anything here, I am just asking, if you could look into this?

Right way of attribution

Hey @frenck,

Since your projects like python-vehicle and python-twente-milieu are so nicely setup, I kinda borrowed it. I gave you attribution in the readme.md, but was wondering if this is enough or that you think more is needed.

Thanks :)

opensky sensor not working

Problem/Motivation

OpenSky sensor not being created

Expected behavior

Opensky sensors to show up in HA

Actual behavior

no sensors in dev>states
logs

Source: components/opensky/sensor.py:163
Integration: Sensor (documentation, issues)
First occurred: 8:57:23 AM (1 occurrences)
Last logged: 8:57:23 AM

opensky: Error on device update!
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 537, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 784, in async_device_update
    await self.async_update()
  File "/usr/src/homeassistant/homeassistant/components/opensky/sensor.py", line 163, in async_update
    response = await self._opensky.get_states(bounding_box=self._bounding_box)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/python_opensky/opensky.py", line 148, in get_states
    "states": [self._convert_state(state) for state in data["states"]],
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'NoneType' object is not iterable

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

  • ⬆️ Lock file maintenance

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

github-actions
.github/workflows/labels.yaml
  • actions/checkout v4.1.1
  • micnncim/action-label-syncer v1.3.0
.github/workflows/linting.yaml
  • actions/checkout v4.1.1
  • actions/setup-python v5.0.0
  • actions/checkout v4.1.1
  • actions/setup-python v5.0.0
  • actions/checkout v4.1.1
  • actions/setup-python v5.0.0
  • actions/checkout v4.1.1
  • actions/setup-python v5.0.0
  • actions/checkout v4.1.1
  • actions/setup-python v5.0.0
  • actions/checkout v4.1.1
  • actions/setup-python v5.0.0
  • actions/setup-node v4@60edb5dd545a775178f52524783378180af0d1f8
.github/workflows/lock.yaml
  • dessant/lock-threads v5.0.1
.github/workflows/pr-labels.yaml
  • jesusvasquez333/verify-pr-label-action v1.4.0
.github/workflows/release-drafter.yaml
  • release-drafter/release-drafter v6.0.0
.github/workflows/release.yaml
  • actions/checkout v4.1.1
  • actions/setup-python v5.0.0
.github/workflows/stale.yaml
  • actions/stale v9.0.0
.github/workflows/tests.yaml
  • actions/checkout v4.1.1
  • actions/setup-python v5.0.0
  • actions/upload-artifact v4.3.1
  • actions/checkout v4.1.1
  • actions/download-artifact v4.1.4
  • actions/setup-python v5.0.0
  • codecov/codecov-action v4.1.0
  • SonarSource/sonarcloud-github-action v2.1.1
.github/workflows/typing.yaml
  • actions/checkout v4.1.1
  • actions/setup-python v5.0.0
npm
package.json
  • prettier 3.2.5
nvm
.nvmrc
  • node 20.11.1
pep621
pyproject.toml
  • poetry-core >=1.0.0
poetry
pyproject.toml
  • python ^3.11
  • aiohttp >=3.0.0
  • yarl >=1.6.0
  • aresponses 3.0.0
  • codespell 2.2.6
  • covdefaults 2.3.0
  • coverage 7.4.4
  • mypy 1.9.0
  • pre-commit 3.6.2
  • pre-commit-hooks 4.5.0
  • pylint 3.1.0
  • pytest 8.1.1
  • pytest-asyncio 0.23.6
  • pytest-cov 4.1.0
  • ruff 0.2.2
  • safety 3.0.1
  • yamllint 1.35.1
  • syrupy 4.6.1

  • Check this box to trigger a request for Renovate to run again on this repository

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.