Code Monkey home page Code Monkey logo

joomlatools-composer's People

Contributors

allanpilarca avatar bitdeli-chef avatar cdekok avatar ercanozkaya avatar ienev avatar johanjanssens avatar magneticmg avatar soxyl avatar stevenrombauts avatar vikijel avatar yiendos avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

joomlatools-composer's Issues

Fatal error with Joomla 3.5-beta

PHP Fatal error:  Uncaught RuntimeException: The session is not started. in /Users/danielsmink/projects/gmp.jos.picturae.pro/public/libraries/joomla/session/handler/native.php:229
Stack trace:
#0 /Users/danielsmink/projects/gmp.jos.picturae.pro/public/libraries/joomla/session/session.php(743): JSessionHandlerNative->save()
#1 /Users/danielsmink/projects/gmp.jos.picturae.pro/public/vendor/joomlatools/installer/src/Joomlatools/Composer/ExtensionInstaller.php(466): JSession->close()
#2 [internal function]: Joomlatools\Composer\ExtensionInstaller->__destruct()
#3 {main}
  thrown in /Users/danielsmink/projects/gmp.jos.picturae.pro/public/libraries/joomla/session/handler/native.php on line 229

Currently not working with Joomla 3.7

[Symfony\Component\Debug\Exception\FatalThrowableError]
Call to undefined method Joomlatools\Joomla\Application::isClient()

Probably due to the replacement of isAdmin / isSite with isClient('site') / >isClient('administrator')

Unable to install framework on Joomlatools Platform

When trying to install joomlatools/framework on a Joomlatools Platform install, the following error is raised:

PHP Fatal error:  Class 'JDispatcher' not found in /var/www/foobar2/vendor/joomlatools/framework/code/script.php on line 11

Fix uninstall method

When running composer remove <package>, Composer will also remove this composer plugin if no other packages rely on it. Because we only fire the extension uninstaller afterwards, the required files are missing and Composer will fail.

Where to create the file composer.json

I was about to try this repo.
At the beginning of Read.me it says that you should create a composer.json in the root directory of Joomla.

In the current Joomla version 3.9.14 there is already a composer.json in the root directory.

Allow to install outside of Joomla

Ensure that the composer install process can run outside of the Joomla context, this would allow installing the Joomlatools Framework standalone.

PHP7.4 compat issue

Error: Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/joomlatools/composer/src/Joomlatools/Composer/ExtensionInstaller.php on line 191

Ensure dotenv is installed

When working on a joomla-platform codebase that also requires joomla extensions installed using our joomlatools/installer plugin, the installation will fail when joomlatools/installer bootstraps the platform:

  • composer finds a package of type joomla-installer and will also require joomlatools/installer
  • joomlatools/installer gets installed first
  • the joomlatools/installer plugin tries to bootstrap the platform but fails because the basic platform dependencies are not installed (and not loaded via autoload) yet

Undefined constant JPATH_COMPONENT_ADMINISTRATOR

Hello there, thanks a lot for this, I'm a rookie with composer and command line but actually already love this incredible plugin!

I've tried installing JCE, this is my code for it

{
    "type": "package",
    "package": {
        "name": "vendor/jce",
        "type": "joomla-installer",
        "version": "1.0.0",
        "dist": {
            "url": "https://www.joomlacontenteditor.net/downloads/editor/joomla-3?task=callelement&format=raw&item_id=1133&element=f85c494b-2b32-4109-b8c1-083cca2b7db6&method=download&args[0]=a51aaa52300b0ccdf84d03ca4c75f67c",
            "type": "zip"
        },
        "require": {
            "joomlatools/installer": "*"
        }
    }
}

Unfortunately after downloading correctly I have this error

[ErrorException]
Use of undefined constant JPATH_COMPONENT_ADMINISTRATOR - assumed 'JPATH_COMPONENT_ADMINISTRATOR'

I guess its something to do with their code maybe, but was wondering if maybe I did something wrong on my side too.

Side question: what is the purpose of the version number? (in both "package" declaration and "require").
How can I tell to grab the last available? I saw that even specifing the ver number it will anyway get the last version, so another question could be how can I tell him to get a specific version?

Thanks a lot for sharing this!

Add basic tests

Add some basic tests to run on Travis to simply check if composer require works.

Joomlatools Framework files not properly moved on Joomlatools Platform

We're trying to install Nooku 2.x on the Joomla Platform. It seems that the joomlatools-installer didn't move files properly.

/libraries/koowa wasn't moved to lib/libraries/koowa
/media wasn't moved to /public/media
/administrator/manifests/files/files_koowa/script.php wasn't moved to /app/administrator/manifests/files/files_koowa/script.php

Verify directory

Make sure to be working in a Joomla Platform/CMS directory before trying to include files. If not, throw an error with a clear message.

Fire upgrade if extension is already registered

Consider the following scenario:

  • Website is being deployed using a tool such as Capistrano
  • The database already has the extension schema applied and is registered in assets/extensions tables
  • A new deployment triggers composer install, which will try to re-install those extensions
  • Errors will be thrown because the extension schema is already applied

To solve this :

  • After downloading of the files by Composer, check if the extension is already installed yes or no by looking at the database
  • If not installed, run install(), otherwise run update()

Error - The file Cache Storage is not supported on this platform

Appears to no longer be working with Joomla 3.6.*

Exception trace:
 () at /Users/dsmink/Projects/gda.jos.picturae.pro/public/libraries/joomla/cache/storage.php:173
 JCacheStorage::getInstance() at /Users/dsmink/Projects/gda.jos.picturae.pro/public/libraries/joomla/cache/cache.php:466
 JCache->_getStorage() at /Users/dsmink/Projects/gda.jos.picturae.pro/public/libraries/joomla/cache/cache.php:191
 JCache->get() at /Users/dsmink/Projects/gda.jos.picturae.pro/public/libraries/joomla/cache/controller.php:184
 JCacheController->get() at /Users/dsmink/Projects/gda.jos.picturae.pro/public/libraries/cms/plugin/helper.php:298
 JPluginHelper::load() at /Users/dsmink/Projects/gda.jos.picturae.pro/public/libraries/cms/plugin/helper.php:163
 JPluginHelper::importPlugin() at /Users/dsmink/Projects/gda.jos.picturae.pro/public/libraries/cms/installer/installer.php:456
 JInstaller->install() at /Users/dsmink/Projects/gda.jos.picturae.pro/public/vendor/joomlatools/composer/src/Joomlatools/Composer/Application.php:165
 Joomlatools\Composer\Application->install() at /Users/dsmink/Projects/gda.jos.picturae.pro/public/vendor/joomlatools/composer/src/Joomlatools/Composer/ExtensionInstaller.php:93
 Joomlatools\Composer\ExtensionInstaller->install() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/src/Composer/Installer/InstallationManager.php:152
 Composer\Installer\InstallationManager->install() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/src/Composer/Installer/InstallationManager.php:139
 Composer\Installer\InstallationManager->execute() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/src/Composer/Installer.php:536
 Composer\Installer->doInstall() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/src/Composer/Installer.php:215
 Composer\Installer->run() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/src/Composer/Command/UpdateCommand.php:172
 Composer\Command\UpdateCommand->execute() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/vendor/symfony/console/Command/Command.php:259
 Symfony\Component\Console\Command\Command->run() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/vendor/symfony/console/Application.php:844
 Symfony\Component\Console\Application->doRunCommand() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/vendor/symfony/console/Application.php:192
 Symfony\Component\Console\Application->doRun() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/src/Composer/Console/Application.php:227
 Composer\Console\Application->doRun() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/vendor/symfony/console/Application.php:123
 Symfony\Component\Console\Application->run() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/src/Composer/Console/Application.php:102
 Composer\Console\Application->run() at phar:///usr/local/Cellar/composer/1.1.2/libexec/composer.phar/bin/composer:43
 require() at /usr/local/Cellar/composer/1.1.2/libexec/composer.phar:24

Installer errors are not shown

The getApplicationMessages() call is not returning the queued messages on failure (code).

The messages do show up in the logger output when increasing verbosity.

How to reproduce:

  • Create new Joomla site
  • Install LOGman 2.x
  • Run composer require joomlatools/logman-advancedmodules
  • The plugin will fail to install but the message This plugin requires a newer LOGman version. Please download the latest version from <a href=http://joomlatools.com target=_blank>joomlatools.com</a> and upgrade. is not shown when you run without the -v flag.

Installer fails with platform extensions

The installer will throw an exception when trying to install platform-xyz extensions into platform along with the default dependencies on a first composer install during installation of custom projects. This happens because the dependencies required to bootstrap the application (such as phptdotenv) are missing. We need to make sure that:

  • the required dependencies are installed first
  • the autoloader is present before we bootstrap the application

Originally reported at joomlatools/joomlatools-platform#240

Todo's:

  • Install/update after autoload is generated
  • Check if installed before queuing
  • Separate queue from ExtensionInstaller class
  • Fix uninstall?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.