joomla-extensions / weblinks Goto Github PK

The language files here are out of sync with the ones in the main joomla-cms repo

The fix provided by Elin W has been applied several times now in Joomla core. Unfortunately it gets overrulled without properly documenting whether that is intentionally.

Currently it is set to urls, which looks like the wrong value, it should be url.
If that is not a true statement it would help if somebody explains what the correct value should be!

I have encountered the following error with 2 sites.

• Sites are running the latest Joomla (3.4.3)
• Both sites run admin tools pro firewall (Not sure if that is a factor)

Both get the following error.

Error
Invalid extension update

Package download failed: https://github.com/joomla-extensions/weblinks/releases/download/3.4.1/pkg_weblinks_3.4.1.zip

These lines 92fff69#diff-02040fb06a55970e37b936f43e1b859dR193 were created for travis but they are not taking into account the options added in robo file like: $this->cmsPath

@jatitoam I'm creating this issue in case you can have a look.

Not in a hurry because is only used by travis.

Back in the Joomla 1.5 days, I used TEG's Bookmarks component, which had a feature that allowed users to submit new links, which an Admin would then approve (and edit / update / modify, as needed). I would very much like to see a Submit feature make its way into Weblinks, please.

Different ways of naming objects are used in weblinks test. We should find a common way to put titles in generated elements: categories, weblinks...

The AdministratorCategoryCest file needs to be refactored to use @Depends tag and to define in the constructor the category object that we will use.

see https://github.com/redCOMPONENT-COM/selenium-server-standalone

url: 'http://localhost/tests/joomla-cms3' # the url that points to the joomla installation at /tests/system/joomla-cms

....is confusing, since there isn't such a path at this moment, at least before the first run (I guess)

[edit] Or is this related to the 'cms-path'-value in the robo file?

@jatitoam I'm leaving this one for you for when you have time. No rushes.

#113

The task would be to make it work the PHP7

But we are probably moving to Docker before that so, maybe we don't need to lose time on it.

Mod_weblinks is lacking an interesting feature: when selecting a "master" category, links cannot be grouped by subcategory. Such enhancement would allow additional layout compatibility.

I've had Joomla 3.3.6 with com_weblinks. Soon Joomla was updated to 3.4.1 and com_weblinks is needed to be updated. I took latest version of weblinks component from here, tried to install and got this error message:

Warning
You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'delimiter ';;' create procedure weblinks_schema_change() begin /* delete colum' at line 1 SQL=delimiter ';;' create procedure weblinks_schema_change() begin /* delete columns if they exist */ if exists(SELECT * FROM information_schema.columns WHERE table_name = '#__weblinks' AND column_name = 'sid') THEN ALTER TABLE thm7_weblinks DROP COLUMN sid;

Joomla 3.4.1
DB: 5.5.37-MariaDB-wsrep

Decentralising an extension presents a problem with decentralised bug and issue handling. What does that look like in a decoupled world and what changes do we need to make to information we have out there about the bug handling process?

Hi... ive unzipped package update and individually installed all mods & coms successfully however, keeps reverting back that i have updates for weblinks.... happening to ALL my joomla sites.... please help.... thanks Steve :)

this pull joomla/joomla-cms#7490 made by @brianteeman brought changes in the administrator interface strings. The same pattern needs to be applied to Weblinks. See:

We have issues like this https://github.com/joomla-extensions/weblinks/pull/55/files#r31388936. We need to improve the Joomla admin markup by adding classes that help us to easily locate elements.

Would it be possible to integrate a thumbnail service like ShrinkTheWeb with Weblinks, to auto-generate thumbnails for links?

I suggest that we move functions like ->isWindows() into tasks at https://packagist.org/packages/joomla-projects/robo (https://github.com/joomla-projects/robo)

We need system tests that would verify the tabs present on weblinks extension. to avoid issues like this #89

Asked JED for comment:
http://forum.joomla.org/viewtopic.php?f=262&t=841371

Install weblinks on a clean Joomla 3.4.3
Uninstall weblinks
/administrator/manifests/packages/pkg_weblinks.xml is left on the server

Site is Joomla 3.4.3 - updated from Joomla 2.x

Tried to install the weblinks extension (through the extension manager) over the currently installed extension resulting in the following messages: (other extension updates have been successful)

Warning
Error connecting to the server: SSL certificate problem: unable to get local issuer certificate

Error
Package download failed: https://github.com/joomla-extensions/weblinks/releases/download/3.4.1/pkg_weblinks_3.4.1.zip

If I were to uninstall the extensions first and upload the zip file to install, I'm not sure which to uninstall since there are several.

We need a script based in robo.li (see https://github.com/joomla-extensions/weblinks/blob/master/RoboFile.php) that automates the release of this extension. The scripts should allow to:

• Tag the release (ideally using https://github.com/joomla-framework/github-api)
• update the XML bumping the version
• put the package on GitHub-releases. (ideally using https://github.com/joomla-framework/github-api)
• The GitHub tag/release (https://github.com/joomla-extensions/weblinks/releases) may be edited to have some basic changelog added or some other generic thank you message. See https://github.com/eddieajau/tagaliser for inspiration.

Duplicate column name 'version' SQL=ALTER TABLEp52jk_weblinksADD COLUMNversionint(10) unsigned NOT NULL DEFAULT '1';

Update Joomla 3.3.6 to 3.4.1 upload and install the RC package.

I guess we need something like for the drop colums also for the add colums?

How is the version strategy going to work?

Suggestion: Keep the major version the same as the Joomla CMS and start from 3.0.0.

Patches increment the last number, for example 3.0.1, 3.0.2.

New features increment the middle number, for example, 3.1.0, 3.2.0.

Steps to reproduce the issue

Install the Weblinks package into Joomla
Create a new weblink
In the images select an image
Save
Message says saved but image field shows empty

Expected result

Image field should show the image link that was selected

Actual result

Message says saved but image field shows empty

System information (as much as possible)

Windows 10 but sys info says 8

PHP Built On Windows NT MY-COMPUTER 6.2 build 9200 (Windows 8 Home Premium Edition) i586
Database Version 5.6.26
Database Collation utf8_general_ci
PHP Version 5.5.28
Web Server Apache/2.4.16 (Win32) OpenSSL/1.0.1p PHP/5.5.28
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.4.5 Development [ Ember ] 8-September-2015 21:30 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0

Additional comments

Update J!2.5.28 to 3.4.1 (with known problems).

After applying patch from
#30
(Thanks for it!)

and actvating Versioning in Weblinks > Options we have an SQL error while saving a weblink.

"
Error

Save failed with the following error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND sha1_hash = '093f558adc1ca35ced94ba8xyz'' LIMIT 0, 1' at line 3 SQL=SELECT * FROM xxxx_ucm_history WHERE ucm_item_id = 9 AND ucm_type_id = AND sha1_hash = '093f558adc1ca35ced94ba8xyz' LIMIT 0, 1
"

Error is here (no ucm_type_id)

AND `ucm_type_id` = AND `sha1_hash`

/libraries/cms/table/contenthistory.php

• Administrator: create a category (Javier)
• Administrator: can't create a category (Javier)
• Administrator: delete a category (@puneet0191)
• Administrator: Create a weblink (Beat)
• Administrator: Delete a weblink (Beat)
• Administrator: Modify a weblink (Beat)
• Administrator: Publish a weblink (@yvesh)
• Administrator: Unpublish a weblink (@yvesh)
• Frontend: create a menu to a weblink (@compojoom)
• Frontend: create a menu to a category of weblinks (@yvesh)
• Create a weblink in backend and confirm it exits and is visible in frontend (@yvesh)
• Create a menu item: Displays a list of Web Links for a category
• Submit a Web Link

after the recent changes to create:testing-site function in RoboFile.php, I am not able to use this function, but previously I was able to use this function on my machine without any issues, but now it seems to throw an error. I am attaching a screenshot of the error with this.

com_weblinks\site\views\categories\tmpl\default.php

the closing div in the last line have to be removed!

See also: http://www.joomlaportal.de/joomla-3-x-installation/313482-sammelthread-upgrade-von-2-5-auf-3-3-welche-vorgehensweise-ist-hilfreich-29.html#post1589395

Any extension will need Joomla to be system tested, but if they are provided as a standalone package, how can we test them? The solution we found is to add joomla-cms as a GIT submodule. The first tests we run is the Joomla installer so we install Joomla. Then we install the extension, for example com_weblinks, using the install from folder installer. Finally we are ready to run the extension tests.

Me and @puneet0191 have already a working example. We will pull it here as soon as possible.

We assume the component should work fine at all the following resolutions:

• 1024x768px (desktop)
• 768x1024 (tablet)
• 480x320 (smartphone)

I will start by manually change the resolution in configuration and run the full test suite,

When I try to update Weblinks to version 3.4.1, I got the following errors:
Error connecting to the server: SSL certificate problem: unable to get local issuer certificate

Package download failed: https://github.com/joomla-extensions/weblinks/releases/download/3.4.1/pkg_weblinks_3.4.1.zip

What support "contract" should decoupled extensions have with their users? Same as CMS?

When or how do we decide it's no longer viable to support this extension?

see #56 (comment)

see: https://github.com/joomla-extensions/weblinks/pull/117/files#r43507247

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'delimiter ';;' create procedure weblinks_schema_change() begin /* delete colum' at line 1 SQL=delimiter ';;' create procedure weblinks_schema_change() begin /* delete columns if they exist */ if exists(SELECT * FROM information_schema.columns WHERE table_name = '#__weblinks' AND column_name = 'sid') THEN ALTER TABLE mmp_exd_j25_weblinks DROP COLUMN sid;

Package Install: There was an error installing an extension: com_weblinks.zip

Hello -

What is the difference between hits and clicks? If I turn on Hits I see a hits marker. However, it never gets incremented. If I turn on clicks, it gives me an error and says website not found.

We need a colloquial term for these extensions that we are decoupling from the #Joomla CMS core. Suggestions?

Note that this can also include extensions like com_testpatcher, a number of modules from GSOC projects, etc and so on.

• Off Core

Use https://github.com/joomla-projects/joomla-browser/blob/develop/src/JoomlaBrowser.php#L224-L231 instead of installing a normal Joomla.

• create a translated weblink
• create a translated category
• Integration: show in frontend the translations of a weblink and a category

I tried installing the package on a legacy site updated to 3.4.2-dev (i.e. weblinks still present).
I get these errors:

Warning

Duplicate column name 'version' SQL=ALTER TABLE `jos_weblinks` ADD COLUMN `version` int(10) unsigned NOT NULL DEFAULT '1';

Package Update: There was an error installing an extension: com_weblinks.zip
Error

Error installing package

The system test fails to install joomla on my Windows machine. The test fails to find the next button on the page with the language select.

I see that in the test we have this

 // Select a random language to force reloading of the lang strings after selecting English
$I->selectOptionInChosen('#jform_language', 'Danish (DK)');
$I->selectOptionInChosen('#jform_language', 'English (United Kingdom)');

In my case I end up with danish, instead of english. Tried with waiting 2 sec between the selection, but this didn't help either. The only way to go around this is to just select english.

I'm also not sure that I understand the logic of the comment? Force reloading of the lang strings? The default language is english? Why do we need to reload it?

See details of this issue at https://github.com/joomla-extensions/weblinks/pull/65/files#diff-6da58571ed6d71af9cf57ab7b43b004fR44

When there are no categories the New button is not shown because there are no categories. However the other buttons are shown even when there are no entries. These buttons are useless as well since there are no entries nor new entries can be created.

I did a clean installl of Joomla 3.3.6 accepting all defaults and I only added a menu item to "Submit a Web Link", no other changes.
When adding a duplicated weblink from the frontend I get the expected error message but all form fields are empty, while doing the same from the backend all field contents are preserved and I still get error message, as expected.

Hi,
As an user said today in french Joomla! forum, on Joomla! 3.4.4, web links have two "images" tabs, so adding an image is not possible. I tested and confirm. You can save, but images are not saved: if you edit, all fields remains empty.

Thanks for your help!
Robert

Steps to reproduce the issue

Display weblinks component. Unnecessary tag in /components/com_weblinks/views/categories/tmpl/default.php causes mess in template. Line number 17.

Expected result

Correct display of weblinks component. Solution is create weblinks override without closing div tag.

Actual result

Mess in weblinks in custom template.

System information (as much as possible)

Linux, Apache, Mysql

Screenshots from messed webpage and corrected one:
http://image.qkiz.pl/di/UBY5/bad.png
http://image.qkiz.pl/di/TNQP/good.png

Need to talk to the TT's about how decoupled extensions are going to work in terms of translations.

Steps to reproduce the issue

1- Pa
2-Pum
3-Cá

Expected result

Actual result

System information (as much as possible)

Additional comments

How do we move the help screens from docs.joomla.org to this repository?

Whilst I understand /src is the "PHP" way of doing things - I don't think that's the best way for Joomla extensions. I find that laying them out as you find them in the CMS is much easier for debugging.

For example: https://github.com/JoomJunk/Accordion

There I have my modules in the correct folders then the entire CMS in .gitignore. This means I can install my module into the CMS and make any changes I want and see them reflected life time. Then it's easy to push them back into the repo without having to copy the changes you were trialing in the CMS.

I hope this makes sense :)