jonswar / perl-mason-plugin-htmlfilters Goto Github PK

Hi.

Excuse me. I have a question.

One day, I was developing my web app and I met the following debug messages.

Use of uninitialized value $text in substitution (s///) at /Users/bokutin/perl5/perlbrew/perls/perl-5.14.0/lib/site_perl/5.14.0/Mason/Plugin/HTMLFilters/Filters.pm line 13.
Use of uninitialized value $text in substitution (s///) at /Users/bokutin/perl5/perlbrew/perls/perl-5.14.0/lib/site_perl/5.14.0/Mason/Plugin/HTMLFilters/Filters.pm line 13.
Use of uninitialized value $text in substitution (s///) at /Users/bokutin/perl5/perlbrew/perls/perl-5.14.0/lib/site_perl/5.14.0/Mason/Plugin/HTMLFilters/Filters.pm line 13.
Use of uninitialized value $text in substitution (s///) at /Users/bokutin/perl5/perlbrew/perls/perl-5.14.0/lib/site_perl/5.14.0/Mason/Plugin/HTMLFilters/Filters.pm line 13.
Use of uninitialized value $text in substitution (s///) at /Users/bokutin/perl5/perlbrew/perls/perl-5.14.0/lib/site_perl/5.14.0/Mason/Plugin/HTMLFilters/Filters.pm line 13.
[info] *** Request 14 (0.538/s) [16428] [Wed May  9 18:08:23 2012] ***
[debug] Path is "/track/list"
[debug] "GET" request for "track/list" from "127.0.0.1"

So, I fixed up Filters.pm as follows in my dev env.

diff --git a/lib/Mason/Plugin/HTMLFilters/Filters.pm b/lib/Mason/Plugin/HTMLFilters/Filters.pm
index 6ace64e..fc0ab4a 100644
--- a/lib/Mason/Plugin/HTMLFilters/Filters.pm
+++ b/lib/Mason/Plugin/HTMLFilters/Filters.pm
@@ -7,7 +7,7 @@ my $html_escape = qr/([&<>"])/;
 method HTML () {
     sub {
         my $text = $_[0];
-        $text =~ s/$html_escape/$html_escape{$1}/mg;
+        $text =~ s/$html_escape/$html_escape{$1}/mg if defined $text;
         return $text;
     };
 }

Is this uninitialized warnings design decision for this module?
Or would you fix up as above, please?

Cheers
Tomohiro Hosaka