jonnyadaptabletools / adaptablegrid Goto Github PK

So I think you need to allow a column to be Readonly. this can then be set by the dev at design time when they set up the grid. if its readonly then you cannot enter edit mode for the column.
And also the column object should have an IsReadOnly or IsEditable or some similar property to say if readonly has been set.
This is quite useful in lots of scenarios.

e.g. does AdaptableGrid.applyStyles need definition explicitly stated if never used by AB?

Implement methods for Cell/Row to see if cell has styling, remove and add (only if not there already).

It probably shouldn't but not the end of the world so long as we are aware its happening and can deal with it. but i cannot think of a situation in which you would want it.

perhaps we could add a getHeaderRow() method IF we need to get it but i don't think we do and in any case it shouldn't be returned in get visible rows.

Looks like as though its failing on a tostring() call when the column is not a string

We can easily add styles to Cells and Rows (though not sure why for cell is AddClass and for row is AddCSS).

But we cannot easily remove them.

Is it possible to add a method so we can easily remove a style by name.

Instead of having to use $(grid).keydown(function (e) { });

Not sure if we have concept of pre-edited value but worth doing this.

Hey man,

Just had a look at the definition of the DataType interface that is being returned by Column.getType()

I'm sure something has gone wrong in the jsdoc to definition file of something...
Ideally, we'd want the method to be like that:
getType(): 'String'|'Number'|'Boolean' ...........

You will need to have some kind of keypress listener

Some way of giving us the currently focussed cell.

if we are editing a cell then getselectedcells is null.

I'm guessing its when the value is null - don't forget that sometimes a cell might be null or empty. Im assuming the error is when there is no value for the cell: this is the error:

This is hard - not sure how you will move focus to next cell but worth trying...

Also need a way of referencing a Column by its position
Be more clear if method needs/returns an Id or position

Not so urgent this as we can loop through all the rows and call getrowidbyrow but i guess if you can do it - and make it super quick by using JQuery - then it might be helpful...

definitely not urgent.

Not sure why but it takes a long time when you multi select

I think the issue is your end...

Add moment we have
getVisibleColumns
getHiddenColumns
getAllColumns

but for rows we just have hidden and visible. a get all would be helpful for scenarios where we need to loop for all rows and don't care if they are hidden or visible