jonnitto / jonnitto.plyr Goto Github PK

There is an error in the Tag.ts2:
@exceptionHandler = 'TYPO3\\Neos\\**Fusion**\\ExceptionHandlers\\NodeWrappingHandler'
it have to be:
@exceptionHandler = 'TYPO3\\Neos\\**TypoScript**\\ExceptionHandlers\\NodeWrappingHandler'

When using YouTube, the iframe embed URL contains rel=0 and showinfo=0. Both parameters have changed in September 2018. showinfo is no longer supported at all and rel=0 simply changes what related videos are shown (instead of hiding them).

See https://developers.google.com/youtube/player_parameters

I guess those parameters should be removed from the embed URL (at least showinfo, rel still has some effect.)

What's more, this makes the display look a little funky and impacts UX. Given a configuration where only play/pause are enabled, the player looks like this after loading:

While playing, it looks fine:

But when paused, this is shown:

(And similar after activating and starting the video.)

Now, since there is an overlay (which toggles play/pause when clicking), none of the visible controls are usable. Dang.

Describe the bug

Plyr controls cannot be changed as expected.

To Reproduce

Jonnitto:
  Plyr:
    options:
      # hacky solution to override the defaults - "shortening" lists in YAML is not possible
      controls: ['play']

Expected behavior

Only the play control is used.

** Actual behavior**

As can be seen with ./flow configuration:show --type Settings --path Jonnitto.Plyr.options.controls the play is added to the defaults. Thus all default controls are shown.

Workaround

Jonnitto:
  Plyr:
    options:
      # hacky solution to override the defaults - "shortening" lists in YAML is not possible
      controls: [null, 'play', null, null, null, null, null, null, null, null, null]

The trick is to use as many null entries as there are default entries in the list. See https://discuss.neos.io/t/how-to-replace-an-array-in-settings-yaml/296 for more on this (from 2015!)

When I add a video File at the inspector I get a success message. Right after the page reload when "apply" was clicked this huge Error 500.
After that there is no file referenced in the inspector anymore. It does work with image.
Even more remarkable is, that the video is rendered in frontend.

Tested on 2 different servers and different setups. Both Neos 3.1. One of them was fresh out of the box.

Exception while property mapping for target type "array", at property path "0": It is not allowed to map property "__initializer__".It is not allowed to map property "__initializer__".
You need to use $propertyMappingConfiguration->allowProperties('__initializer__') to enable mapping of this property.Exception Code1297759968Exception TypeNeos\Flow\Property\ExceptionLog Reference20170608161011564e18Thrown in FileData/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Flow_Property_PropertyMapper.phpLine129Original FilePackages/Framework/Neos.Flow/Classes/Property/PropertyMapper.php
Nested ExceptionYou need to use $propertyMappingConfiguration->allowProperties('__initializer__') to enable mapping of this property.Exception Code1335969887Exception TypeNeos\Flow\Property\Exception\InvalidPropertyMappingConfigurationExceptionLog Reference20170608161011b3769aThrown in FileData/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Flow_Property_PropertyMapper.phpLine186Original FilePackages/Framework/Neos.Flow/Classes/Property/PropertyMapper.php

Is your feature request related to a problem? Please describe.
Redactor don't understand why Youtube videos can be played in a lightbox (through https://github.com/jonnitto/Jonnitto.PrettyEmbedYoutube) and not for .mp4 videos

Describe the solution you'd like
The same option "Open Video in a Lightbox", as for PrettyEmbedYoutube

Describe alternatives you've considered

Additional context
... ready to sponsor this feature, please DM on Slack !

With PHP 7.3 parsing of the Fluid templated JS files fails with an NamespaceDetectionTemplateProcessor Exception.

See: neos/neos-development-collection#2484

Describe the bug
If I place one or more .vtt files as an asset, the caption button is not visible.

To Reproduce
Steps to reproduce the behavior:

1. Add a .vtt caption file