jonathanserafini / chef-cfn Goto Github PK

Because no version is specified of the aws-sdk-ruby gem here: https://github.com/JonathanSerafini/chef-cfn/blob/master/recipes/ohai.rb#L3, the newer version 3 is going to be installed.
Therefore this fails:
https://github.com/JonathanSerafini/chef-cfn/blob/master/files/default/ohai_plugins/cfn.rb#L38
with [2017-12-01T10:36:11+00:00] ERROR: cfn: failed to fetch instance: uninitialized constant Aws::EC2
As far as I can tell there's 2 different ways of fixing this. I don't know which solution you prefer otherwise I would've created a PR ;-)

• Version-lock the aws-ruby-sdk gem to < 3
  Or according to https://github.com/aws/aws-sdk-ruby#upgrading-guide:
• Require the whole SDK: require 'aws-sdk'
• Or just the classes that are needed: require 'aws-sdk-ec2'

Just commenting in case this is something being considered for refactor. The chef_lifecycle script in this repo is currently just a static file and greps for node_name in the client.rb to determine instance name.

Currently it is recommended to leave node_name out of the chef client.rb, see node_name setting here and let chef determine it automatically from ohai data. So node_name seems like sort of an odd thing to depend on here: https://github.com/JonathanSerafini/chef-cfn/blob/master/files/default/chef_lifecycle#L15

Maybe this could be moved to a template that is rendered with the node name via ohai data or be converted to just use the ohai data directly.

Thanks for providing this cookbook.