Code Monkey home page Code Monkey logo

Comments (5)

awaik avatar awaik commented on July 21, 2024 1

I agree with @mrgnhnt96
For ios we can just change the code to

    private func getExportPreset(_ quality: NSNumber)->String {
        switch(quality) {
        case 1:
            return AVAssetExportPreset640x480
        case 2:
            return AVAssetExportPreset960x540
        case 3:
            return AVAssetExportPreset1280x720
        default:
            return AVAssetExportPreset960x540
        }
    }

and we will have 3 normal resolutions for the real-world use-cases.

I use it in my app already, fixed in the branch, works stable. Do you want me to make PR?

For those who want to try, you can use it for tests or as temporary workaround

#  video_compress: ^2.1.1
  video_compress:
    git:
      url: https://github.com/awaik/VideoCompress

from videocompress.

jonataslaw avatar jonataslaw commented on July 21, 2024 1

I agree with @mrgnhnt96
For ios we can just change the code to

    private func getExportPreset(_ quality: NSNumber)->String {
        switch(quality) {
        case 1:
            return AVAssetExportPreset640x480
        case 2:
            return AVAssetExportPreset960x540
        case 3:
            return AVAssetExportPreset1280x720
        default:
            return AVAssetExportPreset960x540
        }
    }

and we will have 3 normal resolutions for the real-world use-cases.

I use it in my app already, fixed in the branch, works stable. Do you want me to make PR?

For those who want to try, you can use it for tests or as temporary workaround

#  video_compress: ^2.1.1
  video_compress:
    git:
      url: https://github.com/awaik/VideoCompress

You can made a PR with it

from videocompress.

janlektonen avatar janlektonen commented on July 21, 2024

I would like this new HighQuality also as DefaultQuality aka MediumQuality is a little to low and blurry... but I still want low filesize...

@jonataslaw Would we be able to set a own values for quality ? Or could you implement this new quality called HighQuality?

from videocompress.

jamesdixon avatar jamesdixon commented on July 21, 2024

The ability to adjust the quality on our own would be phenomenal. I think I'm also missing that sweet spot between medium and highest qualities.

from videocompress.

awaik avatar awaik commented on July 21, 2024

I agree with @mrgnhnt96
For ios we can just change the code to

    private func getExportPreset(_ quality: NSNumber)->String {
        switch(quality) {
        case 1:
            return AVAssetExportPreset640x480
        case 2:
            return AVAssetExportPreset960x540
        case 3:
            return AVAssetExportPreset1280x720
        default:
            return AVAssetExportPreset960x540
        }
    }

and we will have 3 normal resolutions for the real-world use-cases.
I use it in my app already, fixed in the branch, works stable. Do you want me to make PR?
For those who want to try, you can use it for tests or as temporary workaround

#  video_compress: ^2.1.1
  video_compress:
    git:
      url: https://github.com/awaik/VideoCompress

You can made a PR with it

Missed it. Will make PR on the weekend.

from videocompress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.