Comments (5)
I agree with @mrgnhnt96
For ios we can just change the code to
private func getExportPreset(_ quality: NSNumber)->String {
switch(quality) {
case 1:
return AVAssetExportPreset640x480
case 2:
return AVAssetExportPreset960x540
case 3:
return AVAssetExportPreset1280x720
default:
return AVAssetExportPreset960x540
}
}
and we will have 3 normal resolutions for the real-world use-cases.
I use it in my app already, fixed in the branch, works stable. Do you want me to make PR?
For those who want to try, you can use it for tests or as temporary workaround
# video_compress: ^2.1.1
video_compress:
git:
url: https://github.com/awaik/VideoCompress
from videocompress.
I agree with @mrgnhnt96
For ios we can just change the code toprivate func getExportPreset(_ quality: NSNumber)->String { switch(quality) { case 1: return AVAssetExportPreset640x480 case 2: return AVAssetExportPreset960x540 case 3: return AVAssetExportPreset1280x720 default: return AVAssetExportPreset960x540 } }
and we will have 3 normal resolutions for the real-world use-cases.
I use it in my app already, fixed in the branch, works stable. Do you want me to make PR?
For those who want to try, you can use it for tests or as temporary workaround
# video_compress: ^2.1.1 video_compress: git: url: https://github.com/awaik/VideoCompress
You can made a PR with it
from videocompress.
I would like this new HighQuality also as DefaultQuality aka MediumQuality is a little to low and blurry... but I still want low filesize...
@jonataslaw Would we be able to set a own values for quality ? Or could you implement this new quality called HighQuality?
from videocompress.
The ability to adjust the quality on our own would be phenomenal. I think I'm also missing that sweet spot between medium and highest qualities.
from videocompress.
I agree with @mrgnhnt96
For ios we can just change the code toprivate func getExportPreset(_ quality: NSNumber)->String { switch(quality) { case 1: return AVAssetExportPreset640x480 case 2: return AVAssetExportPreset960x540 case 3: return AVAssetExportPreset1280x720 default: return AVAssetExportPreset960x540 } }
and we will have 3 normal resolutions for the real-world use-cases.
I use it in my app already, fixed in the branch, works stable. Do you want me to make PR?
For those who want to try, you can use it for tests or as temporary workaround# video_compress: ^2.1.1 video_compress: git: url: https://github.com/awaik/VideoCompress
You can made a PR with it
Missed it. Will make PR on the weekend.
from videocompress.
Related Issues (20)
- #Issue Could not find com.otaliastudios:transcoder:0.9.1. HOT 15
- Remove permission of external storage. Issue in uploading on playstore
- Running from isolate throws exception
- MissingPluginException(No implementation found for method compressVideo and getFileThumbnail on channel video_compress) HOT 1
- will you please provide OC version for me? HOT 1
- java.lang.IllegalArgumentException: could not access /data/user/0/com.example.test_compress/app_flutter/Trimmer/VID_20230725_163032_446_trimmed:Aug4,2023-17:32:10.mp4 HOT 1
- Could not find com.otaliastudios:transcoder:0.9.1 HOT 13
- Work with isolate
- Missing link to repo in pub.dev
- Add support for dart native HOT 1
- compression cancel
- Please add more compression options
- Support for Windows/Linux
- Plans for Implementing Privacy Manifest Support?
- Inconsistent JVM-target compatibility detected for tasks 'compileDebugJavaWithJavac' (1.8) and 'compileDebugKotlin' (17). HOT 6
- Fatal error while transcoding, this might be invalid format or bug in engine or Android. VideoCompress HOT 1
- MissingPluginException(No implementation found for method setLogLevel on channel video_compress) HOT 4
- Compression progress never getting to 100 on iOS HOT 2
- Android issue
- Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from videocompress.