I'm subscribing to the progress of the compression to give visual feedback to the user

Having the same issue. Solving it in the following way: <div class="markdown-alert

For a workaround, see <a class="issue-link js-issue-link" data-error-text="Failed to l

Compression progress never getting to 100 on iOS about videocompress HOT 2 OPEN

notsag-dev commented on August 23, 2024

Compression progress never getting to 100 on iOS

from videocompress.

Comments (2)

marvin-kolja commented on August 23, 2024

Having the same issue. Solving it in the following way:

Note

This is not exactly how I use it. I'm using a class where I have a stream controller and a completer where the completer is completed once compression is finished, and the stream gets continuous progress updates.

int? percentage = 0;

final subscription =
    vc.VideoCompress.compressProgress$.subscribe((progress) {
  percentage = progress.toInt();
});

final vc.MediaInfo? mediaInfo = await vc.VideoCompress.compressVideo(
  file.path,
  includeAudio: true,
);

subscription.unsubscribe();

canceled = false;
failed = false;
File? compressedFile;

if (mediaInfo != null && mediaInfo.file != null) {
  if (mediaInfo.isCancel == true) {
    canceled = true;
  } else {
    compressedFile = mediaInfo.file!;
    percentage = 100;
  }
} else {
  failed = true;
}

from videocompress.

marvin-kolja commented on August 23, 2024

For a workaround, see #259 (comment).

Issue:

This line seems to be the issue:

VideoCompress/ios/Classes/SwiftVideoCompressPlugin.swift

Line 227 in e06673f

timer.invalidate()

The timer that updates the progress every 0.1 seconds may be invalidated before the 100% progress can be propagated.

Proposal:

I'd suggest invalidating the timer inside the updateProgress func once the progress has reached 100% or stopCommand is true:

@objc private func updateProgress(timer: Timer) {
    let asset = timer.userInfo as! AVAssetExportSession
    guard !stopCommand && asset.progress < 1.0 else {
        timer.invalidate()
        return
    }
    channel.invokeMethod("updateProgress", arguments: "\(String(describing: asset.progress * 100))")
}