The dotfiles-rs from jokeyrhyme

We need to start handling errors better:

use ? and return Result<> types in more places, instead of using .expect() or .unwrap()
tasks' sync() and update() should not return Result<>s, but should gracefully handle such values

Windows: set PATH as required

investigate using winreg to manipulate user's PATH in Windows registry as required

ssh: cipher list incompatible with old OpenSSH on Debian Stretch

/home/.../.ssh/config line 1: Bad SSH2 cipher spec '-3des-cbc,-blowfish-cbc,-cast128-cbc,-arcfour,-aes128-cbc,-aes192-cbc,-aes256-cbc,[email protected]'.

We should detect the available version of ssh first, and use the more verbose white-list approach for versions that are not compatible with the current black-list approach

pkg: nodejs: sync always installs all packages unnecessarily

Should probably call npm ls --global --depth=0 --json instead of without the --json

example output with something installed:

{
  "dependencies": {
    "clipboard-cli": {
      "version": "1.1.0",
      "from": "clipboard-cli",
      "resolved": "https://registry.npmjs.org/clipboard-cli/-/clipboard-cli-1.1.0.tgz"
    }
}

example output with nothing installed:

{}

rust: handle rustup-based rustfmt installation/transition better

ensure rustfmt is not installed via cargo, and cargo does not think rustfmt is installed
- this can be covered with cargo uninstall rustfmt rustfmt-preview
ensure rustup is updated
- with rustup self update
ensure rustup has installed and is managing rustfmt
- with rustup component remove rustfmt; rustup component add rustfmt
all of the above can be tested by seeing if cargo install --list includes rustfmt (it should not) and if cargo fmt --help has a success exit code

`utils::http::fetch_request()` needs to account for redirects, too

We already account for redirects in utils::http::download_request()
We need to do something similar in fetch_request()

0.9.0 can't build for Windows

   Compiling jokeyrhyme-dotfiles v0.9.0
error[E0433]: failed to resolve. Use of undeclared type or module `std`
 --> src\tasks\windows.rs:9:5
  |
9 |     std::fs::create_dir_all(&bin).expect(&format!(
  |     ^^^ Use of undeclared type or module `std`

error[E0425]: cannot find value `parent` in this scope
  --> src\tasks\windows.rs:11:10
   |
11 |         &parent.display()
   |          ^^^^^^ not found in this scope

error[E0308]: mismatched types
  --> src\utils\fs.rs:56:5
   |
55 | pub fn set_executable(target: &Path) -> std::io::Result<()> {
   |                                         ------------------- expected `std::result::Result<(), std::io::Error>` because of return type
56 |     Ok
   |     ^^ expected enum `std::result::Result`, found fn item
   |
   = note: expected type `std::result::Result<(), std::io::Error>`
              found type `fn(_) -> std::result::Result<_, _> {std::result::Result<_, _>::Ok}`

error: aborting due to 3 previous errors

ssh: need to ensure parent directory exists before writing

we write to a file without checking whether the parent directory exists first: https://github.com/jokeyrhyme/dotfiles-rs/blob/0.15.0/src/tasks/ssh.rs#L96

ssh: syncing ...
error: ssh: unable to write config: The system cannot find the path specified. (os error 3)

pkg: nodejs: Windows directory structure differs to everything else

Linux/macOS: ~/.local/node/bin
Windows: ~/.local/node

We need to tweak a few paths for Windows so that they properly refer to files that exist

`Result::unwrap()` panic during failed connections

HTTP/1.1 200 GET https://nodejs.org:443/dist/index.json
thread 'main' panicked at 'called Result::unwrap() on an Err value: IOError("A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (os error 10060)")', libcore\result.rs:945:5
note: Run with RUST_BACKTRACE=1 for a backtrace.

pkg: neovim: share settings with vim, install/update plugins

When nvim is detected, all the current work for vim should apply here, too
For Linux, the settings symlink should be to ~/.config/nvim/init.vim
Locations for plugins and settings should be confirmed on Windows and macOS

automatic GitHub Releases

https://docs.travis-ci.com/user/deployment/releases/

linter: rust-clippy

https://github.com/rust-lang-nursery/rust-clippy

pkg: mage

magefile.org
https://github.com/magefile/mage/releases

pkg: ngrok

https://ngrok.com/download

pkg: git: git-sizer

https://github.com/github/git-sizer

nodejs: Windows path does not have "bin" directory

we currently assume ~/.local/node/bin/node.exe on Windows
https://github.com/jokeyrhyme/dotfiles-rs/blob/0.15.0/src/utils/nodejs.rs#L41
https://github.com/jokeyrhyme/dotfiles-rs/blob/0.15.0/src/tasks/windows.rs#L12
but the correct path to the executable is ~/.local/node/node.exe

pkg: git: SSH instead of HTTPS for popular hosts

.gitconfig

[url "[email protected]:"]
    insteadOf = https://bitbucket.org/
[url "[email protected]:"]
    insteadOf = https://github.com/

GitLab ?

use GitHub token when available, use with Travis CI

builds are failing due to API rate limit

test utils::github::tests::latest_release_github_hub ... FAILED
test tasks::rust::tests::test_cargo_latest_version ... ok
failures:
---- utils::github::tests::latest_release_github_hub stdout ----
	HTTP 403 https://api.github.com/repos/github/hub/releases
headers: {"connection": "close", "status": "403 Forbidden", "x-github-request-id": "DDB8:0D44:C15F36:1E6B8C7:5ACBC36B", "content-type": "application/json; charset=utf-8", "x-content-type-options": "nosniff", "content-security-policy": "default-src \'none\'", "x-ratelimit-reset": "1523305877", "date": "Mon, 09 Apr 2018 19:47:56 GMT", "x-ratelimit-limit": "60", "x-ratelimit-remaining": "0", "access-control-expose-headers": "ETag, Link, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval", "x-runtime-rack": "0.021397", "server": "GitHub.com", "referrer-policy": "origin-when-cross-origin, strict-origin-when-cross-origin", "x-frame-options": "deny", "content-length": "247", "access-control-allow-origin": "*", "x-github-media-type": "github.v3; format=json", "x-xss-protection": "1; mode=block", "strict-transport-security": "max-age=31536000; includeSubdomains; preload"}
{"message":"API rate limit exceeded for 34.233.56.198. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://developer.github.com/v3/#rate-limiting"}
thread 'utils::github::tests::latest_release_github_hub' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: StringError("non-success") }', libcore/result.rs:945:5

T: Into<String> + AsRef<str>

cfg: ssh: `sync` should manage ~/.ssh/config

dynamically retrieve list of available Ciphers, KexAlgorithms, and MACs and cull weak algorithms (e.g. CBC, SHA-1)
ensure other settings are as desired

when setting up a new machine, PATH will not include ~/.local, etc
this breaks the behaviour of many tasks

when retrieving Release information from GitHub, we currently rely on GitHub Release metadata to filter out non-stable releases
we should also check for certain strings within the version in order to filter out non-stable releases: e.g. alpha, beta, canary, preview, rc

pkg: yq

https://github.com/mikefarah/yq

jokeyrhyme / dotfiles-rs Goto Github PK

dotfiles-rs's People

Contributors

Stargazers

Watchers

dotfiles-rs's Issues

Recommend Projects

Recommend Topics

Recommend Org