Code Monkey home page Code Monkey logo

music-discord-rich-presence's Introduction

Hi, I'm jojo2357 and I code open source for fun and make some cool things. Check out the pins below!

Favorite Languages:
jojo2357's most used langs


jojo2357's GitHub Stats

My sponsors:

5 largest sponsors:

5 most recent sponsors:

A big thank you to all my sponsors!

To sponsor me, go to my sponsor page. Any amount means a lot to me, so thanks.

music-discord-rich-presence's People

Contributors

github-actions[bot] avatar jojo2357 avatar odakab avatar smaltin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

music-discord-rich-presence's Issues

DRP doesn't launch automatically when I open MusicBee

So i followed your instructions and the DRP works perfectly (the status shows album art, track title and artist name as expected) but won't launch when MusicBee opens, I have to run manually DRP in order to get MusicBee displayed on my Discord profile.
If the linking did not work, you said to unlink DRP and redo the installation, but it did not work for me :/

Album title too long

Tried to play a song, here's what DRP has to say: (Length of string is out of range. Expected a value with a maximum length of 32)
image

Thus resulting to this:
image

Here is what the album title looks like lmao:
image

And it's written in the .dat file as "dinnerisnotovertheressomethinghappeningkeymancupid" (50 characters). Is there a workaround for this?

Issue with running DRP hidden.

Hey, I'm having a strange issue with RunHidden.bat. It claims that DiscordPresenceConfig.ini doesn't exist, when it clearly does. The program works just fine with discord, but it just doesn't like using runHidden.
image
I definitely have a DiscordPresenceConfig in there.

Same art for different albums causes issues

When filling out a keyed dat file (album name=album) using the same "album" value for multiple albums causes only the first album to receive the art and the others do not.

Custom Play and Pause icon pictures.

I think there should be a custom play and pause small icon picture in The Discord Rich Presence.

A custom play and pause icon pictures should be implemented so that rather than having the same icon of the Music player on both of the Small and Large Images when we don't key an album on the songs.dat file, we can customize it to anything we like as the default small icon of the Rich Presence is the music player.

Playing a unkeyed Album:
💬﹚adda-chat - Discord 12_25_2021 09_44_55 PM
Paused unkeyed Album
💬﹚adda-chat - Discord 12_25_2021 09_45_04 PM

Playing Keyed Album:
💬﹚adda-chat - Discord 12_25_2021 09_54_43 PM

Paused Keyed Album:
💬﹚adda-chat - Discord 12_25_2021 09_56_49 PM

I want to be able to customize the small pause icon. A play Icon is not needed but, a feature to customize it will be helpful.
I also want to be able to show the paused icon when the player is paused.

Problems with menu + shortcuts

as pointed out in the #29 thread, the new menu is buggy. Heres what doesn't work:
0: doesnt create shortcuts
1: doesnt launch mdrp
4-7: allegedly does not work with spaces (has not been replicated by me yet)

DRP only shows playing songs locally, not for other people

I've been tweaking with this since I found it recently, and I've gotten it to play most of the unreleased music I frequently listen to however, I was able to get someone on discord to see it momentarily but it kept disappearing according to them, I've logged into an alt discord account and have attached pictures below.

Secondly, much less critical, it seems difficult to set album art for the unreleased music I spoke of obviously, it can't grab them automatically because the songs aren't released but trying to do it manually through the file didn't work for me either but this issue is less important than the main one.

DRP local
DRP view from alt acc

Release zip file has repeated "taskkill" in KillHidden.vbs whereas the repo code does not

Concerned File:

KillHidden.vbs

Description:

I was digging into why the GroovyRP was not closing when I closed Groove, and here's this weird thing I found:

The KillHidden.vbs in the zip file from the Release page contains the code as shared in the below screenshot:

image

Whereas the code for the same file is correct one in the repository here:

objShell.Run("taskkill /im GroovyRP.exe"), 0, True
:

Rich Presence Fails to Find Song Details for Windows Media Player

Version
The version the bug was found on: 1.7.2

Describe the bug
MDRP cannot find any of the album keys until the equalizer is brought up in Windows Media Player on Windows 11 (previously Groove Music). Once the equalizer is brought up (the app seems to do some other things in the background as the song hangs for a second), MDRP finds the album key and everything works, until the song ends and the next one starts.

To Reproduce
Steps to reproduce the behavior:

  1. Open Windows Media Player
  2. Open MDRP
  3. Play something

Expected behavior
MDRP should find the album's key and display its title, the album art, the artist, and the album name in Discord.

Screenshots

Before opening equalizer:
image

Opening equalizer:
image

After opening equalizer:
image

Support for JRiver

Would be great if this supported JRiver, the newest version of which is 30.

For some reason, album art is not showing up...

I am on release 1.5.5
The album art works for every single song, including new songs that I have added, all except for 1 song.
I have attempted to resolve the issue several times, and also ensured that the title in discord assets and the .dat file are correct.

Here's the song in Groove, so you can see the title and image.
image
Here's the image uploaded to discord assets.
image
Here's the .dat file (In text format bc i can't upload .dat files) and a screenshot of the line in the file (it's near the very bottom).
image
stuff.txt

Keep in mind that it is only for this song that DRP doesn't work, and I'm not sure why. I swear if it is actually a typo that I am blind.

not working :(

its not showing music on the terminal so not showing on the discord too. im using groove music

Tidal does not work

Tidal player is meant to work with the played but isn't actually a thing in the config ini. When the tidal application id for discord is added (which was provided by jojo) it does work but doesnt display album art.

DRP fails to update status when next song has same title

Basically, some of my songs have the same title in the metadata, since it is the same song. Because of this, they also have the same album art, and album name (the title of the song is the album name, like a single album). However, I may have variants of the song, such as abridged/full versions, and different versions by different singers, or covers. When Groove moves from one song to the next in the playlist, the change fails to be reflected in DRP, and the artist remains the same.

e.g. I have a song "SONG", and I have two versions, one sung by Singer A and the other by Singer B. Both versions have the same album art. Both songs also have the same metadata, excluding the artist. When I play SONG by Singer A, DRP displays Title: SONG and Artist: Singer A. When the song finishes and moves to SONG by Singer B, DRP still displays Title: SONG and Artist: Singer A.

This also occurs if I click the skip button or start playing a variant of the song, that is, Groove does not move to the song itself and I manually play it.
The issue does not occur if I play a different song and then play the variant. It only occurs when the 'same' song is played in succession.
I'm not sure if my explanation above is clear, as to me it feels a bit wordy, so feel free to ask me for clarification/further details.

Also, I'm glad to let you know that my previous issue where the RunHidden shortcut had a weird error no longer occurs in the latest release, so good job there!

Title and Artist do not display on 1.7.0

Version
The version the bug was found on: 1.7.0

Describe the bug
Music doesn't seem to update. Usually gets stuck on one song, or it gets stuck saying
Title:
Artist: Unknown Artist
I usually have to restart Windows Media Player for this to work, but the same problem keeps happening and I don't understand why or how since it's never done this before until today.

While typing this, I just noticed a new thing, some songs will not show, but others like Bohemian Rhapsody for example will show.
Discord_VF4SL6T8wu

To Reproduce
Steps to reproduce the behavior:

  1. Go to '1.7.0_Release folder' (Assuming that you already downloaded it)
  2. Click on 'Music_DRP_Launcher.bat' and hit '1 or 2'
  3. Scroll down to 'Music Details'
    3.5 The thing that may happen is that the first one may show, but the song after that may not. My recommendation would be to play a couple songs if you want to test this out as well.
  4. See error

Expected behavior
All the songs are supposed to show no matter the song name and/or album name.
I could care less about the Album Cover, but I do know that's already in the application since I read the readme and the changelog or whatever it's called.

Screenshots
If applicable, add screenshots to help explain your problem.
MDRP_6xnEo6z1mq
Discord_iaznHIkpEr

Additional context
I was messing with the ini file so that could also be my fault, but I would like to hear what you (the dev) and others (the community) have to say about this problem. I hope this makes sense since I'm not the best at explaining things and I hope you have a good one.
Thanks!

MDRP does not detect Music playing in Groove or WMP

Version
1.7.0

Describe the bug
MDRP says "Detected volume in something but not showing as it is not currently supported or is disabled", nothing appears on discord

To Reproduce

  1. Run MDRP
  2. Try to play anything on any of the supported programs
  3. See "Detected volume in something but not showing as it is not currently supported or is disabled"

Expected behavior
It should of showed the rich presence on discord.

Screenshots
image

Uninstall generates Windows Script Host error when closing Groove Music

Hi there! I downloaded MDRP out of curiosity to see how it worked and encountered an error message directly generated by Windows Script Host (see attached screenshot) when trying to uninstall. I followed the suggested steps of unlinking Groove Music first and killing the hidden DRP just in case, then deleted the downloaded zip file + extracted folder because I wouldn't need them anymore. As a result, every time I open and close Groove Music, I always get the same message that it can't find the KillHidden.vbs file despite everything being unlinked. When I restore the deleted extracted folder and bring it back into my downloads, the error message doesn't pop up anymore. Not sure if this is supposed to happen, but thought it was worth mentioning as it's quite annoying to get a popup each time when I don't plan to use MDRP :)

Version number: 1.7.2
Error message:
mdrp-error

MDRP fails to display rich presence after About Me discord update

Version
The version the bug was found on: 1.5.5

Describe the bug
Rich presence no longer shows up, even though MDRP says that everything is valid in windowed mode.

To Reproduce
Steps to reproduce the behavior:

  1. Install MDRP and set up as usual, locating Groove and linking.
  2. Run MDRP (windowed or hidden) when Discord and Groove are open
  3. No Rich Presence is shown

Expected behavior
I expected the usual MDRP rich presence to show up, with the application name, album art, song title, song artist (although this issue is not about album art).

Screenshots
Here's MDRP windowed, and the Discord profile:
image

Additional context
I believe it could possibly be due to the new 'About Me' feature that discord released. Maybe that affects the way rich presence works somehow? But it no longer works for me, even when I remove About Me. I already tried reinstalling MDRP as well, after removing About Me and restarting discord.
I'm wondering if this is something on my end, or whether MDRP is not working on the latest versions of discord. Apologies again if it's something on my end :)

Music details empty on every song

been having this issue on every song I try to play even though they all have all the details needed and I would appreciate some help with it

image

Fixed by doing the following:
made sure WMC was capturing the track that was playing as shown below and it fixed the issue
image

Issue with '=' in album name still persists...

I have attached screenshots of the discord application, the .dat file, the DRP window and the song details shown in groove for the relevant song.
By 'remove = from the keyset' I assume it means to just write in the album name as if the = was not there. Am I misinterpreting the instruction? The album artworks for all my other songs work perfectly fine.

What DRP shows (no purple confirmation text ): )
image

The image uploaded to Discord Application Assets:
image

The album in Groove:
image

What I have put in the .dat file:
image

Unhandled exceptions when running GroovyRP

When attempting to launch DRP from shortcut, I am faced with this error:

Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
at GroovyRP.Program.IsUsingAudio() in Music-Discord-Presence\GroovyRP\Program.cs:line 367
at GroovyRP.Program.Main() in Music-Discord-Presence\GroovyRP\Program.cs:line 123

I have thus far located and linked rich presence with Groove, and have no idea if I need to do anything else.

Played with icon and stuff in DiscordPresenceConfig.ini (Never again)

So, I try to change icons that were used in DRP (such as paused icon) and it lead me to this
image

After I paste a new link for the icon, that thing happened. I just realize that those icons has "app-assets" as parent folder and kinda bump out since I don't save the old link. Is there a way to fix this?

Not too sure what to do here

Detected volume in something but not showing as it is not currently supported or is disabled

What could this mean? Could it be happening because I have Groove running through Voicemeeter?
I have groove open, ran the batch file, selected the location of groove music. And after running MDP it gave me this error

image

Change icon to be more distinct from Discord

I found myself confusing this program and Discord in the task bar pretty often, it'd be great if you could alter the image so we can more easily differentiate it from normal Discord. I've made an alternative icon myself (uploaded to my Google Drive since GitHub doesn't allow .ico files as attachments), although I doubt you'd be allowed to use it since it includes the Groove icon as well.

https://drive.google.com/file/d/16_Y3lzGGOxeIRM73dqYdWFU6NlmaiHj5/view?usp=sharing

Custom album arts in clientdata/ seem to be associated to only 1 player at a time

I have 2 custom dat files in clientdata/ folder (apart from the default ones). One for groove, and the other for musicbee.
Before Installing musicbee the album arts were correctly working with groove.

But after creating another dat file for musicbee with the same contents as the first line and the only change being on line 1 music.ui=groove to musicbee, the DRP console shows "Album art not keyed".

After doing alot of hit and trials with different file names and contents, when i changed the 1st dat file's line 1 to musicbee the DRP console showed "This is a good one, ;-)"

(PS: apologies if it feels like im piling too many issues 😅 )

Local Album Art

Hi, is it possible to put local album arts in a folder instead of having to get every image link and add it myself?
I tried the remote option, but it doesn't seem to work. Maybe cause I have mostly japanese songs.
And also I have different album arts even in the same album.
Thanks!

Can't start the launcher

Version
1.7.2

Describe the bug
cmd show FINDSTR: cannot open with Music_DRP_Launcher.bat directory

To Reproduce
Steps to reproduce the behavior:

  1. Go to 1.7.2_Release folder
  2. Click on Music_DRP_Launcher.bat
  3. See error

Screenshots
Screenshot 2023-04-05 111244

Discord PTB compatibility

Pretty great utility. A little quirky to get working especially if you want album art to appear, but it works!

With having to work from home these days I've been having to use discord in a more professional manner, so I usually have two instances running.

Discord PTB, which has my personal account logged in and then
Discord, which has my work account.

Groove now playing shows up perfectly on Discord, but it's like Discord PTB doesn't exist at all. I know I could just swap the accounts, but Discord PTB's more frequent updates make it less than ideal for work.

I was wondering if there was something to update or edit to make MDRP detect both Discords or PTB instead of the regular one.

Failed to get track info WMP

Version
The version the bug was found on: 1.7.2

Describe the bug
playing something in wmp gives the error "Failed to get track info"

To Reproduce
Steps to reproduce the behavior:

  1. open mdrp
  2. play a song

Expected behavior
it to be able to get the track info

Screenshots
image
image

Unable to use in other drives

Well, I think I can't link Groovy in my E: drive. Not sure what is the problem but I saw it is probably looking for Groovy in my E: drive too.
set directory=%~dp0 Pushd %directory% at GroovyRP\bin\Release\FindGroove.bat
Also, it doesn't continue after one of these lines, didn't get to see echo I need to find the location of groove music on your computer, and the easiest way to do that is to open it and see where it came from

Windows 10 Media Player doesn't render rich presence correctly.

IF YOUR ISSUE...

Windows 10 Media Player metadata stops working after playing one track, it is also falsely detected as groove music.

Version
The version the bug was found on: 1.7.2

Describe the bug
When using the windows 10 media player, metadata is successfully loaded and displayed for the first track, though the application is displayed as groove music. Following the first track all metadata is just read as blank as shown in the screenshots below.

To Reproduce
Steps to reproduce the behavior:

  1. Link Rich Presence with Media Player
  2. Play more than one track

Expected behavior
The application displays the currently playing song in rich presence with the application appearing to be media player.

Screenshots
image
image

Custom art sometimes does not display

Hello, I have a really strange bug. Some of the covers I uploaded on my own application won't display.
I followed correctly the tutorial and most of my albums are displayed with their cover in Discord, however a few don't and I can't fix that.
The .dat file and the Discord application have the same asset name, the .dat file and the track tag have the same title BUT the cover doesn't display simply
Among the 60 albums I registered, I estimate the bugging album art covers around 10

See one of the culprits on the screenshots below :
tag
ddd
vscode
discord

Most of bugging albums are however displayed as below 👍
discord2

DRP with Discord

Hello,
Cool project. I'm using groove and discord. I get your batch file running. The program sees grove but I don't know how to link it to the discord app I already use.

Thanks

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.