johnzablocki / couchbase-aspnet Goto Github PK

As far as I can tell, there is no documentation stating limitations on the character set used by the Couchbase document key. If that is true, why base64 encode the key? This only serves to add CPU overhead and lengthens the key unnecessarily. Being able to see the statistics for a URL in the console is also of interest and encoding the value prevents that.

Is there a reason the provider implementations do not implement IDisposable since the client instance they contain implements IDisposable?

It surprised me to learn that asp.net mvc 3/4 actually requires an additional implementation step to have custom output cache working fully.

This blog post outlines the details:

http://www.haneycodes.net/custom-output-caching-with-mvc3-and-net-4-0-done-right/

But basically, a custom class that inherits from MemoryCache that uses couchbase internally and gets hooked up to the static OutputCacheAttribute.ChildActionCache property on application startup is needed.

Hope this is something you'll consider adding into this package!