johnwquarles / fancy-promise Goto Github PK

Looks like returning done() should return a resolved promise, not result.
See if that's indicative of any problem.
Can write updated tests like:

new Promise(done => {
  new Promise(resolve => resolve('theResult'))
    .then(result => `${result}IsEqual`)
    .then(result => `${result}ToThis`)
    .then(result => done(result));
}).then(result => console.log(res));

The only ones that should be available (at least without an underscore denoting a pseudo-private method) should be .catch and .then.

Could use a WeakMap and then retrieve methods for each instance as needed, using .call to call against the instance. But I wonder if this is a performance hit?

Should be easy, just same as 'then' without returning another (fancy) promise.