Code Monkey home page Code Monkey logo

kitapp's Introduction

kitapp's People

Contributors

6uliver avatar johnlindquist avatar semantic-release-bot avatar vojtaholik avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

kitapp's Issues

Apple Sillicon native builds

So I was browsing around the Electron-builder repo which you use to build the app of Script Kit and was interested in an Apple Silicon build for Script Kit, as Electron & NodeJS now support native builds for the M1 chip. Early next week I'm getting a M1 Mac Mini and am curious in testing out Script Kit for the new architecture.

From this pinned issue on electron-builder: electron-userland/electron-builder#5689, it looks like they support both M1 specific builds as well as universal builds which have a single package for both architectures. I would definitely be interested in pulling down a development branch of Script Kit and trying to get a functional build.

Is there anything important I should keep an eye on or things to watch out for when trying to build it as a native M1 app that is dependent on the architecture other than telling Electron to build for ARM & having the install-node.sh script in the kit repo grab either a universal or ARM build of Node?

is Linux development flow broken? couldn't build local app

I was trying to build kitapp locally on linux (ubuntu) and it was not straight forward. After tweakig certain things reached to a place where getting below message:
Error: Cannot find module '@johnlindquist/kit/cjs/enum'
Require stack:

  • /home/apurva/dev/kitapp/src/main.dev.ts
  • /home/apurva/dev/kitapp/node_modules/electron/dist/resources/default_app.asar/main.js

Is there any guide, which can help me setup scriptkit locally?

monaco-editor vite blocker

  • I'm porting Script Kit from webpack -> vite.
  • I followed the guide Vite guide w/ imports, self.Monaco, loader.config, etc

Everything works great in dev, but after I build, the app silently breaks. I think it's from trying to load the typescript worker, but I'm lost.

Btw, here's the relevant "vite" branch and "editor.tsx" file:

https://github.com/johnlindquist/kitapp/blob/vite/src/components/editor.tsx#L25

I'm guessing it's something I'd have to change in my "vite.config.ts", but I've tried everything I can think of and I'm lost:

https://github.com/johnlindquist/kitapp/blob/vite/vite.config.ts

Here's a video showing the bug in the production build:
https://youtu.be/Lmusf_1stsQ

Here's a production build from the "vite" branch you should be able to try it on:
https://github.com/johnlindquist/kitapp/releases/tag/v1.41.96

App Shortcut seems to assume QWERTY keymap

Prerequisites

Expected Behavior

While using the official 1.11.1 package with the system keymap set to dvorak after installation hitting cmd+; should bring up Kit.app (according to the message after installation).

Additionally when changing the app shortcut via Kit.app hitting cmd+; should set the shortcut to cmd+;.

Current Behavior

When the keymap is set to Dvorak Kit.app does not open with cmd+; after installation (it opens with cmd+z: the character which would be on the correct key if the keymap were QWERTY). Nor does it open with cmd+; if the shortcut is set via Kit.app by hitting cmd+; (likewise though the GUI shows the character character, the actual key that gets set is the one which would have that character in QWERTY).

Steps to Reproduce

Below all Hit commands mean "hit the key with this character on your keyboard" and assume you've got a QWERTY keyboard.

  1. Change your app shortcut to cmd+z
  2. Change the keymap to Dvorak
  3. Hit cmd+z
    Kit.app should open.
  4. Open Change App Shortcut
  5. Hit cmd+z
    The GUI should just go back to Run Script
  6. Open Change App Shortcut
  7. Hit cmd+/
  8. Hit T for yes.
  9. Hit cmd+/
    Nothing should happen.
  10. Hit cmd+z
    Kit.app should open.
  11. Change the keymap back to QWERTY
  12. Hit cmd+z
    Kit.app should open.

I haven't validated this, BUT: I'm guessing when you hit the keys to change the shortcut while in Dvorak mode it'll show you the character on the QWERTY key. Having installed with Dvorak it shows the correct Dvorak character. Even when I switch the keymap to QWERTY (so the key map appears to be static from install).

Possible Solution (Not obligatory)

I haven't dug through the code, but it appears that there's a "character to key code" map somewhere that assumes a QWERTY keymap.

Context

This was extremely confusing at first. The dialog after install actually says that cmd+; is the shortcut to open the app, but hitting that didn't do anything (though cmd+z seemed like a sane launch sequence for a QWERTY keymap). It wasn't until I thought about improper key mapping that I tried hitting cmd+/ that I realized the problem.

Now to change the shortcut I have to keep in mind that I need to hit the character for the key that would be in the proper place if I were using a QWERTY keyboard to actually get the proper key set (or I could switch the keymap to QWERTY, then hit the key combo I want).

Your Environment

  • Node version : v10.0.0
  • Kit.app version or branch : v1.11.1
  • Operating System and version : macOS 11.6.5
  • Link to your project :

Vim Keybindings

Keywords: vi mode, vim

It would be great if us Vim enthusiasts could operate Kit without our fingers ever leaving the home row.

As a first step, I'd suggest an optional keymap where the up/down arrow keys are aliased to hotkeys like ${cmd}+J and ${cmd}+K.

A Vim mode for the Monaco editor and the Chat interface would be great. If we could find a way to make selection/insert modes work for regular prompts, that would be absolute bliss.

Potential Issues

If we make the keymap optional, it might make some user-defined shortcuts work for some people, but once they share their scripts with others, those might conflict with the Vi mode keybindings.

React Libs

https://github.com/brijeshb42/monaco-vim

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.