johnjbarton / crx2app Goto Github PK

WindowsAdapter is by origin, not by tab. So how can we know when the debugger is closed?

1. record tabId.
   No multiple tabs from the origin can be debuggers
2. search all tabs for a matching origin.
   No we are only interested in debuggers from the origin.
3. track all tabIds that are debuggers for the origin,
   Ok.

4. Duh, use port onDisconnected event http://code.google.com/chrome/extensions/extension.html#type-Port

WindowsAdapter created in adapterFactory call from crxEnd
add onDisconnect. Undocumented argument is 'port'.
_disconnect windowsAdapter
refactor add _connect() for better doc
delete it

add _connect (call in ctor) _disconnect to TabsAdapter

If a file:// URL is used as the editor URL in the options page, then connection give DOM error 12 unless
the browser is running with --allow-file-access-from-files.

With the command line flag set, the file URL works.

Debugging file:// urls work with or without the flag.

Decide if DebuggerAdapter is one to one with debuggees or what