johndoh / roundcube-markasjunk2 Goto Github PK

in line 172 of drivers/email_learn.php

apparently now just named deliver_message() in rcmail.

Hi,

would it be possible to enhance the plugin by a config option containing an array of folders where the "Not Junk" button is shown instead of the "Junk" button.
In my case there are multple spam folders due to different namespaces. But marking mails as ham is only possible in the folder defined in markasjunk2_spam_mbox.

Best Regards
Chris

Hi,
After upgrading Roundcube 1.2.5 to 1.3.1, the Mark-as-junk2 button stays greyed out (disabled).
When an email is selected and clicking on the 'JUNK button' does not do anything.
Also when in the Junk-folder, the button is still disabled.
Is this a known bug?

When I try to mark more than one message at a time, all of them are moved to spam/inbox folder as it should, but only the first one is 'treated', showing the %d and %l variable values, but the second, third, etc don't.

Example:
Marking 2 messages as junk (at same time), the log file shows:

[28-May-2013 09:32:27 -0300]: /roundcube/folder/plugins/markasjunk2/myscript.py -f /roundcube/folder/temp/rcmMarkAsJunkaAi9Qj -s [email protected] -e username -o domainname.com
[28-May-2013 09:32:27 -0300]: array (
)
[28-May-2013 09:32:27 -0300]: /roundcube/folder/plugins/markasjunk2/myscript.py -f /roundcube/folder/temp/rcmMarkAsJunkbFBP6L -s [email protected] -e %l -o %d
[28-May-2013 09:32:27 -0300]: array (
)

I'm using the 1.6 version under roundcube 0.9.1.

With current trunk, clicking the markasjunk button results in Error: 'rcmail.message_list.rows[rcmail.env.uid]' is undefined.

Removing the use of rcmail.env.uid (matching program/js/list.js) seems to correct the problem:

http://github.com/trisk/RoundCube-Plugin-Mark-as-Junk-2/commit/37ca7ec656dfb7217ad9e20c8bc7f5870d64368d

Is it possible to have 'ham_mbox'/'spam-mbox' point to more than one mailbox?
I currently have users move/copy messages to two special mailboxes on their accounts - report-spam/report-ham. Those folders are periodically collected and emptied on the server by a cron job and fed into sa-learn.
So what I would ideally like to happen is when a user marks a message as SPAM it is moved to the 'junk' folder and a copy is placed in 'report-spam'. And when the user marks a message as HAM it is moved to the 'INBOX' and a copy is placed in 'report-ham'.

I have a working mail server built with iRedMail-0.8.7 (http://www.iredmail.org), Roundcube webmail (1.0.1) works fine. I downloaded the latest git master edition of "markasjunk2" and enable it, in Roundcube it always show a "Loading" label/indicator, after disable "markasjunk2" plugin, no such indicator anymore. So it looks like a bug of "markasjunk2".

My "markasjunk2" settings are mentioned in this wiki tutorial:
http://www.iredmail.org/wiki/index.php?title=IRedMail/FAQ/Store.SpamAssassin.Bayes.In.SQL#Enable_Roundcube_plugin:_markasjunk2

No error/warning message in Apache log file.

The "select_childs" function changed to "select_children" , since the 0.8.5 version in the commit ( # 1488772 ) .
I was having the error undefined function, try to mark as spam threads collapsed.

Hello,

I configured Roundcube with Sauserprefs and MarkAsJunk2 plugin. There is a line in config.in.php:
$rcmail_config['markasjunk2_sauserprefs_config'] = '../sauserprefs/config.inc.php';

Sauserprefs work fine when I use it directly. But when I mark message as Junk with MarkAsJunk2, no records appear in SA db. Also I viewed the code of plugin and I do not see any calls of the driver. Please fix or help me to solve if I am doing something not correctly.
Thanks in advance.

Hi,
The string:
$labels['notjunk'] = 'Not junk';
is not translated in the fr_FR.inc file.
I suggest:
$labels['notjunk'] = 'Acceptable';

The write_log calls use $email_to instead of $mailto.

I strongly suggest refactoring rcmail_markas{,not}junk2 and rcmail_markasjunk2_{move,delete} since these two pairs are updated often with the threading fixes and only differ in one statement.

I've made the first pair wrappers for a new rcmail_markasjunk2_mark function, and rcmail_markasjunk2_delete a wrapper for rcmail_markasjunk2_move:

http://github.com/trisk/markasjunk2/commit/57237ccad0d1a94081c42bc132045de8039d9fbf

With RC 1.2 I have not been able at all to install the plugin. I've tried the installation with plugin manager, as well as manual installation.

In the first case it seems to be installed correctly. I've added the plugin to the composer.json file and installed everything, but the plugin is not loaded. Unfortunately I could not find any error causing this behavior.

When I'm installing the plugin manually (download, add to main.inc.php) RC complains, that the plugin should be loaded via plugin manager and refuses to run at all.

I will happily provide any further information, if that would help.

Thanks for the awesome plugin! Despite that we have blazinglly fast server with lots of RAM and still there is a great delay if you report message as spam by using sa-learn command.

I understand that it's not the plugin issue but I prefer to send sa-learn command at the background process! I would like to recommend to add an option in config file to be able to chose if it goes to background or not?

Hi,

I got two servers:

mail = postfix + dovecot + spamassassin + clamav + amavisd
www = apache + roundcube(webmail)

When setting up this plugin, I need to edit the file: plugins/markasjunk2/config.inc.php

$config['markasjunk2_spam_cmd'] = 'sa-learn --spam --username=vmail %f';
$config['markasjunk2_ham_cmd'] = 'sa-learn --ham --username=vmail %f';

Will those commands work? Because I have webmail in a separated machine?

Thanks

Hi,

I'm using your latest Mark-as-Junk 2 1.2 with Roundcube 0.4, and I have the problem stated in the title. When I try to mark multiple messages as ham so they are moved from my Junk folder to my Inbox in roundcube. I encounter the message "Unable to read message from server" error. A refresh fixes the problem. Do you have any idea what causes the problem? If you need any more information please tell me. Also here's the list of plugin I'm using with my setup:
'vlogin',
'squirrelmail_usercopy',
'archive',
'filesystem_attachments',
'database_attachments',
'emoticons',
'help',
'new_user_dialog',
'password',
'subscriptions_option',
'automatic_addressbook',
'jqueryui',
'calendar',
'crawler',
'contextmenu',
'globaladdressbook',
'messagesize',
'markasjunk2',
'zipdownload',
'forwardattachment',
'message_highlight',
'keyboard_shortcuts',
'compose_addressbook',
'listcommands',
'google_contacts',
'settings',
'moreuserinfo',
'rcguard',
'fail2ban'

Thuan N. Tran

I'm having a really strange issue where sa-learn is not working through RoundCube. The debug log shows it running and it reports "Learned tokens from 1 message(1)". But "sudo sa-learn --dump magic" shows the nspam count has not gone up, and when I run "sa-learn --spam msgfile" via shell, then it reports learning the message as spam.

The strange thing is, when I mark as junk via RoundCube, I can see the bayes_toks database has changed (MD5 changes), yet it clearly has not learned this message.

Other people are having this issue as well:
http://www.roundcubeforum.net/index.php/topic,5957.0.html

Any ideas on how to troubleshoot this?

I've been asked if core's markasjunk plugin could be easily replaced with your plugin. So, I have questions to you:

1. What do you think about this?
2. Can your plugin (with default configuration) work as markasjunk plugin does? I don't want to make the switch a big regression or too much trouble for current markasjunk plugin users.

Would be good to know the answers before I put my hands on this.

From reading the comments in your code, it seems like MAJ2 configures SA to learn any message moved to the spam mailbox as spam. Does this include messages that are NOT moved into the spam mailbox by clicking the MAJ2 button? For example, if I mark something as junk in Thunderbird and it moves the message the spam mailbox, will MAJ2 and SA learn that message as spam?

Could you please update the code so this does not show (or is suppressed) for messages in the sent items folder? (as is the case for drafts folder).

Your plugin don't fetch mails after marking as spam/ham. The else operations like moving or deleting are fetching mails, after their done.
If I set 10 messages per page and I mark two as spam I'll have only 8 messages at the 1st page.

hello @johndoh ,
thanks for the great plugin!

my setup:

• roundcube v1.1.6 LTS
• melanie2 skin v0.4.5 https://github.com/messagerie-melanie2/Roundcube-Plugin-Mobile
• markasjunk2 plugin v1.9
• filter_learn driver v2.0 (for the markasjunk2 plugin) https://gitlab.com/Maxime_Barrast/filter_learn
• filters plugin v2.1.6 https://github.com/eagle00789/RC_Filters

with the above setup, i have roundcube with client-side spam filtering (does not affect the server-side filter, on purpose).

my request: the markasjunk2 plugin has a provision for the "mark as junk" options to be put into the mark [as] dropdown from the mailbox toolbar - i have not been able to get that to work - and would like to have it work in that dropdown, and have been having to just use it in the primary mailbox toolbar instead, in desktop view.

and then as a secondary, lower priority request: do you have any insight as how to get the "mark as junk" and "mark as not junk" buttons to integrate into the melanie2 skin for mobile?

Hi! We use roundcube 1.3.6 and markasjunk2 1.12
Selecting multiple messages and marking them as notspam doesn't work. Headers become edited, but messages remain in SPAM folder.. Is it bug?

Hi

It is a nice plugin, and very helpful. There are couple bugs I found:

1. After click on Mark as Spam, it does not highlight the next email (some time it worked, but most didn't).
2. After all emails have been moved away from current folder, the Mark as Spam button is not grayed out.
3. If click on the Mark as Spam button without any email been selected, then you won't be able to select and move or delete any emails.

The email_learn driver uses the rcube_mail_mime class which has been dropped in RoundCube post-0.3.1, and also calls rcmail_deliver_message() without the required 6th argument.

This is useful for programs like dspam which expect to read a message from standard input, and saves the overhead of writing out to a file:
http://github.com/trisk/RoundCube-Plugin-Mark-as-Junk-2/commit/c32a4b2e1c461f3fe0590e4380d3688c9f5e2cea

Is possible to make edit_headers to only edit headers and move the message to Junk/Inbox instead of moving the copy of the original message to Trash?

when using virtual aliases, and keeping to-header original when delivering through dspam, dspam expects another email in the --user parameter than the standart email alias. So email was send to [email protected] where b is an alias of [email protected] then dspam keeps track of the mail in [email protected] while mark-as-junk2 gives [email protected] - resulting in dspam not learning the false classified mail.

To work around this, I use a simple shell script which looks up the correct Email address in the dspam database (which only works when using some SQL-Backend for dspam) and works as a wrapper for dspam:

/usr/local/bin/dspam-relearn

#!/bin/bash

SQLPASS="XXXXXXXXX"
SQLUSER="dspam_unprivileged"
SQLBASE="dspam"
MODE=$1
SIG=$2

USER=$(echo "SELECT vu.username FROM dspam_virtual_uids vu, dspam_signature_data sd  WHERE sd.uid=vu.uid AND sd.signature = '$SIG';" | mysql -u $SQLUSER -p$SQLPASS -N $SQLBASE)
/usr/bin/dspam --source=error --class=$MODE --user $USER --signature=$SIG

I then call it like

$config['markasjunk2_spam_cmd'] = '/usr/local/bin/dspam-relearn spam %xds';
$config['markasjunk2_spam_cmd'] = '/usr/local/bin/dspam-relearn innocent %xds';

This works realy good so far, but might throw some errors when there are multiple recipients on the same server and thus more than one entry in DSpam's storage - I am not sure if these entries will have a different signature.
I could work around this by including a list of all aliases of the user and filter the virtual uids with that - but was not necessary yet.

Hi there, can you please advise on how to make the MarkAsJunk button add spam emails to a global blacklist?

My roundcube users are [email protected] but our primary email address is office@ that feeds messages to every user@

I want to be able to let every user update the global blacklist so they no longer get spam through office@

Do you want to implement
$rcmail_config['markasjunk2_learning_driver'] = array('cmd_learn', 'sa_blacklist')
type configuration? eg. I want to mark a message and add the from address to blacklist.

Marking from the message view now throws an error because rcmail.message_list is undefined. Checking for it is sufficient: http://github.com/trisk/markasjunk2/commit/c615a606d2429b485f8762709b9da5e762afc8b5

When I use the Larry theme my apache error log reports:

File does not exist: /var/lib/roundcube/plugins/markasjunk2/skins/larry, referer: https://.../?_task=mail&_refresh=1&_mbox=INBOX

Hi,

I'm trying to use this driver in Roundcube 1.0.1, but the button does not perform any function. When it is active in roundcube is eternally loading.

Can you give any tips to configure it.

Thx

The IMAP code was moved to rcube_imap_generic in r3429, so accessing the IMAP flags needs to switch from $GLOBALS['IMAP_FLAGS'] to $rcmail->imap->conn->flags: http://github.com/trisk/markasjunk2/commit/61a85ece99b6d2eb0a297b3d74965c079d7c6e01

I am getting Uncaught TypeError: undefined is not a function when running Roundcube with MarkasJunk2.

It seems to happen in rcmail_markasjunk2_update()

and seems to be relating to the following line:

if (rcmail.env.markasjunk2_override || rcmail.is_multifolder_listing()) {

An extra overlay is made visible when using Help_UI.

Details are here:
http://www.roundcubeforum.net/7-third-party-contributions/46-api-based-plugins/7015-new-plugin-help_ui-beta-version.html

Would it be possible to always show both "mark as (no) junk" buttons at the same time - depending on a custom config value set to 'true'?

Would be great for environments in which the spam mails are marked as spam by adding "_SPAM_" in the subject and not moving them into the junk folder (please don't question this behavior ^^) . Which means the spam mails are (temporarily) located in the inbox folder. In this case users should have the possibility to mark such a spam message as "no junk". At the moment they would have to move the message to the spam folder by hand and then mark it as "no spam".

If both buttons are shown at any time this scenario would be much easier...

Hi, it is possible use external spamassassin server?

I have roundcube on server A and postfix with spamassasin and amavisd in server B.
How I can use external spamassasin server?

Please contact me via email.

`<?php
/* Author: Denny Lin */

$labels = array();
$labels['buttonjunk'] = '标为垃圾邮件';
$labels['markasjunk'] = '标为垃圾邮件';
$labels['buttonnotjunk'] = '非垃圾邮件';
$labels['markasnotjunk'] = '非垃圾邮件';
$labels['notjunk'] = '非垃圾邮件';

$messages = array();
$messages['reportedasjunk'] = '已标为垃圾邮件';
$messages['reportedasnotjunk'] = '已移至收件箱';
`

It would be nice to be able to specify the name of the folder to move ham to rather than having it hardcoded to INBOX. The reason being is that my users move their wrongly tagged spam to a "ham" folder which the mail server then picks the mail up from, learns it as ham and then moves it to their INBOX.

Thoughts?

This bug breaks the optional flagging and mark as (un)read functionality.

In markasjunk2.php
$this->_ham($uid);
should be:
$this->_ham($uid, $dest_mbox);
and
$this->_spam($uids);
should be:
$this->_spam($uids, $dest_mbox);

plugin does not seem to work if preview pane is enabled.
"mark as no spam" button is always visible - which does not make any sense in any folder different than Junk

I have the plugin working somewhat on RC ver. 1.1.3 and 1.0.3. However with either version of RC and different versions of the plugin I never get a "Not Junk" button in any mailbox? I have tried with MS EDGE, Firefox, and Chrome all with same result. I am using uniserver on Windows 10 as the web server.