johnbrett / hapi-level Goto Github PK

Hi John,
I'm trying out your hapi-level-sample project on Windows (thanks!) but it won't build on Windows 10 (with VS 2015) due to the reference to level 0.18.x. That version of level relies on an old node-gyp which is incompatible with Win10/VS2015 (and Win 8.1 I'd guess). I forked your repo and changed package.json to refer to level version 1.3.x. It then builds ok and hapi-level-sample seems to run fine.

Conor

Version 2.0.0 of hapi-level has been released with updated level dependency which improves support for windows closing: #1

I've released 3.0.0 also with an update to the sublevel dependency. This update contains a breaking change in sublevel that will corrupt your database so update with care. There is a database migration tool link in the README.

I made the 2.0.0 and 3.0.0. releases separate so in 2.0.0 you can use hapi-level with the latest version of hapi with your current leveldb database, and 3 upwards will be for leveldb databases using sublevel@6 and above.

Hi

I am just wondering whether you will accept a PR for changing how plugin is exposed, the change would be to either decorate the server object or add to server.app namespace. I normally never use plugin expose method because it is limited to the handler functions and cannot be used globally within hapi. I would rather contribute to this module than maintain another module.

Thanks
Simon