john000708 / barrels Goto Github PK
View Code? Open in Web Editor NEWA plugin which replicates the popular barrels found in modpacks.
License: GNU General Public License v3.0
A plugin which replicates the popular barrels found in modpacks.
License: GNU General Public License v3.0
Barrel doesn't function as a barrel... more as a very expensive to make trash can block. Cargo nodes or direct GUI use when placing items in, barrel keeps status of "empty" under all conditions.
Easiest to test might be to - in an existing storage system - replace a small, big, or large barrel with the deep storage barrel and observe the difference.
Would expect this to operate the same as the barrels of smaller size.
No noticeable errors or console log entries in regards to this issue.
[15:19:36 INFO]: Paper v1_14_R1 (paper-628.jar)
[15:19:36 INFO]:
[15:19:36 INFO]: CS-CoreLib vDEV - 64 (git 9091bb0b)
[15:19:36 INFO]: Slimefun vDEV - 135 (git f54fd125)
[15:19:36 INFO]:
[15:19:36 INFO]: Installed Addons (8)
[15:19:36 INFO]: Barrels vDEV - 2 (git 847bc83)
[15:19:36 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[15:19:36 INFO]: ChestTerminal v1.0
[15:19:36 INFO]: HotbarPets vDEV - 10 (git 7d790905)
[15:19:36 INFO]: ExoticGarden vDEV - 17 (git 122f5555)
[15:19:36 INFO]: SoulJars vDEV - 3 (git ebabf39f)
[15:19:36 INFO]: ElectricSpawners vDEV - 2 (git 49ffa319)
[15:19:36 INFO]: ColoredEnderChests vDEV - 4 (git 2ce8ec8d)
Due to LORE_DATA
in Barrel.java being mostly invalid formatting code, it gets truncated to "§e§l"
rather than "§b§a§r§r§e§l"
. This causes the empty line in the lore and leads to updateBarrel()
never finding lore that matches LORE_DATA
, which means the blank line is never removed. It's a simple fix, either remove the invalid parts of LORE_DATA
or change it to something else entirely without using invalid formatting codes.
I'm a Chinese and I want to use it in my server.
So i have to translate it.
but Messages and name are in code, and it's hard to translate
Input/Output nodes connected to Barrels no longer have any effect. Items on sending end do not get taken, items on receiving end are never sent to.
Put items into barrel, attach input cargo node... whitelist item to a container (such as chest) with corresponding output node. Attempt moving items from a chest into the barrel reversing the input and output nodes.
Should work as usual.
I am sometimes able to get an error generated from barrels, but only when attempting to break and move them, nothing appears in the logs when they are being completely inactive while attached to cargo nodes with or without inventory available to move.
[13:51:46 INFO]: Paper v1_14_R1 (237)
[13:51:46 INFO]:
[13:51:46 INFO]: CS-CoreLib vDEV - 79 (git ec5b4c24)
[13:51:46 INFO]: Slimefun vDEV - 375 (git 129b98df)
[13:51:46 INFO]:
[13:51:46 INFO]: Installed Addons (11)
[13:51:46 INFO]: Barrels vDEV - 7 (git 0d14dd9)
[13:51:46 INFO]: SlimeXpansion vDEV - 4 (git 5bf10c29)
[13:51:46 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[13:51:46 INFO]: ChestTerminal vDEV - 19 (git ebf13b83)
[13:51:46 INFO]: HotbarPets vDEV - 20 (git cd87bc60)
[13:51:46 INFO]: ExoticGarden vDEV - 23 (git bf609e1c)
[13:51:46 INFO]: SlimefunOreChunks vDEV - 3 (git 7ddf966e)
[13:51:46 INFO]: ElectricSpawners vDEV - 5 (git c3f8cc9d)
[13:51:46 INFO]: ExtraHeads vDEV - 7 (git 9ddae055)
[13:51:46 INFO]: PrivateStorage vDEV - 6 (git b012877e)
[13:51:46 INFO]: DyedBackpacks vDEV - 1 (git 4b4d1f0f)
I placed a barrel (big) inside a barrel (big) - it was placed in the bottom slot, and shortly after the server crashed.
The slimefun generated error log:
https://termbin.com/xi30
I initially updated #6 with this information, but realized that this may be a different issue (or possibly another symptom of the same root cause) SO I figured I should create a new ticket, just in case.
sf versions output:
https://i.imgur.com/hFDhjMO.png
(I am using Spigot 1.14.4, not CraftBukkit like it says)
Item in lower center of GUI which indicates what is being stored can be removed as an inventory item.
Place 2 stacks worth of any item into any barrel. Remove the item indicator that appears in the lower center. Furthermore... I try using this item as the whitelisted item in an Input node you've attached to your barrel if you'd like to see the barrel magically vanish all of its contents. Possibly related bug: if you've got an Input node attached to an empty barrel, it will stay empty forever no matter what you put into it.
This item should be locked into the GUI and non-removable to solve at least 2 of the above 3 issues.
No errors or significant mentions of the events in logs.
[15:19:36 INFO]: Paper v1_14_R1 (paper-628.jar)
[15:19:36 INFO]:
[15:19:36 INFO]: CS-CoreLib vDEV - 64 (git 9091bb0b)
[15:19:36 INFO]: Slimefun vDEV - 135 (git f54fd125)
[15:19:36 INFO]:
[15:19:36 INFO]: Installed Addons (8)
[15:19:36 INFO]: Barrels vDEV - 2 (git 847bc83)
[15:19:36 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[15:19:36 INFO]: ChestTerminal v1.0
[15:19:36 INFO]: HotbarPets vDEV - 10 (git 7d790905)
[15:19:36 INFO]: ExoticGarden vDEV - 17 (git 122f5555)
[15:19:36 INFO]: SoulJars vDEV - 3 (git ebabf39f)
[15:19:36 INFO]: ElectricSpawners vDEV - 2 (git 49ffa319)
[15:19:36 INFO]: ColoredEnderChests vDEV - 4 (git 2ce8ec8d)
After placing a barrel of any size down, the barrel starts to add multiple items of either what is in the barrel on top of it, or the barrel adds the barrier sign over and over if no items are in the barrel.
Here's the screenshot
This should not happen. All we should see on top is one single item with the counter
Here's the slimefun version info
Description (Required)
when you use a explosive pickaxe next to a machine on a normal minecraft block it gives a error
but when i use the explosive pickaxe i dont get this error and the block i wanted to break gets removed
Steps to reproduce the Issue (Required)
https://streamable.com/hjnzu
Expected behavior (Required)
not get a error and remove the block normal vanilla block
Server Log / Error Report
https://hasteb.in/ahunelew.sql
Environment (Required)
05.11 13:07:35 [Server] INFO Paper v1_14_R1
05.11 13:07:35 [Server] INFO CS-CoreLib vDEV - 76 (git aaef21bd)
05.11 13:07:35 [Server] INFO Slimefun vDEV - 329 (git 57da6db)
05.11 13:07:35 [Server] INFO Installed Addons (4)
05.11 13:07:35 [Server] INFO Barrels vDEV - 7 (git 0d14dd9)
05.11 13:07:35 [Server] INFO SlimeXpansion vDEV - 4 (git 5bf10c29)
05.11 13:07:35 [Server] INFO SlimefunOreChunks vDEV - 2 (git 24d90a3e)
05.11 13:07:35 [Server] INFO DyedBackpacks vDEV - 1 (git 4b4d1f0f)
Cargonet glitches out barrels, a block can be placed in the empty space where it was previously, restarting server caused the display icon to float where it was but using worldedit to set the diamond block causes it to drop two of the blank named glass panes
Slimefun/Slimefun4#1949
according to the developer of the main plugin this addon is for this plugin has all these issues, please fix these
I do not have steps to reproduce it unfortunately
not to glitch out
initial error, was spamming console: https://pastebin.com/raw/MHt50JAG
error after a restart and worldedit a diamond block then breaking it: https://pastebin.com/raw/HBvGE8Pf
I am using slimefun as of my PR from earlier so Slimefun/Slimefun4@dc351f5
SF error log:
https://termbin.com/ugu5
Barrel display hologram stays after barrel is broken
After several successful attempts at duplicating this, Barrels completely broke and new barrels accept items, but do not register those items in inventory or on the display, causing the items to be lost.
I'm fairly certain this is broken due to changes in CS-CoreLib or Slimefun4, however I'm not capable of verifying that.
Errors flood to log from startup.
Start server in 1.15.2 with active barrels in the world.
To startup without these errors.
[21:59:04 INFO]: Paper v1_15_R1 (67)
[21:59:04 INFO]:
[21:59:04 INFO]: CS-CoreLib vDEV - 80 (git e3242c60)
[21:59:04 INFO]: Slimefun vDEV - 408 (git 73b64e87)
[21:59:04 INFO]:
[21:59:04 INFO]: Installed Addons (13)
[21:59:04 INFO]: Barrels vDEV - 8 (git 447cb)
[21:59:04 INFO]: DyedBackpacks vDEV - 1 (git 4b4d1f0f)
[21:59:04 INFO]: ElectricSpawners vDEV - 6 (git 845b6076)
[21:59:04 INFO]: SlimefunOreChunks vDEV - 3 (git 7ddf966e)
[21:59:04 INFO]: SlimeXpansion vDEV - 4 (git 5bf10c29)
[21:59:04 INFO]: ExtraHeads vDEV - 9 (git 32435a1f)
[21:59:04 INFO]: SoulJars vDEV - 10 (git 58202ab6)
[21:59:04 INFO]: HotbarPets vDEV - 23 (git 37b50104)
[21:59:04 INFO]: SlimyTreeTaps vDEV - 3 (git c4f773fa)
[21:59:04 INFO]: PrivateStorage vDEV - 8 (git 6b242fc5)
[21:59:04 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[21:59:04 INFO]: ChestTerminal vDEV - 20 (git a698c614)
[21:59:04 INFO]: ExoticGarden vDEV - 25 (git b5fce971)
Breaking barrel causes the "status item" that floats above the barrel to be dropped - infinitely - forever - in the location the barrel was originally. Cannot destroy with lava, but can with minecraft:kill command.
Place barrel, break barrel and observe.
https://youtu.be/9nWPEjeutCM
If barrel has an inventory, that inventory should explode onto the ground and drop itself. If barrel does not have inventory, that barrel should just break and should only drop itself.
No log activity.
[14:15:09 INFO]: Paper v1_14_R1 (209)
[14:15:09 INFO]:
[14:15:09 INFO]: CS-CoreLib vDEV - 77 (git 6e171836)
[14:15:09 INFO]: Slimefun vDEV - 295 (git 1d509cf5)
[14:15:09 INFO]:
[14:15:09 INFO]: Installed Addons (12)
[14:15:09 INFO]: Barrels vDEV - 7 (git 0d14dd9)
[14:15:09 INFO]: SlimeXpansion vDEV - 4 (git 5bf10c29)
[14:15:09 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[14:15:09 INFO]: ChestTerminal vDEV - 17 (git 933a7d36)
[14:15:09 INFO]: EmeraldEnchants vDEV - 5 (git 6adbbb87)
[14:15:09 INFO]: HotbarPets vDEV - 20 (git cd87bc60)
[14:15:09 INFO]: ExoticGarden vDEV - 22 (git a855f5b7)
[14:15:09 INFO]: SoulJars vDEV - 4 (git 4a600aa2)
[14:15:09 INFO]: SlimefunOreChunks vDEV - 2 (git 24d90a3e)
[14:15:09 INFO]: ElectricSpawners vDEV - 5 (git c3f8cc9d)
[14:15:09 INFO]: ExtraHeads v1.1
[14:15:09 INFO]: ColoredEnderChests vDEV - 7 (git 6885cb88)
sorry posted this to wrong github..
I am attempting to use the Barrels and ExtraGear plugins from @TheBusyBiscuit's Repo server page, but it isn't showing up in /pl. No errors show up in the console about it failing to load.
Items are not stored in barrels, just eaten up when put in the block. They do not drop on the floor when broken. The item is set as the barrel "item type" but no items are actually stored.
I'm not sure if this matters, but I only noticed the errors after I put a Biometric Protection on a barrel and registered it with an ID card. That barrel still works, but unrelated barrels placed by myself or other players don't work.
Place down a barrel and try to put any amount of items in. They do not show up as available to be withdrawn and they don't drop on the floor when the barrel is broken.
Items to be stored as normal
In error report
After destroying the barrel, the item with the hologram remains
/sf versions:
https://pastebin.com/CqwAWJ7H
@John000708 Sorry. Didn't know how to PM you. Could you look at the slimefun backpacks? They seem to be broken on github. I Think its to do with the & changes that were made.
I picked up the barrel from it's space because i wanted to upgrade it. When i broke it, i only got a wood log. And i couldn't put anything in it's space. After restarting the server, i can see the item with the name empty. When i tried to kill it with /kill @e[type=item], but the item respawned. So i couldn't do anything with it.
To get back the barrel and to put back the upgraded one.
No errors was made today.
When I use Barrels on MC 1.16, It returned me the Item with 1 empty lore.
I investigated the cause of that, When We use formatting code to no meaning in MC 1.16, the letter removed automatically.
For example, "§b§a§r§r§e§l" turns "§e§l".
That is It breaks Barrel item's LORE_DATA.
So Barrel couldn't judge item correctly, and returns a item with lore "§e§l".
Also we can't insert item to Barrel with already something in. Normal item and broken lore added item is not "similar".
Insert something to empty Barrel.
Insert items and returns me items correctly.
No Log.
> sf versions
[12:27:37 INFO]: Paper v1_16_R1
[12:27:37 INFO]:
[12:27:37 INFO]: CS-CoreLib vDEV - 88 (git 6a39a9e7)
[12:27:37 INFO]: Slimefun vDEV - 581 (git c2b0121a)
[12:27:37 INFO]: Backwards compatiblity enabled!
[12:27:37 INFO]:
[12:27:37 INFO]: Installed Addons (1)
[12:27:37 INFO]: Barrels vDEV - 11 (git abecba9)
> pl
[12:27:39 INFO]: Plugins (3): Barrels, CS-CoreLib, Slimefun
Applying either the Explosion or Biometric protection module to a barrel causes server to immediately crash (modules are applied to the barrel, however).
Place Large Barrel and apply either module to any side: observe crash.
Modules to be applied without crashing the server.
https://pastebin.com/fkhKv3qyhttps://pastebin.com/ -->
[15:19:36 INFO]: Paper v1_14_R1 (paper-628.jar)
[15:19:36 INFO]:
[15:19:36 INFO]: CS-CoreLib vDEV - 64 (git 9091bb0b)
[15:19:36 INFO]: Slimefun vDEV - 135 (git f54fd125)
[15:19:36 INFO]:
[15:19:36 INFO]: Installed Addons (8)
[15:19:36 INFO]: Barrels vDEV - 2 (git 847bc83)
[15:19:36 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[15:19:36 INFO]: ChestTerminal v1.0
[15:19:36 INFO]: HotbarPets vDEV - 10 (git 7d790905)
[15:19:36 INFO]: ExoticGarden vDEV - 17 (git 122f5555)
[15:19:36 INFO]: SoulJars vDEV - 3 (git ebabf39f)
[15:19:36 INFO]: ElectricSpawners vDEV - 2 (git 49ffa319)
[15:19:36 INFO]: ColoredEnderChests vDEV - 4 (git 2ce8ec8d)
Barrels no longer functioning in Slimefun: (still works in dev 176)
Check start up log on boot up seems to show the related issue (included in pastebin below) relevant bits probably: [10:49:55] [Server thread/WARN]: [Slimefun] Task #412 for Slimefun vDEV - 178 (git e0316453) generated an exception
java.lang.IllegalStateException: zip file closed and
at me.john000708.barrels.Barrel$1.newInstance(Barrel.java:60) ~[?:?]
Should start server without this error.
[11:12:02 INFO]: Paper v1_14_R1 (176)
[11:12:02 INFO]:
[11:12:02 INFO]: CS-CoreLib vDEV - 67 (git 1bd1883b)
[11:12:02 INFO]: Slimefun vDEV - 178 (git e0316453)
[11:12:02 INFO]:
[11:12:02 INFO]: Installed Addons (8)
[11:12:02 INFO]: Barrels vDEV - 2 (git 847bc83)
[11:12:02 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[11:12:02 INFO]: ChestTerminal v1.0
[11:12:02 INFO]: HotbarPets vDEV - 16 (git 19414e50)
[11:12:02 INFO]: ExoticGarden vDEV - 18 (git 0ad817dd)
[11:12:02 INFO]: SoulJars vDEV - 3 (git ebabf39f)
[11:12:02 INFO]: ElectricSpawners vDEV - 3 (git 937f97c0)
[11:12:02 INFO]: ColoredEnderChests vDEV - 6 (git 6e80c4ba)
please support 1.16
[14:20:35 WARN]: [Slimefun] Task #13015361 for Slimefun v4.1.2 generated an exception
java.lang.AbstractMethodError: me.john000708.barrels.Barrel$1$1.onEvent(ILorg/bukkit/inventory/ItemStack;Lorg/bukkit/inventory/ItemStack;)Lorg/bukkit/inventory/ItemStack;
at me.mrCookieSlime.Slimefun.api.inventory.BlockMenu.replaceExistingItem(BlockMenu.java:113) ~[Slimefun%20v4.1.2.jar:?]
at me.mrCookieSlime.Slimefun.api.inventory.BlockMenu.replaceExistingItem(BlockMenu.java:106) ~[Slimefun%20v4.1.2.jar:?]
at me.john000708.barrels.Barrel.pushItems(Barrel.java:452) ~[Barrels_v1.9.jar:?]
at me.john000708.barrels.Barrel.updateBarrel(Barrel.java:347) ~[Barrels_v1.9.jar:?]
at me.john000708.barrels.Barrel.access$100(Barrel.java:36) ~[Barrels_v1.9.jar:?]
at me.john000708.barrels.Barrel$3.tick(Barrel.java:191) ~[Barrels_v1.9.jar:?]
at me.mrCookieSlime.Slimefun.api.TickerTask$1.run(TickerTask.java:88) ~[Slimefun%20v4.1.2.jar:?]
at org.bukkit.craftbukkit.v1_11_R1.scheduler.CraftTask.run(CraftTask.java:58) ~[patched_1.11.2.jar:git-Paper-1057]
at org.bukkit.craftbukkit.v1_11_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:356) [patched_1.11.2.jar:git-Paper-1057]
at net.minecraft.server.v1_11_R1.MinecraftServer.D(MinecraftServer.java:820) [patched_1.11.2.jar:git-Paper-1057]
at net.minecraft.server.v1_11_R1.DedicatedServer.D(DedicatedServer.java:403) [patched_1.11.2.jar:git-Paper-1057]
at net.minecraft.server.v1_11_R1.MinecraftServer.C(MinecraftServer.java:754) [patched_1.11.2.jar:git-Paper-1057]
at net.minecraft.server.v1_11_R1.MinecraftServer.run(MinecraftServer.java:652) [patched_1.11.2.jar:git-Paper-1057]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121]
MC 1.11.2 paperclip
slimefun: 4.1.2
barrels: v1.9
I mined a block with an explosive pickaxe and a large barrel (within the explosion radius) drops a copy of all items inside but does not break. The items are still in the barrel, so the ones on the ground are duplicates. This also works with medium barrels and possibly others, but I didn't test that. It works with an unenchanted explosive pick as well as the enchanted one in the video.
The block should break as well, not just drop its items.
No errors occurred
Problem occured with slimefun version DEV 444
Versions:
https://imgur.com/a/jQRJTyq
Error generated by Slimefun: https://pastebin.com/zJdkxNuQ
Java Environment:
Operating System: Linux
Java Version: 1.8.0_242
Server Software: Paper
Build: git-Paper-84 (MC: 1.15.2)
Minecraft: 1.15.2-R0.1-SNAPSHOT
Slimefun Environment:
CS-CoreLib vDEV - 80 (git e3242c60)
Slimefun vDEV - 414 (git d37b1504)
Installed Addons (13)
Installed Plugins (71):
What essentially happens is when you right-click on the output section of the barrel itself, it will reset the barrel and throw an error in the console. Along with this, if you break the barrel, it will not drop any items other than itself and the display item, which can leave players at a risk of losing valuable items for good. Other than that, this is only tested with the DSU rather than the other barrels, with it being the largest barrel there is with the addon.
https://www.youtube.com/watch?v=oX7GLvhwkd8&feature=youtu.be
The expected behavior for this issue is that the barrel should calculate how many items are actually being taken from the barrel when right-clicking and should drop the items that were previously in there and immediately despawn the display item on breakage of the barrel.
This is the only error report that was given from within the console. You can view that here: https://pastebin.com/b1KFfFJZ
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.