johannschopplich / kirby-content-translator Goto Github PK

Thanks for the great plugin! Unfortunately it doesn't work for layout fields with type: layout.
Can you fix that?

Hi, I encounter an error when I click on the translate button. I've try on a plain kit clean install, with two languages and a simple textarea field… Sync works, but when I click translate I get an error message.

In the console tab, of the browser, a message appears when I click

index.js?1714369334:1

TypeError: Cannot read properties of undefined (reading 'text')
    at index.js?1714369334:1:2393
    at async Promise.all (:8888/deepl/panel/pages/index 0)
    at async I (index.js?1714369334:1:2982)
    at async recursiveTranslateContent (index.js?1714369334:1:2850)
    at async Object.H (index.js?1714369334:1:5466)

The message error is not very helpful, so I'm quite stuck…

Any Idea ?
Thanks

Lrt

--
Kirby 4.2.0
Php 8.1.13

When adding a custom block type via translatableBlocks that contains a blocks field itself, an error is thrown during translation.

This is my custom block called toggle.yml.

name: Toggle
fields:
  label:
    type: text
  blocks:
    type: blocks
    fieldsets:
      - heading
      - text

Adding it to my translatableBlocks will throw an error when translating. When removing the blocks field reference, the label is translated correctly and no error is thrown.

translatableBlocks:
  toggle:
  - label
  - blocks

I am getting this error, did probably the api from deepl change from 'result' to 'text' ?

The translation works, it seems that the wrong key is read from the response. Or am i missing something?

Hi Johann.

Does this plugin expose any methods for translating content programmatically? I am in the process of converting a client's site that has had only one language for several years into a multi-lingual site. There is a lot of content that needs to be translated and having a way to do it programmatically would be incredibly helpful.
Using your plugin, could I somehow iterate over a pages collection and call something like a $page->translate() function?

This would be a great addition, maybe in a way similar to the structure field.

This would be a great addition. Maybe as on opt-in config option?
I know automatically updating a page's slug isn't always optimal, but I believe many of my clients will not realize that they would need to do this manually after pressing the translate button. I have solved it with a simple page.changeTitle:after hook for now.

Hi Johann
This plugin is really fantastic. Great work! It speeds up my workflow immensely. Are there any plans to translate "nested blocks" as well? I use these very often in my projects, e.g. for FAQs or lists. If this sounds interesting, I could provide you with the necessary information and also help with testing.

Best regards
Christian

Hello,

I've noticed that it doesn't support the translation of page titles.

This is an essential feature for a multilingual site, as page titles are crucial for both SEO and providing a localized user experience. I attempted several methods, including trying different hooks and methods as suggested in the Kirby documentation, but without success.

Could this functionality be added in a future update?

Thank you for the great work on this plugin.

Best regards,
Jiri

Hi and thanks creating this plugin.

I noticed that it currently doesn't work yet with blocks who contain structure fields. For example one might define a custom block like so:

name: myblock
wysiwyg: true
preview: fields
fields:
  items:
    label: Items
    type: structure
    fields:
      title:
        label: Title
        type: text
      text:
        label: Text
        type: text

As is the plugin would not be able to translate this block. To fix that i have written a small patch for your code. The code might not be ideal yet, but it could be a starting point for you to develop an even better solution. You can see it in the linked Pull Request

With this patch one would define the translatable fields in the structure of the block as follows:

'johannschopplich.content-translator' => [
    'translatableFields' => ['blocks'],
    'translatableBlocks' => [
        'myblock' => [
            'items' => ['title', 'text']
        ],
    ],
],