johanlahti / intro-guide-js Goto Github PK

This is useful if I'm defining my elements declaratively from the elements themselves, e.g. with an angular directive. Passing an element is much easier for this.

You should throw here for immediate developer feedback. Returning false breaks the complete API, and you have no idea it's because the container is invalid.

I've tried to use it on a fixed position element and on the first child of a fixed position element.
Fixed position doesn't work at all (element is skipped?) and inside fixed position, the positioning is wrong.

When a highlighted element is partly outside the viewport, then it should be possible to scroll to see it. Atm intro-guide is hijacking the scrolling. I get some ugly jittering when trying to scroll, and I cannot actually scroll at all. Tested in FF and Chrome.

When a step descriptions is not defined, the intro renders "undefined". It should be possible to render no description.

The prev and next buttons have "touchstart" handlers applied to them, which is problematic for two reasons:

• it's not necessary as modern mobile browsers don't have a delay for click handlers
• the way the template is built causes problems when the popper doesn't change position between two steps and you are on the first step and go to the second step: touchstart is triggered, which causes the popper to update with the second step and adds a prev button. The click from the first step now hits the prev button of the second step and you are back on the first step. Repeat infinitely ...

Could you add a demo page to show the result?