Comments (3)
Isn't -1.0
implicitly cast to vec3(1.0)
anyways? I don't see it making sense if it wasn't? (what would equation otherwise be)?
I'm fine merging it in for clarity (if you make it a PR), but I don't think it's incorrect.
from learnopengl.
Actually, you're right. I changed it back to your way and things work fine. I did have a weird glitch before, and I was pretty sure it was caused by that line, but now I am unable to reproduce it. Sorry for the confusion.
from learnopengl.
Ahah no worries, always better to make sure! Good luck!
from learnopengl.
Related Issues (20)
- PBR Bloom: clarify that bloom happens due to diffraction, not scattering. HOT 3
- Website is Down HOT 6
- Model: not loading textures HOT 1
- Ad is in an annoying place HOT 10
- mismatched header files and libs causes seg fault HOT 2
- glad is no longer down HOT 1
- Segfault at introduction to textures chapter, fix attached HOT 3
- The blur effect on Mac will error
- Getting it working with Win32 (having troubles with the libraries, probably Assimp)
- Basic rendering problem HOT 1
- Camera exercise 2 comment nitpick
- Does this project only support Intel architecture and not arm64?
- Shadow Shimmering Problem
- Why can't it be rendered after loading my own obj file? HOT 1
- comment has bad grammar
- 8.guest_2020_skeletal_animation crash
- 2.lighting/2.4.basic_lighting_exercise2 /basic_lighting_exercise2.cpp Phong shading in view space
- Motivation: rewrite the codebase in Rust HOT 7
- Website having issues HOT 1
- Debugging presented last HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from learnopengl.