In the "how to use" section of the readme, I suggest you add the exact commands/steps to run your program.

Something like this:

How to use

• open terminal in the OSD600-Release0.1\BrokenLinkChecker- Release 0.1 directory
• node lab1.js test.html (or a different file)

When the user inputs "node lab1.js -v" or "--version", the app gives an error.

PS C:\Users\raymo\Documents\3yearseneca\OSD600\testingrepos\OSD600-Release0.1\BrokenLinkChecker- Release 0.1> node lab1.js -v
internal/fs/utils.js:269
    throw err;

Error: ENOENT: no such file or directory, open '-v'
    at Object.openSync (fs.js:462:3)
    at Object.readFileSync (fs.js:364:35)
    at Object.<anonymous> (C:\Users\raymo\Documents\3yearseneca\OSD600\testingrepos\OSD600-Release0.1\BrokenLinkChecker- Release 0.1\lab1.js:29:23)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47 {
  errno: -4058,
  syscall: 'open',
  code: 'ENOENT',
  path: '-v'
}

I suggest changing the arguments checker to this:

if (process.argv[2] == **"-v"** || process.argv[2] == **"--version"**) {
        console.log(packageJson.name + " Version " + packageJson.version);
    }

from what it was originally

On the issue-9 branch in index.js the function call to makeCalls is not waiting for it to resolve. MakCalls sets the value of allGood but for some reason, it's executing any code I put in the then() first.

        makeCalls().then(() => {
            console.log(allGood)
            console.log("Done");
        }).catch((err) => {
            console.log(err)
        });

Output:

When running the tool with the --ignore flag you can pass in a txt file with a list of urls. These urls will be ignored in your program!

The exact feature we are hoping to add is: Make sure that the program exits with an appropriate error code. If there are no errors (all links are good), exit with 0. Otherwise, exit with a non-zero exit code.

Hey Joey, I'd like to add more tests for your code.

--all will be the default flag (if they don't enter a flag), it will display every url.
--good only displays good url's (green)
--bad only displays bad ursl (red)

On the issue-15 branch in index,js line 61: var filtered = linkArr.filter(x => !trimmedArr.includes(x)); doesn't filter properly

I want to optimize your code to use HEAD request instead of the default fetch.

Problem

So far, makeCalls is only tested if there is actual link whether it is valid or not. However, for some reasons (Connection fail, router problem...) undefined or null value can be passed instead of link.

We should hand this error either!

Suggestion

Create a one more unit test for this. Like
test("Pass array with undefined, empty array and null to makeCalls should return empty array", ...)

I would like to add support for timeouts, DNS resolution issues, or other server errors when accessing a bad URL. A bad domain, URL, or server shouldn't crash your tool.

The node_modules folder provides unnecessary bloat to the repo and can simply be removed.

I suggest removing the node_modules folder and pushing again then adding a .gitignore (https://docs.github.com/en/github/using-git/ignoring-files) to your git in order to avoid pushing your node_modules folder.