Code Monkey home page Code Monkey logo

moremobheads's People

Contributors

dependabot[bot] avatar joelgodofwar avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

moremobheads's Issues

Mob head names are not completely configurable

Plugin list:

ArmorStandEditor, BetterConcrete, Citizens, GrimAC, JoinMessage, MoreMobHeads, Multiverse-Core, Quests, RapidLeafDecay, *SilenceMobs, SupplyDrop, VillagerWorkstationHighlights, WorldEdit, WorldGuard

Bukkit/Spigot server version or Paper build number:

git-Paper-448 (MC: 1.20.4)

grafik

When configuring head names, it is not possible to change one of the parts of the name ("head") which is attached to every head dropped. "Head" is always added to the name of the head, which is not configurable.

Console spammed with logs with debug mode turned off

My console is spammed with logs whenever I damage a mob, even when debug mode is turned off (both using the config and the command). I have not turned the debug mode on at any point.

Screenshot 2024-03-25 at 8 05 48 PM Screenshot 2024-03-25 at 8 06 17 PM

Plugin list:

ArmorStandEditor, BetterConcrete, Citizens, GrimAC, JoinMessage, MoreMobHeads, Multiverse-Core, Quests, RapidLeafDecay, *SilenceMobs, SupplyDrop, VillagerWorkstationHighlights, WorldEdit, WorldGuard

Bukkit/Spigot server version or Paper build number:

Paper-457 (MC: 1.20.4)

Paper Spigot 1.15 Startup error

Paper Spigot 1.15.1, Java 8u232 (Linux-Debian 64bit)
looks like a typo in the code with the use of "\" and "/" where not needed. the file does exist.

Startup error:

[20:02:14] [Server thread/INFO]: [MoreMobHeads] Enabling MoreMobHeads v1.14_1.0.0
[20:02:14] [Server thread/INFO]: [MoreMobHeads] plugins/MoreMobHeads/config.yml
[20:02:14] [Server thread/WARN]: java.io.FileNotFoundException: plugins/MoreMobHeads\lang\/en_US.yml (No such file or directory)
[20:02:14] [Server thread/WARN]: 	at java.io.FileInputStream.open0(Native Method)
[20:02:14] [Server thread/WARN]: 	at java.io.FileInputStream.open(FileInputStream.java:195)
[20:02:14] [Server thread/WARN]: 	at java.io.FileInputStream.<init>(FileInputStream.java:138)
[20:02:14] [Server thread/WARN]: 	at org.bukkit.configuration.file.FileConfiguration.load(FileConfiguration.java:126)
[20:02:14] [Server thread/WARN]: 	at com.github.joelgodofwar.mmh.MoreMobHeads.onEnable(MoreMobHeads.java:98)
[20:02:14] [Server thread/WARN]: 	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263)
[20:02:14] [Server thread/WARN]: 	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:338)
[20:02:14] [Server thread/WARN]: 	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:420)
[20:02:14] [Server thread/WARN]: 	at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugin(CraftServer.java:468)
[20:02:14] [Server thread/WARN]: 	at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugins(CraftServer.java:382)
[20:02:14] [Server thread/WARN]: 	at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:481)
[20:02:14] [Server thread/WARN]: 	at net.minecraft.server.v1_15_R1.DedicatedServer.init(DedicatedServer.java:290)
[20:02:14] [Server thread/WARN]: 	at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:884)
[20:02:14] [Server thread/WARN]: 	at java.lang.Thread.run(Thread.java:748)
[20:02:14] [Server thread/INFO]: �[33m**************************************�[0m
[20:02:14] [Server thread/INFO]: �[32mMoreMobHeads v1.14_1.0.0�[0m is Enabled
[20:02:14] [Server thread/INFO]: �[33m**************************************�[0m

testing webhook

Before submitting an issue, please use the command "/mmh td" to turn on debug mode, and attach a log with the debug info.

Plugin list:

A list of your plugins

Bukkit/Spigot server version or Paper build number:

This can be found by running /version on your server. latest is not a proper version number; we require the output of /version so we can properly track down the issue.

Submit issue on Discord:

https://discord.gg/Fq9HQ2dmtd

Issues submitted here will be closed with a comment pointing to the discord server.

Please fix the code [explanation in content]

There's so many things wrong.

Why are you doing network requests on main thread? Why do you do them for each player join - even if the check is disabled and player is not op?

Why do you need to know the version of plugin on my server and my seed?

I'd love to use this plugin - but it is a big performance and potentially security issue rn, and I'd prefer not to rewrite it myself.

Error on EntityDeathEvent

Hi, I try to kill a mob, in particular the Glow Squid:

VERSION:
( -<[ PLEASE INCLUDE THIS WITH ANY ISSUE REPORTS ]>-
) This server is running Paper version git-Paper-364 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT)
( vardebug=false debug=false in plugins\MoreMobHeads\config.yml
) jarfilename=\MoreMobHeads-1.15_1.0.33.jar
( -<[ PLEASE INCLUDE THIS WITH ANY ISSUE REPORTS ]>-

ERROR:
[15:23:28 ERROR]: Could not pass event EntityDeathEvent to MoreMobHeads v1.15_1.0.33
java.lang.NoClassDefFoundError: Could not initialize class com.github.joelgodofwar.mmh.MoreMobHeadsLib
at com.github.joelgodofwar.mmh.handlers.EventHandler_1_20_R1.onEntityDeathEvent(EventHandler_1_20_R1.java:1677) ~[MoreMobHeads-1.15_1.0.33.jar:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor481.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:81) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:git-Paper-364]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.20.4.jar:git-Paper-364]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[paper-1.20.4.jar:git-Paper-364]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:615) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.v1_20_R3.event.CraftEventFactory.callEntityDeathEvent(CraftEventFactory.java:959) ~[paper-1.20.4.jar:git-Paper-364]
at net.minecraft.world.entity.LivingEntity.dropAllDeathLoot(LivingEntity.java:1836) ~[?:?]
at net.minecraft.world.entity.LivingEntity.die(LivingEntity.java:1730) ~[?:?]
at net.minecraft.world.entity.LivingEntity.hurt(LivingEntity.java:1555) ~[?:?]
at net.minecraft.world.entity.animal.Squid.hurt(Squid.java:167) ~[?:?]
at net.minecraft.world.entity.GlowSquid.hurt(GlowSquid.java:82) ~[paper-1.20.4.jar:git-Paper-364]
at net.minecraft.world.entity.player.Player.attack(Player.java:1321) ~[?:?]
at net.minecraft.server.level.ServerPlayer.attack(ServerPlayer.java:2283) ~[?:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl$3.a(ServerGamePacketListenerImpl.java:2787) ~[?:?]
at net.minecraft.network.protocol.game.ServerboundInteractPacket$1.dispatch(ServerboundInteractPacket.java:24) ~[?:?]
at net.minecraft.network.protocol.game.ServerboundInteractPacket.dispatch(ServerboundInteractPacket.java:80) ~[?:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl.handleInteract(ServerGamePacketListenerImpl.java:2711) ~[?:?]
at com.andavin.images.v1_20_R3.PlayerConnectionProxy.a(PlayerConnectionProxy.java:74) ~[images-2.3.2.jar:?]
at net.minecraft.network.protocol.game.ServerboundInteractPacket.handle(ServerboundInteractPacket.java:67) ~[?:?]
at net.minecraft.network.protocol.game.ServerboundInteractPacket.handle(ServerboundInteractPacket.java:12) ~[?:?]
at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:54) ~[?:?]
at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.20.4.jar:git-Paper-364]
at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?]
at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1458) ~[paper-1.20.4.jar:git-Paper-364]
at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:194) ~[paper-1.20.4.jar:git-Paper-364]
at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?]
at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1435) ~[paper-1.20.4.jar:git-Paper-364]
at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1358) ~[paper-1.20.4.jar:git-Paper-364]
at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?]
at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1336) ~[paper-1.20.4.jar:git-Paper-364]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1220) ~[paper-1.20.4.jar:git-Paper-364]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:321) ~[paper-1.20.4.jar:git-Paper-364]
at java.lang.Thread.run(Thread.java:833) ~[?:?]

image

DEBUG MODE:
image

Frequent Internal Errors

What behaviour is expected:

The plugin starts up after putting the .jar file in the plugins folder.

What behaviour is observed:

Stack Trace:
java.nio.file.NoSuchFileException: plugins/MoreMobHeads/messages.yml
-> -> -> -> -> -> -> -> This line <- <- <- <- <- <- <- <-
[18:33:23 ERROR]: [MoreMobHeads] INTERNAL ERROR: Could not load old_messages.yml
java.io.FileNotFoundException: plugins/MoreMobHeads/old_messages.yml (No such file or directory)
[18:33:23 ERROR]: Error occurred while enabling MoreMobHeads v1.20_1.0.34 (Is it up to date?)
[18:33:23 INFO]: [MoreMobHeads] Disabling MoreMobHeads v1.20_1.0.34
[18:33:23 INFO]: [MoreMobHeads] MoreMobHeads v1.20_1.0.34 is Disabled

Steps/models to reproduce:

Remove the MoreMobHeads folder if it exists.
Put MoreMobHeads v1.20_1.0.34 in the plugins folder
Restart the server
The plugin doesn't startup

Then you might manually create an empty text file called "old_messages.yml" and the plugin does start.

Plugin list:

ArmorStandEditor, BetterConcrete, Citizens, MoreMobHeads, Multiverse-Core, Quests, RapidLeafDecay, *SilenceMobs, VillagerWorkstationHighlights, WorldEdit

Bukkit/Spigot server version or Paper build number:

This server is running Paper version git-Paper-416 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 581fb30)

Anything else:

I would like to add that this plugin does not handle any errors or unexpected commands very well at all. For example, writing /mmh display throws an Internal Error. I don't think a well-coded program should behave like that. It's an issue of not catching errors and instead just defaulting to not handling them at all. I would appreciate just a tiny bit more testing and stability before putting out production versions.
The server operators also cannot use many commands by default, for example /mmh customtrader due to "missing permissions"... but I am the OP. I should have all the permissions by default.

Exception when picking up blockhead and wrong name after placing

Got a stack of "Dried Kelp Block" from the wandering trader, placed and broke it.
The block now is no longer named "Dried Kelp Block" and when picking it up, an exception is fired.
I use Paper v298, no other plugins and the MoreMobHeads config.yml is untouched.
Log:
[10:52:58 INFO]: MoreMobHeads 1.14_1.0.11 [DEBUG] EPIE isPlayerEPIE=true
[10:52:58 INFO]: MoreMobHeads 1.14_1.0.11 [DEBUG] EPIE item.length=11
[10:52:58 INFO]: MoreMobHeads 1.14_1.0.11 [DEBUG] EPIE name=eyJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvYjgwNWNhZjNkMDJlMzVlNGFhZGMxOWFmMTVlODI3OTAxNzdmMWNkN2I3OWY0ZjViODhkOTQzYWM2YmUyMDNhMSJ9fX0=
[10:52:58 INFO]: MoreMobHeads 1.14_1.0.11 [DEBUG] EPIE lore=null
[10:52:58 INFO]: MoreMobHeads 1.14_1.0.11 [DEBUG] EPIE ownerName.lngth >= 40
[10:52:58 INFO]: MoreMobHeads 1.14_1.0.11 [DEBUG] EPIE mobname from texture=null
[10:52:58 ERROR]: Could not pass event EntityPickupItemEvent to MoreMobHeads v1.14_1.0.11
java.lang.NullPointerException: null
at com.github.joelgodofwar.mmh.MoreMobHeads.OnTake(MoreMobHeads.java:1407) ~[?:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor3.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.15.2.jar:git-Paper-298]
at org.bukkit.plugin.EventExecutor$$Lambda$2533/1278786085.execute(Unknown Source) ~[?:?]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.15.2.jar:git-Paper-298]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.15.2.jar:git-Paper-298]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:607) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.EntityItem.pickup(EntityItem.java:371) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.EntityHuman.c(EntityHuman.java:492) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.EntityHuman.movementTick(EntityHuman.java:465) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.EntityLiving.tick(EntityLiving.java:2396) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.EntityHuman.tick(EntityHuman.java:165) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.EntityPlayer.playerTick(EntityPlayer.java:442) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.PlayerConnection.tick(PlayerConnection.java:159) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.NetworkManager.a(NetworkManager.java:343) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.ServerConnection.c(ServerConnection.java:140) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.MinecraftServer.b(MinecraftServer.java:1344) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.DedicatedServer.b(DedicatedServer.java:430) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:1173) ~[patched_1.15.2.jar:git-Paper-298]
at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:962) ~[patched_1.15.2.jar:git-Paper-298]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51]

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.