jocker-il / jkil-knightrider Goto Github PK

Do I want to add flouting startup lights ?

Power (yellow)
fuel on (yellow)
Min RPM (yellow)
Ignitors (red)

Ideas for effects:

• * Voice greeting michael
• * Flouting startup lights
  • engine on (Red)
  • turbo mode (Green)

Use the on player "enters car" event ?:

on_player_driving_changed_state

Called when the player's driving state has changed, this means a player has either entered or left a vehicle.

Contains

• player_index :: uint,

• entity :: LuaEntity (optional): The vehicle if any.

Should I make the sound track a setting ?

• if I do - wouldn't that change the mod ?
• if I don't - would that effect anything ?

I'd like to hear from the community,

Hauvega reports:

Got killed by some bugs while in the vehicle.
1247.542 Error MainLoop.cpp:1195: Exception at tick 5017484: The mod JKIL's KnightRider music while driving caused a non-recoverable error.
Please report this error to the mod author.
Error while running event JKIL-KnightRider::on_player_driving_changed_state (ID 26)
JKIL-KnightRider/control.lua:5: attempt to index field 'entity' (a nil value)
stack traceback:
JKIL-KnightRider/control.lua:5: in function <JKIL-KnightRider/control.lua:3>

I suspect is because of indexing entity before checking if there is one. It's with one of these lines:

local first_player = game.players[event.player_index]
local vehicle = event.entity.type

Might need swapping the second line with the if- then sentence

Default game music does not mute when entering a vehicle on 0.19.4.

Now that my friends and I are doing a new long run on Factorio-1.1, we are trying to reacquire some mods we used before. Would you be so kind as to bump the version please?

Make a settings file and make the volume a setting - should be fairly easy

The mod causes an exception when using the Aircraft mod. when the aircraft is destroyed due to biters, the following error is received:

The mod JKIL's KnightRider music while driving caused a non-recoverable error.
Please report this error to the mod author.

Error while running event JKIL-KnightRider::on_player_driving_changed_state (ID 26)
JKIL-KnightRider/control.lua:5: attempt to index field 'entity' (a nil value)
stack traceback:
JKIL-KnightRider/control.lua:5: in function <JKIL-KnightRider/control.lua:3>

Add a larger variety of driving tracks from the show that rotate with every ride - I have the tracks but need to add the code to rotate them every time the player enters the car.