jobtoday / react-native-image-viewing Goto Github PK

Can we have supportedOrientations for both 'portrait' and 'landscape'?

I ran some tests with supportedOrientations={['portrait', 'landscape']} on the Modal component but I couldn't manage to make the component to rerender after the the orientation was changed.

Thank you.

If you have swipe to dismiss enabled with pinch to zoom, they interfere with each other and creates a weird experience. Can't really zoom and very janky. I am using a pixel 2. Then you have that issue with image zoomed to max after zooming once and only gets cleared after swiping to other images a few times.

Hi, would it be possible for the library to expose the cache prop of Image, so it's configurable?
Being able to set it to 'force-cache' when loading large images will be very helpful.
Thank you!

Description

When I zooming the image and sliding it by mistake the component distorting!
Can you add props like disableZoomAndPanch until you fix this problem?

Example

Versions

"expo": "~37.0.3"
"react-native": "~0.61.5"
"react-native-image-viewing": "^0.2.0"

Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.

Issue Video

Findings :

The onRequestClose handler associated with the device's back button press is not aborting after the component gets unmounted and navigated to a new page

The modal close button disappears when zooming, and I can't seem to dismiss the modal unless I reset the zoom to the original size.

Is there a way to keep the X button always visible while zooming?

I want custom 2 button next and prev image in lib. How to custom?
I tried setState imageIndex, but i have problem image hide and show immediately

I want to display a list of authorized images with bearer token.
The component works perfectly on Android but it keeps showing loading indicator with black background on iOS. Btw, local images work well.
Anyone faces the same issue? Please help me. Thank you.

Hey guys! I'm facing an issue on Android where the modal with the image is not covering all the screen and it's only showing a small part of the image. On iOS is working very well 👍

react: 16.8.3
react-native: 0.61.5
react-native-image-viewing: 0.1.3

Another useful information is that I'm using Expo SDK v35.0.0.

Can you please tell me what can I do to fix this?

Thank you!

I need to know which image is currently showing on the screen.

Is that possible if I just let the user scroll?

As far as I can tell I need to manually update the currentIndex value, but I have no way of knowing when or where the user has scrolled to.

As stated in title, when used inside of StackNavigator and Modal is opened for the first time, react-navigation BackHandler is not working anymore.

Need Support for Device Rotate Orientations

Images does not show in full screen when the device is rotated.

Hello, I finally found the solution for Carousel with pinchable gesture.

I can’t wait to test it but first I would like to try the demo on Expo. It doesn’t seem to work

When using the require tag to load images, image viewer breaks

Please tell me when to add the zoom function on Android. Can you add function long press picture double click restore picture scale double click enlarge picture scale

Hi,

I just tried react-native-image-viewing. It work very well. Also performance is awesome. But I have problem for android. IOS doesn't have that problem. It work well. Problem is that Modal doesn't bring to front.Like below screenshot:

How can I solve?

When i add the header component it hides the close button

Is it possible to get access to something around swiping, for example a method called when starting or ending the swipe, or even just a prop like isSwiping?

I have added this component into a scrollview, and am getting weird behaviour between swiping photos, when you swipe at a slightly wrong angle, you suddenly also can do a pull to refresh. So my idea was to disable to refresh control while the images are being swiped, and so any function that gets called telling me the images are being swiped will help to solve this issue

When making a request to download an image that requires authentication, it would be nice to be able to provide additional authentication headers so the request can be successfully processed..

Latest release caused this in bundler. Reverting to 0.1.3 fixed the issue immediately.
While trying to resolve module react-native-image-viewing from file /Users/.../src/screens/image-list/ImageDetailsPickerScreen.tsx, the package /Users/.../node_modules/react-native-image-viewing/package.json was successfully found. However, this package itself specifies a main module field that could not be resolved (/Users/.../node_modules/react-native-image-viewing/dist/index.js. Indeed, none of these files exist:

It would be nice if we could send both as prop, such as:

<ImageView
    imageIndex={0}
    minimumZoomScale={0.5}
    maximumZoomScale={4}
    images={imagesList}
    visible={isVisible}
    onRequestClose={close}
/>

maximumZoomScale could default to 2 and minimumZoomScale to 1.

I am trying to disable pinch-to-zoom and only use double tap to zoom functionality. Is it possible to do? I tried editing library files but had no luck.

Thanks for great library btw.

Not able to Add testID for <ImageView>

Is there a way to test, if this Screen is opened or not and also with the correct image uri?

The images in the slideshow appears to be darker.

The duplicated key warning will show when uri duplicated

I'm using animationType={"slide"} and presentationStyle={"pageSheet"} combined, when these 2 are enabled, the onRequestClose function is not called, making it impossible to open the slider view again from the same screen.

Is it possible that in the future there would be a feature for supporting custom image component?

swipeToCloseEnabled | Close modal with swipe up or down: default true

Swipe up is working fine, but it's not with swipe down

v0.2.0
RN: v0.62.2

If the imageIndex changed when being visible, the component will flicker.
It looks like it's caused by the key change by this line.
I am wondering why the key is needed.

Hi all,

We were using this module on iOS 13 devices and now, after updating to iOS 14, we noticed that the images show in black.
Any clue why this might be happening?

Sometimes the Index of the currently viewed image is deprecated.

In the FooterComponent, I have TouchOpacity component and i can not onPress in TouchOpacity
Thanks for great library.

Hello guys, I am trying to use that dependency in my project but images .webp on iOS doens't work.
So I tried to figure out and unfortunately the function:
Image.getSizeWithHeaders(source.uri, source.headers, (width, height) => { imageDimensionsCache.set(cacheKey, { width, height }); resolve({ width, height }); }, () => { resolve({ width: 0, height: 0 }); }); }

on dist/hooks/useImageDimensions.js:38 return
undefined/null or even 0;

I don’t know how can I help and if only happens on my project.
Can someone give me an idea ?

Note: I really need zoom in and out on .webp images.

I there a way we can custom the icon and font size ?

images shows incorrectly in landscape mode

Feature request

It would be nice if we could pass an array of base64's straight into the 'images' prop.

Anything I could do to help?

My ios app only works in landscape mode. I get the error:

console.error: "Modal was presented with 0x2 orientations mask but the application only supports 0x18.Add more interface orientations to your app's Info.plist to fix this.Note: This will crash in non-dev mode."

This error is located at:
in RCTView (at View.js:34)
in View (at SafeAreaView.js:41)
in ForwardRef(SafeAreaView) (at App.js:35)
in App (at renderApplication.js:45)
in RCTView (at View.js:34)
in View (at AppContainer.js:106)
in RCTView (at View.js:34)
in View (at AppContainer.js:132)
in AppContainer (at renderApplication.js:39)
[Tue Aug 11 2020 21:27:52.462] ERROR Error: Text strings must be rendered within a component.

Need the image name for display

First of all. Thank you for the nice viewer.

In RTL the image is cut off. And not showing completely.
Is there any workaround or fix for this.

Thank you.

When swiping up to close the the preview, if not sliding all the way to the top, the image disappears from the screen but the preview stays open.

Hi i like your Image viewer!

but i just recognized an Issue:

When i open the Viewer and zoom in and out an Image, go back and forth in the gallery and come back to the previously zoomed in image its zoomed to the max without any gestures.

Found this issue on Android OnePlus 6T

Pinch to zoom feature is not working for me, tested on Android.

I need an image viewer that is capable of displaying videos and images, but can't manage to do it here.

thanks for your support

First problem is when you add ImageView component, it will prevent back button as shown on this video below
https://share.icloud.com/photos/0R3_N2HJN2wXlqc9v2itD2rQg

Second probelm is presentationStyle="overFullScreen" only fill parent as shown on this video below
https://share.icloud.com/photos/0Eim16y5lpvDFJXDaeQHyVxpA