Code Monkey home page Code Monkey logo

benny-hanes-socket-pool's People

Contributors

arb avatar jmonster avatar mikestoltz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

benny-hanes-socket-pool's Issues

npm run jshint

npm run jshint
> [email protected] jshint /Users/jmonster/Desktop/benny-hanes-socket-pool
> jshint .

coverage/lcov-report/prettify.js: line 1, col 2642, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 2752, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 2852, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 2898, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 2959, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3023, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3052, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3123, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3209, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3219, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3526, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3602, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3613, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3720, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3793, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3855, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3895, 'ar' is already defined.
coverage/lcov-report/prettify.js: line 1, col 3977, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 3997, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 4031, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 4063, 'ar' is already defined.
coverage/lcov-report/prettify.js: line 1, col 4091, 'at' is already defined.
coverage/lcov-report/prettify.js: line 1, col 4107, Missing 'new' prefix when invoking a constructor.
coverage/lcov-report/prettify.js: line 1, col 4163, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 4172, Missing 'new' prefix when invoking a constructor.
coverage/lcov-report/prettify.js: line 1, col 4181, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 4214, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 4514, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 4592, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 4606, 'ak' is already defined.
coverage/lcov-report/prettify.js: line 1, col 4655, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 4667, 'ak' is already defined.
coverage/lcov-report/prettify.js: line 1, col 4672, 'am' is already defined.
coverage/lcov-report/prettify.js: line 1, col 4693, 'ag' is already defined.
coverage/lcov-report/prettify.js: line 1, col 4754, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 4791, 'af' is already defined.
coverage/lcov-report/prettify.js: line 1, col 4842, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 4856, 'ak' is already defined.
coverage/lcov-report/prettify.js: line 1, col 4861, 'am' is already defined.
coverage/lcov-report/prettify.js: line 1, col 4918, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 4951, 'ak' is already defined.
coverage/lcov-report/prettify.js: line 1, col 4972, 'ag' is already defined.
coverage/lcov-report/prettify.js: line 1, col 5034, Missing 'new' prefix when invoking a constructor.
coverage/lcov-report/prettify.js: line 1, col 5039, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 5173, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 5174, Don't make functions within a loop.
coverage/lcov-report/prettify.js: line 1, col 5175, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 5197, Missing semicolon.
coverage/lcov-report/prettify.js: line 1, col 5217, 'V' is already defined.
coverage/lcov-report/prettify.js: line 1, col 5221, 'U' is already defined.
coverage/lcov-report/prettify.js: line 1, col 5221, Too many errors. (50% scanned).

51 errors

npm ERR! [email protected] jshint: `jshint .`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] jshint script.
npm ERR! This is most likely a problem with the benny-hanes-socket-pool package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     jshint .
npm ERR! You can get their info via:
npm ERR!     npm owner ls benny-hanes-socket-pool
npm ERR! There is likely additional logging output above.
npm ERR! System Darwin 13.3.0
npm ERR! command "node" "/usr/local/bin/npm" "run" "jshint"
npm ERR! cwd /Users/jmonster/Desktop/benny-hanes-socket-pool
npm ERR! node -v v0.10.29
npm ERR! npm -v 2.0.0-alpha-5
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/jmonster/Desktop/benny-hanes-socket-pool/npm-debug.log
npm ERR! not ok code 0

Custom agent socket maximums remain unaffected.

require('benny-hanes-socket-pool');
var http = require('http');
var Agent = http.Agent;

console.log(new Agent().maxSockets); // still '5'

Looks like benny-hanes-socket-pool doesn't affect the behavior of the default Agent constructor for both http and https modules. I'd like for all of my sandboxed agents to have unlimited sockets by default. This is crucial for performance of web-scale cloud SaaS solutions.

@jmonster

This is no longer required for Node.JS™ 0.12

Since Node.JS™ version 0.12-stable, the following change has been introduced:

HTTP
maxSockets are no longer limited to 5. The default is now set to Infinity with the developer and the operating system given control over how many simultaneous connections an application can keep open to a given host.

This module users should know about this. I suggest a deprecation warning.

Add license

Can you please add license terms to LICENSE or README.md?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.