angular-best-practices's People
Forkers
rzebec vajura boy18nj thyroof eliasib13 lexm mukesh23singh boriphuth calvimor rahulmisra2000 jitendrakrtiwari anand-ma saresamadou etrivinos developeramarish jacobbp25 arvindchourasiya deepakdps trongbinh15 ddotx burakiskender toreaurstadboss jamesbright md-web-client bmanley91 hasithaalex monelseza davrivas udaykumarburgula dattachandan studygcs susanmathew314 itpreneur davidc05 francoqueirolo yanan5 sruthigithub simondi vijayaraju amit6882 merulappan zuptalo connells102 ericsomervilleadfg sss-software phypher sushmitajoshi510 rzulfekar sekhmetdesign maciejdybal beinto yogesh1140 laurenb07 neeraj07rathi inat-training corbpm nahaley revealer409 adamkhairi amineketfi mtimmins verocardenas carolkuch tantrumlance purnachand99 mousesaver yoneshinzato pedromdandre sophie-eihposangular-best-practices's Issues
type any
I noticed you used any as a type all over the project. Is not good practice to use type any
params without specifying type
enroll(classId): Observable<any> {
if (!this.currentUser)
return Observable.throw('User not signed in');
if (this.currentUser.classes.includes[classId])
return Observable.throw('Already enrolled');
this.currentUser.classes.push(classId);
return Observable.empty().delay(1000);
}
I noticed in several parts of you code you don't specify the param type. for example in the code above classId should be string or number
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.