jmariondev / name-game Goto Github PK

The capitalization of the input is currently an issue, as demonstrated in the following cases:

"MARSHA": "MARSHA, MARSHA bo bARSHA"
"MaRsHa": "MaRsHa, MaRsHa bo baRsHa"
"Erin": "Erin, Erin bo bErin"

I believe the easiest way to fix this is to override the capitalization of the input, and normalize it to Ccccc (where 'c' is a character). The only issue I see with this is names that legitimately have capitals within them, though this is a small enough use-case that I don't think it's worth making an exception for.

Names beginning with vowels become nonsensical when truncated (ie "Erin" becomes "brin").

Deviating from the initial specification is probably a good choice in this case because the song itself does this in its own lyrics.

A potential fix is to just not truncate the first letter of the name if it's a vowel.

Because of my argv[i]+1 sub-string method, arguments of 1-character have empty-string as the trimmed name, causing nothing to print in the place of the trimmed name in the output.

This can just be fixed by ensuring that the argv[i]+1 is not a null-byte for each name, probably printing a warning and skipping that argument.