jmank88 / ubjson Goto Github PK

Currently int is returned. Does that make the method unusable for machines where int < 64bits?

Support basic json struct tags, and any relevant options (e.g. omitempty).

Consider an option for alternate type encoding (e.g. tag a byte with 'C', rather than use a Char type).

Keep an eye on the benchmarks - consider caching struct type info on the first run (fields, tags, counts, etc).

A command line program to generate Value code for structs (tagged or not) would offer some benefits:

• Simpler and less error prone than writing by hand (even if only 'as good', or used as a starting point for hand edits)
• Container optimization without sacrificing runtime speed (static field mappings, counts, strong types, arrays, ordered fields)

The simplest form might look like ubjsonvalue -type=CustomValue, and be called on demand or from go:generate.

Add some fuzz testing

@jmank88 I was wondering what your thoughts were on fields that are in the UBJSON object but not declared in the Go struct.
Currently, I see the error: unable to decode entry: no field found named/tagged ...
When I do the same test using encoding/json, the 'unknown' JSON field is consumed and discarded.

A use case is to implement forward compatibility with UBJSON messages.
I can add a failing test if you'd like.

https://github.com/jmank88/ubjson/blob/master/encode.go#L531