jloh / geojs Goto Github PK

https://metacpan.org/pod/TAP::Formatter::JUnit

Should give us nicer Circle CI test results

At the moment there aren't any tests for the /geojs help command

The API for webhooks in HipChat allows you to send a from field in the payload.

https://www.hipchat.com/docs/apiv2/method/send_room_notification

Type	Property	Description
STRING	from	
A label to be shown in addition to the sender's name

Valid length range: 0 - 64.

Could be a nicer way of doing tests? As opposed to doing all the string magic write a function that ensures two tables match and check that way.

The slack endpoint currently doesn't have any fallback text. This is very poor form and goes against their standards!

Finish off unit tests for Geo endpoint

This is going to be a bit difficult since the JSON that gets returned can change the order its in for some reason which is breaking string comparisons.

To reproduce, try and lookup a domain via /geojs <domain in here> and see the last PTR being sent back along with failure to lookup anything else.

Hello,

Someone was complaining about a network I maintain, and said that my network is bad. However we found the application was depending on the following:

root@obproxy:~# wget -SHO - https://get.geojs.io/v1/ip/geo.json
--2023-01-08 15:59:37--  https://get.geojs.io/v1/ip/geo.json
Resolving get.geojs.io (get.geojs.io)... 2606:4700:20::681a:64, 2606:4700:20::681a:164, 2606:4700:20::ac43:46e9, ...
Connecting to get.geojs.io (get.geojs.io)|2606:4700:20::681a:64|:443... connected.
HTTP request sent, awaiting response...
  HTTP/1.1 500 Internal Server Error
  Date: Sun, 08 Jan 2023 15:59:38 GMT
  Content-Type: text/html; charset=utf-8
  Transfer-Encoding: chunked
  Connection: keep-alive
  x-request-id: f4ffd7e64972ea270b7f89f527228b92-AMS
  strict-transport-security: max-age=15552000; includeSubDomains; preload
  access-control-allow-origin: *
  access-control-allow-methods: GET
  pragma: no-cache
  Cache-Control: no-store, no-cache, must-revalidate, private, max-age=0
  x-geojs-location: AMS
  CF-Cache-Status: DYNAMIC
  Report-To: {"endpoints":[{"url":"https:\\/\\/a.nel.cloudflare.com\\/report\\/v3?s=yBx8lTgrKvBcwNOrOJa8Dyr9P49F7WBpMu34EOAELjcKk7pomCyk%2B96oL%2F%2BCv21%2FAF6LQnoHLKJ6eQxjsVQYdCc9e1YW0vXFYhIWsNrBn6%2BqS8Y9RW45HF6%2BPOR1QAUK0Zl%2F1Sd63Yniqg%3D%3D"}],"group":"cf-nel","max_age":604800}
  NEL: {"success_fraction":0,"report_to":"cf-nel","max_age":604800}
  X-Content-Type-Options: nosniff
  Server: cloudflare
  CF-RAY: 78662438fb850eaf-AMS
  alt-svc: h3=":443"; ma=86400, h3-29=":443"; ma=86400
2023-01-08 15:59:39 ERROR 500: Internal Server Error.

Since the 500 means that cloudflare received an error from the application I assume the application breaks for certain source ip's.

I would love to tell you the source ip/range, but I'd rather not invite an army of port scanners on that network.
I assume the 500 would be traceable in the logs.

Thank you for looking at it.
In the mean time I hope we can ask the software provider to make that request optional.

Weird, https://status.geojs.io/ says 100% up
but
https://get.geojs.io/
https://www.geojs.io/docs/v1/endpoints/geo/
https://www.geojs.io/

etc are 100% down right now

I access it from Sweden, tried both v4/6

Probably because dig shows:

dig get.geojs.io @8.8.8.8

; <<>> DiG 9.10.6 <<>> get.geojs.io @8.8.8.8
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 25799
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;get.geojs.io.			IN	A

;; ANSWER SECTION:
get.geojs.io.		2994	IN	A	0.0.0.0

Is this some kind of DoS protection? 😦

Now status just went off-line.....

dig status.geojs.io @8.8.8.8

; <<>> DiG 9.10.6 <<>> status.geojs.io @8.8.8.8
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 17021
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;status.geojs.io.		IN	A

;; ANSWER SECTION:
status.geojs.io.	3435	IN	A	0.0.0.0

Finish off unit tests for Country endpoint

This is going to be a bit difficult since the JSON that gets returned can change the order its in for some reason which is breaking string comparisons.

Scripts are always blocked by ad blocking plugins. Whether to consider changing the name(https://get.geojs.io/v1/ip/geo.js), or users can self-hosted it?

Need unit tests for the whole app!

The Slack endpoint doesn't currently follow the Slack style guide. Specifically, the attachment currently has its header outside the attachment which is a no-go.

The below should be changed to just title instead of pretext.

This will also need to be updated

Just a placeholder issue so I don't forget. When I increase the tests for util I should make sure they run first

It’d be great if GeoJS had a currency endpoint that returned what currency the users current country used.

Finish of travis CI config and add unit tests!

There currently aren't tests for specific IP lookups.

GeoLite2 is being deprecated which is what GeoJS relies upon. Migrating isn't going to be as hard as I originally thought.

Going to use the anjia0532/lua-resty-maxminddb library which should give us most of the functionality.

TODO:

• Find a way to still provide ASN data
• Implement v2 of the API

It seems geojs does currently not support IPv6. Is this something that could be added?

Should make one! https://github.com/yangm97/lua-telegram-bot-api looks perfect.

This causes errors already reported in #14 amongst other things. The endpoints should return valid errors when the input is not an IP (or otherwise expected)

If you try and hit something like this:

/v1/ip/geo.json?ip=162.253.128.178, 64.252.74.175

GeoJS ends up throwing a 500. Really it should just throw a 400 or ideally we should just chomp up the space and return proper data.

Likely something to do on the SaaS portion of GeoJS but returning the Server-Timings header could be handy to show how fast it is!

https://ma.ttias.be/server-timings-chrome-devtools/

Niceties:

• When requesting endpoints where third-party content is required (DNS queries etc) it'd be great to show that

Several of the Variables used in the GeoJS code base are not scoped to be local which can lead to race conditions. Everything should be scoped locally where possible.

This is going to be a bit harder since we'll have to do POST requests and fake our auth token

Hi team!
This is such a great API!
I am happy to use it :D

However, I found an error about fetching data from IP: 78.47.78.165. This IP should belong to "Germany", but the API returns "US"

https://app.geojs.io/s/78.47.78.165
https://ipgeolocation.io/browse/ip/78.47.78.165

Highly appreciate if you can fix this issue! Thank you!

Finish unit tests for DNS endpoint.

It seems like this endpoint: https://ipv6.geojs.io/v1/ip is not working anymore?

Did something changed? If so how to just get the ipv6 version of the client'ip ?

Hi Jloh, and thanks for building this! It really does make the forms on our website so much more user friendly.

For digital marketing purposes, we're looking for a list of all the pretty names that the country API returns. Do you know where could we find such a list?

At the moment some character chars aren't printed correctly due to UTF8 coding or something I assume.

eg https://app.geojs.io/s/46.30.213.77