jklemon17 / microverse-tic-tac-toe Goto Github PK

Great work guys! I ran the game on my machine and played abit, the logic is Ok. I have some suggestions on how we can improve a couple of things:

1. Style guide, style guide, style guide! Rubocop is your friend 😉.

2. I think we can improve the project README file, to allow people looking at this understand how to:

   • Install the game
   • Play the game
   • Run the game

3. We need to split the code into its constituent parts and not have everything in one codefile. For instance, give each class its own file and require it where it is needed.

4. We can use the recommended project structure as follows:
   a. Put all the classes that have noting to do with running the game in a lib folder.
   b. Put all the classes that run the game in a bin folder

5. Right now, I have to run this command to run the game ruby tic-tac-toe.rb. I think we can make it easier for users to run the game by making tic-tac-toe.rb executable. Here is a good guide on how to achieve this.

6. I feel this method should return a boolean. And be named something along the lines of game_over?. Reason is, its easier to read game.game_over? than game.game_over == 'win'

We can work on these for now, then do another review later. Thoughts?