jkk / shinkgs Goto Github PK

Requires hoisting up state of which game node you're actually viewing, rather than just the "active" node. This is necessary to move the nav bar outside of BoardContainer, too.

Need to hoist clock state up somewhere

We could do this easily, but joining them depends on #11

https://groups.google.com/forum/#!topic/kgs-client-coding/Yhs3ZCDlZdI

https://groups.google.com/forum/?pli=1#!topic/kgs-client-coding/d2-B-cvF9F0

• Ability to save permanently

Waiting on KGS API to support it

Regular game example:

Type: ranked
Timestamp: 2017-04-01T14:25:45.371Z
Revision: none
White: Dom
Black: Amore
URL: http://files.gokgs.com/games/2017/4/1/Dom-Amore.sgf

Review example:

Type: review
Timestamp: 2017-04-01T14:29:28.814Z
Revision: 6
White: Dom
Black: Amore
URL: http://files.gokgs.com/games/2017/4/1/Dom-7.sgf

Might need to clarify with KGS team that only white name is needed for the following types:

'demonstration'
'review'
'rengo_review'

References:

https://groups.google.com/forum/#!searchin/kgs-client-coding/download%7Csort:relevance/kgs-client-coding/7uxh5Ku_E-Y/qqZ5_oamDgAJ
http://www.gokgs.com/gameArchives.jsp?user=Dom&year=2017&month=4

https://github.com/NekR/offline-plugin

Remove happens when setting/unsetting territory after game

Unclear when change/reorder happens

• Move num
• Pull out players if not present in channel
• Captures
• Time system / rules
• Result/score

Could cause missed server messages

KGS client mailing list, /r/baduk, Twitter, FB, KGS chat

Right now we only handle 9x9, 13x13, and 19x19

New tab in details modal.

Can we use the image from here?

http://www.gokgs.com/graphPage.jsp?user=wrap

In-progress requests could be canceled or ignored instead of generating a top-level error (which may at some point be logged or sent to an error-tracking service)

This doesn't actually affect the user experience

• Move
• Pass
• Resign
• Send Undo
• Accept/decline undo
• Basic scoring
• Add time - 1 minute, 5 minutes
• Don't send move if stone already present
• Placeholder on click until server confirms
• Stone hover
• Safe mobile option? Double tap, or confirm?
• Confirm resign
• Prevent illegal moves (ko, suicide)
• Nicer scoring mode - show score, done feedback
• Switch to game review; button to review
• "Are you sure you want to leave this game?" [leave] [don't leave] [resign]
• Alert when opponent leaves
• Badge on Play tab (and in window title) for "playing" (green) / unseen move (red)

Use jest

• Mobile user flag
• Guest login
• Register account
• Cross-origin for API? See curl -H "Origin: https://example.com" -H "Access-Control-Request-Method: POST" -X OPTIONS --verbose https://www.gokgs.com/json/access
• HTTPS for avatar images
• "Internal error. Check webapp logs." sometime when game ends, sometimes when playing
• JOIN_REQUEST and JOIN_GAME_BY_ID don't return anything for an Invalid game id. Makes it difficult to give an error for opening stale game id or stale URL
• Is there a way to determine which game a challenge becomes if you are not subscribed to its channel?
• SET_PASSWORD doc is wrong: field is "user" not "name"
• GAME_UNDO_REQUEST response: role: "KRole[black]"
• Pagination for archives
• Most efficient way to get list of resumable games? Subscribe to own archive channel?

Waiting on KGS API to support it

when game is being reviewed/edited, the result won't show in chat area and maybe not title

• Message received
• Challenge received
• Move played (own game only?)
• Challenge accepted
• Overtime (beeps and/or countdown)

See https://groups.google.com/forum/#!topic/kgs-client-coding/14x3ReFoMQk

Upstream messages:

• JOIN_REQUEST
• CHALLENGE_SUBMIT
• CHALLENGE_PROPOSAL - change default (owner only)
• CHALLENGE_RETRY - like undo submit for owner only
• CHALLENGE_ACCEPT
• CHALLENGE_DECLINE
• CHALLENGE_CREATE
• CHAT?

Downstream messages:

• CHALLENGE_JOIN
• CHALLENGE_DECLINE - other player declined
• CHALLENGE_PROPOSAL - proposal sent for consideration; sent for everyone not just you and creator
• CHALLENGE_FINAL - game starting
• CHALLENGE_SUBMIT - someone else submitted
• CHALLENGE_CANT_PLAY_RANKED
• CHALLENGE_CREATED
• CHALLENGE_NOT_CREATED
• CHAT

Game.actions:

• CHALLENGE_CREATE - ?
• CHALLENGE_SETUP
• CHALLENGE_WAIT
• CHALLENGE_ACCEPT
• CHALLENGE_SUBMITTED

Other items:

• Use usersByName to render UserName in player list
• Show room
• Challenge creators from rooms you don't belong to: name is [unknown], missing from usersByName
• Temporary: cancel if proposal doesn't match
• Handicap/komi editable when color selected, not otherwise
• Make sure proposal matches before auto-accepting
• Take unranked/guest status into account (changes game type)
• Nice design for (readonly) challenge dialog
• Proposal equality: if nigiri, colors don't matter
• Detect if default komi differs from initial proposal (6.5 vs 7.5)
• Show board size in modal
• Nice design for editable challenge dialog
• Ability to navigate away from play section while challenge is open
• Switching own rank on/off does not reflect change in challenge matchInfo
• Highlight differences when changes made to an existing proposal
• Navigate through received proposals with prev/next
• Notification badge/sound when challenge received
• Sound when challenge received
• When receiving challenge, only highlight changes against expected "even" proposal, not initialProposal
• when accepting challenge, briefly shows "negotiating" mode before starting game
• As rank changes when you play, proposal not reflecting latest rank - currentUser not being updated?
• Remember settings used to create proposal in preferences
• Prevent setting ranked + private
• Chat area; show users waiting ("observers"?)
• When game opens to watch, make sure we leave any previous game we were watching
• "The game owner accepted someone else's challenge"
• Consider sub-nav under Play so you can browse challenges while you have one open; or allow for multiple open challenges?

https://github.com/anazawa/sgfgrove ?

https://groups.google.com/forum/#!topic/kgs-client-coding/0iSS3c-H5t4