jjeffery / errors Goto Github PK

This changes the API, but it remains source code compatible. The idea is to make the message parameter in the Wrap function variadic. This effectively makes the message parameter optional, so that it is possible to wrap an error and add keyval pairs without changing the message.

if err := doSomething(); err != nil {
    return errors.Wrap(err).With("p1", p1, "p2", p2)
}

If more than one message is passed, then the message arguments are concatenated, but only after removing blank messages.

So errors.Wrap(err, "cannot do something", "", "try something else") would result in a message cannot do something: try something else: <orignal error message>. The stripping out of blank messages is necessary to be backwards compatible with code like the following:

if err := doSomething(); err != nil {
    return errors.Wrap(err, "").With("p1", p1, "p2", p2)
}

I like to have the ability to have Keyvals context value for structure logging. I was wondering how to include stack trace?

Experiment with ideas mentioned in pkg/errors#34, pkg/errors#70 and pkg/errors#73.