jjazzboss / jjazzlab Goto Github PK

When the RhythmDatabase scans all the available RhythmProviders to get the rhythms based on files, if an error happens during reading a file, there is no error message for the end user, only log messages are produced.

As we possibly read hundreds of files, error notification per file is not OK, but a summary at the end of all rhythm files which could not be read should be shown to the user.

See AbstractRhythmProvider.java getFileRhythms()

The Song model object already embeds a Comments String field to put whatever information related to the song (e.g. the composer name, etc.). Same for a list for tags which could be used when searching or sorting songs.

But the UI does not provide any way for the user to view or edit these data. It should be possible.

Right now the choice 1/2 bars precount if made by JJazzLab depending on time signature and tempo.

Steps to reproduce: edit chord symbol, add Alternate symbol for a specific marker.
Close. Reopen dialog and this triggers and assertion error.

Insert bars action inserts on the position of the first currently selected bar, but it uses type of the bar before it for template. This is somewhat confusing as the dialog states "# bars from bar: x", but bar x - 1 is used for template.

When first bar is selected, new bar is inserted at the beginning, but it creates new section with the new name.

Maybe using first currently selected bar for template and providing also insert after or extend bar action could be more understandable...

Yamaha styles generally use XG drum keymap. If rendering on a GM or GM2 synth, some sounds are not correct, especially notes below pitch 35.

In the Mix Console with one rhythm. Output Synth is such that drums rerouting is enabled by default (user selected "Remember my choice during this session" in the Midi config fix dialog). If adding a new rhythm in the song, new drums/perc channels are rerouted but display is not correct: some buttons/knobs look enabled instead of disabled.

Hello, I have been able to create several backing tracks but now I am now unable to view and adjust the parameters for each section i.e mute intensity etc.
I have uninstalled and reinstalled the program several times
Can you help?

at org.jjazz.ui.spteditor.api.SptEditorTopComponent.getInstance(SptEditorTopComponent.java:95)
at org.jjazz.ui.spteditor.SptEditor.updateTabName(SptEditor.java:638)
at org.jjazz.ui.spteditor.SptEditor.updateUIComponents(SptEditor.java:494)
at org.jjazz.ui.spteditor.SptEditor.refresh(SptEditor.java:408)
at org.jjazz.ui.spteditor.SptEditor.songPresenceChanged(SptEditor.java:477)
at org.jjazz.ui.spteditor.SptEditor.(SptEditor.java:159)
at org.jjazz.ui.spteditor.api.SptEditorTopComponent.(SptEditorTopComponent.java:82)
at jdk.internal.reflect.GeneratedConstructorAccessor8.newInstance(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)
at org.netbeans.modules.settings.convertors.XMLSettingsSupport.newInstance(XMLSettingsSupport.java:75)
at org.netbeans.modules.settings.convertors.XMLPropertiesConvertor.defaultInstanceCreate(XMLPropertiesConvertor.java:203)
at org.netbeans.modules.settings.convertors.XMLPropertiesConvertor.read(XMLPropertiesConvertor.java:74)
at org.netbeans.modules.settings.InstanceProvider$InstanceCookieImpl.instanceCreate(InstanceProvider.java:292)
at org.netbeans.core.windows.persistence.PersistenceManager.getTopComponentPersistentForID(PersistenceManager.java:547)
at org.netbeans.core.windows.persistence.PersistenceManager.getTopComponentForID(PersistenceManager.java:657)
at org.netbeans.core.windows.PersistenceHandler.getTopComponentForID(PersistenceHandler.java:453)
at org.netbeans.core.windows.WindowManagerImpl.getTopComponentForID(WindowManagerImpl.java:1002)
at org.netbeans.core.windows.WindowManagerImpl.findTopComponent(WindowManagerImpl.java:270)
at org.jjazz.ui.spteditor.api.SptEditorTopComponent.getInstance(SptEditorTopComponent.java:95)
at org.jjazz.ui.spteditor.SptEditor.updateTabName(SptEditor.java:638)
at org.jjazz.ui.spteditor.SptEditor.updateUIComponents(SptEditor.java:494)
at org.jjazz.ui.spteditor.SptEditor.refresh(SptEditor.java:408)
at org.jjazz.ui.spteditor.SptEditor.songPresenceChanged(SptEditor.java:477)
at org.jjazz.ui.spteditor.SptEditor.(SptEditor.java:159)
at org.jjazz.ui.spteditor.api.SptEditorTopComponent.(SptEditorTopComponent.java:82)
at jdk.internal.reflect.GeneratedConstructorAccessor8.newInstance(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)
at org.netbeans.modules.settings.convertors.XMLSettingsSupport.newInstance(XMLSettingsSupport.java:75)
at org.netbeans.modules.settings.convertors.XMLPropertiesConvertor.defaultInstanceCreate(XMLPropertiesConvertor.java:203)
at org.netbeans.modules.settings.convertors.XMLPropertiesConvertor.read(XMLPropertiesConvertor.java:74)
at org.netbeans.modules.settings.InstanceProvider$InstanceCookieImpl.instanceCreate(InstanceProvider.java:292)
at org.netbeans.core.windows.persistence.PersistenceManager.getTopComponentPersistentForID(PersistenceManager.java:547)
at org.netbeans.core.windows.persistence.PersistenceManager.getTopComponentForID(PersistenceManager.java:657)
at org.netbeans.core.windows.PersistenceHandler.getTopComponentForID(PersistenceHandler.java:453)
at org.netbeans.core.windows.WindowManagerImpl.getTopComponentForID(WindowManagerImpl.java:1002)
at org.netbeans.core.windows.WindowManagerImpl.findTopComponent(WindowManagerImpl.java:270)
at org.jjazz.ui.spteditor.api.SptEditorTopComponent.getInstance(SptEditorTopComponent.java:95)
at org.jjazz.ui.spteditor.SptEditor.updateTabName(SptEditor.java:638)
at org.jjazz.ui.spteditor.SptEditor.updateUIComponents(SptEditor.java:494)
at org.jjazz.ui.spteditor.SptEditor.refresh(SptEditor.java:408)
at org.jjazz.ui.spteditor.SptEditor.songPresenceChanged(SptEditor.java:477)
at org.jjazz.ui.spteditor.SptEditor.(SptEditor.java:159)
at org.jjazz.ui.spteditor.api.SptEditorTopComponent.(SptEditorTopComponent.java:82)
at jdk.internal.reflect.GeneratedConstructorAccessor8.newInstance(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)
at org.netbeans.modules.settings.convertors.XMLSettingsSupport.newInstance(XMLSettingsSupport.java:75)
at org.netbeans.modules.settings.convertors.XMLPropertiesConvertor.defaultInstanceCreate(XMLPropertiesConvertor.java:203)
at org.netbeans.modules.settings.convertors.XMLPropertiesConvertor.read(XMLPropertiesConvertor.java:74)
at org.netbeans.modules.settings.InstanceProvider$InstanceCookieImpl.instanceCreate(InstanceProvider.java:292)
at org.netbeans.core.windows.persistence.PersistenceManager.getTopComponentPersistentForID(PersistenceManager.java:547)
at org.netbeans.core.windows.persistence.PersistenceManager.getTopComponentForID(PersistenceManager.java:657)
at org.netbeans.core.windows.PersistenceHandler.getTopComponentForID(PersistenceHandler.java:453)
at org.netbeans.core.windows.WindowManagerImpl.getTopComponentForID(WindowManagerImpl.java:1002)
at org.netbeans.core.windows.WindowManagerImpl.findTopComponent(WindowManagerImpl.java:270)
at org.jjazz.ui.spteditor.api.SptEditorTopComponent.getInstance(SptEditorTopComponent.java:95)
at org.jjazz.ui.spteditor.SptEditor.updateTabName(SptEditor.java:638)
at org.jjazz.ui.spteditor.SptEditor.updateUIComponents(SptEditor.java:494)
at org.jjazz.ui.spteditor.SptEditor.refresh(SptEditor.java:408)
at org.jjazz.ui.spteditor.SptEditor.songPresenceChanged(SptEditor.java:477)
at org.jjazz.ui.spteditor.SptEditor.(SptEditor.java:159)
at org.jjazz.ui.spteditor.api.SptEditorTopComponent.(SptEditorTopComponent.java:82)
at jdk.internal.reflect.GeneratedConstructorAccessor8.newInstance(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)
at org.netbeans.modules.settings.convertors.XMLSettingsSupport.newInstance(XMLSettingsSupport.java:75)
at org.netbeans.modules.settings.convertors.XMLPropertiesConvertor.defaultInstanceCreate(XMLPropertiesConvertor.java:203)
at org.netbeans.modules.settings.convertors.XMLPropertiesConvertor.read(XMLPropertiesConvertor.java:74)
at org.netbeans.modules.settings.InstanceProvider$InstanceCookieImpl.instanceCreate(InstanceProvider.java:292)
at org.netbeans.core.windows.persistence.PersistenceManager.getTopComponentPersistentForID(PersistenceManager.java:547)
at org.netbeans.core.windows.persistence.PersistenceManager.getTopComponentForID(PersistenceManager.java:657)
at org.netbeans.core.windows.PersistenceHandler.getTopComponentForID(PersistenceHandler.java:453)
at org.netbeans.core.windows.WindowManagerImpl.getTopComponentForID(WindowManagerImpl.java:1002)
at org.netbeans.core.windows.WindowManagerImpl.findTopComponent(WindowManagerImpl.java:270)
at org.jjazz.ui.spteditor.api.SptEditorTopComponent.getInstance(SptEditorTopComponent.java:95)
at org.jjazz.ui.spteditor.SptEditor.updateTabName(SptEditor.java:638)
at org.jjazz.ui.spteditor.SptEditor.updateUIComponents(SptEditor.java:494)
at org.jjazz.ui.spteditor.SptEditor.refresh(SptEditor.java:408)
at org.jjazz.ui.spteditor.SptEditor.songPresenceChanged(SptEditor.java:477)
at org.jjazz.ui.spteditor.SptEditor.(SptEditor.java:159)
at org.jjazz.ui.spteditor.api.SptEditorTopComponent.(SptEditorTopComponent.java:82)
at jdk.internal.reflect.GeneratedConstructorAccessor8.newInstance(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)
at org.netbeans.modules.settings.convertors.XMLSettingsSupport.newInstance(XMLSettingsSupport.java:75)
at org.netbeans.modules.settings.convertors.XMLPropertiesConvertor.defaultInstanceCreate(XMLPropertiesConvertor.java:203)
at org.netbeans.modules.settings.convertors.XMLPropertiesConvertor.read(XMLPropertiesConvertor.java:74)
at org.netbeans.modules.settings.InstanceProvider$InstanceCookieImpl.instanceCreate(InstanceProvider.java:292)
at org.netbeans.core.windows.persistence.PersistenceManager.getTopComponentPersistentForID(PersistenceManager.java:547)
at org.netbeans.core.windows.persistence.PersistenceManager.getTopComponentForID(PersistenceManager.java:657)
at org.netbeans.core.windows.PersistenceHandler.getTopComponentForID(PersistenceHandler.java:453)
at org.netbeans.core.windows.WindowManagerImpl.getTopComponentForID(WindowManagerImpl.java:1002)
at org.netbeans.core.windows.WindowManagerImpl.findTopComponent(WindowManagerImpl.java:270)
at org.jjazz.ui.spteditor.api.SptEditorTopComponent.getInstance(SptEditorTopComponent.java:95)
at org.jjazz.ui.spteditor.SptEditor.updateTabName(SptEditor.java:638)

e.g. on windows, when "VirtualMidiSynth" Midi out driver is selected, automatically propose to use the JJazzLab SoundFont preset.

Examples:
Ab or A#: b or # is too far from the A
Am7M: the 7M extension (displayed as exponent) is too far from Am
A7#5: the #5 extension is too far from A7, and the 5 is too far from the #9

Display is OK on Linux and Windows.

Failed calling method
---- Debugging information ----
message : Failed calling method
cause-exception : java.lang.NullPointerException
cause-message : null
method : org.jjazz.midi.Instrument$SerializationProxy.readResolve()
class : org.jjazz.midi.Instrument$SerializationProxy
required-type : org.jjazz.midi.Instrument$SerializationProxy
converter-type : com.thoughtworks.xstream.converters.reflection.ReflectionConverter
path : /OutputSynth/spUserInstrument
line number : 16
class[1] : org.jjazz.outputsynth.OutputSynth$SerializationProxy
version : 1.4.9

In a multi-rhythm song: select a song part which uses the 2nd rhythm, then Play Selection.

In the Rhythm selection dialog window, clicking on a column header sorts the table by this column by alphabetical order. It should be numerical order for the tempo column.

Because it is based on the Netbeans platform some degree of internationalization is already implemented, but it's not complete. Once done it should be possible to add new languages. I can help by providing translations for French if needed.

If a song has 2 rhythms, removing the 2nd rhythm means to set it as the previous one. This is not handy. Would be simpler to have a menu action directly proposing to remove the 2nd rhythm.

If intensity is -10, normal notes are much lower, but not the accented notes which sound very loud in comparison.

Some JJazzLab-X UI actions still use BooleanStateAction, but this is deprecated now with Netbeans platform 11.

These actions should be refactored to use the (somewhat simpler) mechanism demonstrated in SectionAtNewLine.java in package org.jjazz.ui.cl_editor.actions (module CL_Editor). Or use newer org.jjazz.utilities.api.ToggleAction

For example C7#11/E is displayed as C7/E#11

Right now if several chord symbols are selected and we drag one of them, only the dragged is moved/copied.

For example user wants to replace the bass line generated by JJazzLab with its own bass line. He can replace the whole bass track, or only parts of the bass track (for example by preselecting bars and songparts). Then he can record its own bassline which should be saved with the song file.

So that some instruments do not play

Once user-recording features are enabled (see Issue #6 and Issue #7), how to visualize/edit the user-recorded music ?

Objective is to enable simple visualization/edition capabilities of recorded music, plus quantization capabilities. For example with a piano-roll editor or, even simpler, automated export/import via an external Midi editor tool like MidiEditor.

We just see the name of the output synth config file. So don't know if it's configured for VMS or Java Internal Synth etc.

The melody should be saved in the song file.

The melody should use the User Midi Channel which is already defined in the MidiMix / MixConsole.

Midi input device selection is already programmed in the Tools/Options/Midi panel but needs to be enabled.

When selecting channels to mute in Song Part editor, there is chord1 and chord2, which one is Guitar ? which one piano ? There should be a tooltip at least, or use the instrument type or name.

It works using ctrl-space.

By default JJazzLab uses the builtin java soundbank, which is not high-quality.

When reading the .sng file with e.g. a D° chord symbol, there is a warning : Unknown "D?" chord symbol, using C instead.

If chord edit is called using double-click, then the correct chord is displayed.

For example if a timbale percussion sounds much too strong on a Midi device, this allows user to fix it.

On Linux, the textfield "Directory for default rhythm mix files" in Options/Rhythms panel is too small, can't read text.

If a song uses more than 1 rhythm, each rhythm uses its own set of instruments. When rendering it makes the rhythm transition not natural because all sounds change. A workaround is to manually copy the instrument settings to all instruments, which is not convenient. We need a better way of handling this.

Possibly on its own channel, velocity, low/high sound etc.

From mix console, click an instrument, dialog opens, changing the transposition does not have effect when testing the sound in the dialog (speaker icon).

If slash chord e.g. C/E is not the first chord of the bar, then bass note played in C instead of E.

Steps to reproduce:

1. Have a song with starting section in 4/4
2. Open rhythm selection dialog then close
3. Switch the song section to 3/4
4. Open rhythm selection dialog => assertiong error

Create a song with mediumjazz.s737 (1 drum channel, no percussion channel). Add another rhythm chartballad.s859 to the song. The chartballad's percussion channel is assigned a piano instrument...

Create a song with rhythm chartBallad.S859.sty. Changing the instrument transposition has an effect on the generated music for all channels, EXCEPT on the Pad channel (voice=Choir Aahs). Choir notes remain always the same whatever the transposition set.

For e.g. a bass channel, when changing an instrument we see all the instruments in defaultorder: should see the available bass instruments first.

Maybe plus a specific one for windows configuration. Equivalent to remove whole or part of the Netbeans user directory.

This way, if an unexpected exception occurs, we know the faulty file.

When using a slash chord like Cm/G propose some options in the Chord Symbol edit dialog:

• force all bass notes to be the chord symbol bass note
• bass on beat 2 & 4 ?

Make a song with 2 different rhythms. In Mix Console show only 1 rhythm. Delete all song parts for the other rhythm. The Mix Console becomes empty and no way to restore it.

JJazzLab-X should embed a maximum of instrument definition files for existing synthesizers, sound modules or virtual instruments.