jinwook-k / google-local-guides-api Goto Github PK

Since all of the fields have somewhat static patterns and only varying by name, I could pull out all the patterns into a constant into another file?...

idk if it'll be worth the time/readability. it'll just make each file shorter to read....

There should be a way to pull in actual reviews, ratings, and photos that you actually made (i think)

I don't have a need for it, so i'm not implementing it yet.

@JinKim7, thanks for this great package. Unfortunately you did not explicitly specify a license in the GitHub repository, while npm states it's licensed under ISC (derived from package.json). I think it would be great to also directly include a license file in the repository to prevent any potential future confusion regarding permitted use of the source code. What dou you think?

if I want to add another field for the profile pic image link used for your profile, I can test out searching for this type of substring within the body:

// Research: could probs do a quicker search includes email
["//lh3.googleusercontent.com/-randomletters0/AAAAAAAAAAI/AAAAAAAAAAA/QSzyidpnc6o/d980-v-pe-hd-hi7-13df100/photo.jpg", "[email protected]", "John Doe",...]

Those methods below aren't working. I guess it was when @JinKim7 released the library , but Google Maps updated their UI what broke the code

          reviews: this.getReviews(),
          ratings: this.getRatings(),
           questions: this.getQuestions(),
           placesAdded: this.getPlacesAdded(),
           edits: this.getEdits(),
           facts: this.getFacts(),
           videos: this.getVideos(),
           qa: this.getQA(),
           roadsAdded: this.getRoadsAdded(),
           listsPublished: this.getPublishedLists()

Those ones still works :

            points: this.getPoints(),
            level: this.getLevel(),

I guess we would need to simulate how to get the pop-up with all those informations to make it work again