jimgraham / netsparkle Goto Github PK

Hi jimgraham!

As you're probably aware, NetSparkle has seen a lot of forks over the years. I've been the maintainer of a fork for quite a long time (original code by original author here), and I'm trying to consolidate the community to one organization/repo found at NetSparkleUpdater/NetSparkle.

If you're not planning to keep this fork active, do you think you could update it to point people to the new location of NetSparkle so that the community will be able to come together more easily? Your repo currently shows up quite high in search results for 'NetSparkle', but hasn't been updated in a long time, so I thought I'd ping you here to see what you think.

Thanks!

Deadpikle

There's a bug in the OnWebDownloadClientDownloadFileCompleted -method that causes the UI to signal to the user that the DSA signature on a downloaded (MSI) mismatches (sets red background etc), even though CheckDSA returns true.

This issue was been fixed in the original rep. of NetSparkle along time ago.

There is an error on line 507 in netSpakle.cs

this.ProgressWindow.ShowDialog();

This line should be put under

Uri url = new Uri(item.DownloadLink);
            _webDownloadClient.DownloadFileAsync(url, _downloadTempFileName);

Or the download and events will never start.

By the way , thanks for this fork. You saved me a lot of time , cause i was changing the source to use with only 1 check instead of loop.