Compatibility issues with Django 2.0a1 about django-postgresql-netfields HOT 8 CLOSED

As I continue investigating, it appears this is using a long-deprecated piece of code.

The base NetQuery class in managers.py looks like this:

class NetQuery(sql.Query):
    query_terms = sql.Query.query_terms.copy()
    query_terms.update(NET_OPERATORS)

Looking through the history of django.db.models.sql, I found the following commits:
django/django@af69f14#diff-0edd853580d56db07e4020728d59e193 (Removed unused sql.Query.query_terms) which refers to...
django/django@5008a4d (Removed legacy ORM lookup support per deprecation timeline; refs #16187.)

This latter commit exists in every Django version starting with 1.9a1. So it would appear that this has been a long-unsupported variable.

I will continue investigating to see how to work around this.

from django-postgresql-netfields.

During my digging, I have been able to work through this a little further, but I've run into a bug in django-rest-framework, so until that library has been updated with Django 2.0 compatibility, I believe this will be blocked.

I've opened a ticket here: encode/django-rest-framework#5456

from django-postgresql-netfields.

I've got a MR here: #74

It's not done just now, but I think I can get it working.

from django-postgresql-netfields.

Apologies for the delay on this.

I just checked in support for Django 2.0. It looks like most of the stuff in managers was unnecessary in Django 1.8+ so removing it seemed to work.

However, the project I'm using this on is stuck at 1.9 due to another dependency. I have a little test app I have for this which is working fine on 2.0b2, but if one of you wanted to try it on your project before I release on pypi, that would be really appreciated.

from django-postgresql-netfields.

from django-postgresql-netfields.

With the release of Django 2.0 happening soon can you please release the master as a new version so users can just install it from PyPi?

from django-postgresql-netfields.

@jimfunk This somehow fell off my radar, but I'm circling back now that Django 2.0 has been released. Running our test suite using the latest master checkout here, it does appear to be working! I'm still running into issues with other packages, but so far this one is no longer standing as a blocker.

from django-postgresql-netfields.

OK, thanks for that. I will have to do a release then. I'm going to need it soon too.

from django-postgresql-netfields.