jimd1989 / discogs Goto Github PK

Before running a system command, check if eyeD3 is even in the PATH. Hard fail if not. If mp3val exists, run mp3val -f, but continue otherwise.

Look into FindExecutable to implement this.

Consider using more refined types throughout the codebase, such as Nat and NonEmpty.

Words that shouldn't be capitalized like The will not be checked if decorated by another char. Example: (The.

• Check decorated articles
• Import some sort of master list of words that shouldn't be capitalized, rather than manually thinking of them.

https://www.discogs.com/Pierre-Henry-Futuristie/release/256595

Shows up as two discs

Command line flags should use an established library for parsing.

Basic interactive command line search of Discogs would remove need to copy link from browser.

Disable implicit imports of Prelude.

Like on https://www.discogs.com/Pierre-Henry-Futuristie/release/256595

Most likely due to show. Avoid this in favor of System.Posix.Escape.Unicode (escape)

In order to avoid editing discogs.cabal manually, try using Hpack?

Move away from eyeD3 and tag ID3 tags within this program. There is a very old ID3 library that is hard to compile. Look into polishing this up, or rolling your own.

Explore linear types. Needs newer GHC?

Enable something like -Weverything and ensure its standards are met.

Add option to fetch album art. Requires cookie I think.

Commands are very noisy. Some sort of user feedback should be written to stderr, but not the entire output of mp3val and eyeD3.

Parallelize the call to eyeD3?

Use Text or ByteString instead of String. Perhaps the lazy version? Ensure unicode behaves nicely.