jima80525 / ctypes_example Goto Github PK

This calling of the wrapper functions and assignment to the instance on every new point instantiation just looks bad. It is not that bad, as the wrapped functions are not new objects, but it remakes the assignment to the unique func in the ctypes wrapper for the library (although it would still have a major impact would one write actual Python code dealing with a couple hundred of Point instances)

I'd suggest just making the wrap call once, on top level code, would be much more elegant here:

class Point(...):
    ...
    def move(self):
         Point._move_point_func(self)

# These assignments must be after class body, due to the needed referenc  to the class itself.
 Point._move_point_func = wrap_function(lib, 'move_point', None, [Point])
...

(I am not sure if the functions wrapped by ctypes have a proper __get__. If they have, you might not even need the intermediate move method)

Good to see you fixed the __init__ for your point wrapper. I was reading the post, and upon finding the attribution self = get_point() here, I came here to file the bug at once. :-)

self is just a normal variable inside a method, and attributing to it will just make it point to another object, not "self" anymore.

Currently, MapGetter naively replaces the builtin __import__ inside the with block. The existing import hooks seems to offer ways to make that in a cleaner way.