jihan2032 / ui-shopping-cart Goto Github PK

https://github.com/jihan2032/UI-Shopping-cart/blob/master/shopping_cart.html#L102

This way you will avoid selecting the input accidentally using CSS

We didn't discuss how to do it and I said don't do it. Keep that issue opened so that in the futuer we use divs instead :)

I am impressed. Let me tell you what I liked

• Appending the $ to the beginning of the variables that contain jQuery object
• Caching the elements by using variables
• Properly walking the DOM

My only advice is, when you pass arguments to a funtion make sure you use those arguments ... Otherwise just ignore them. Example:

$(document).on('click', '.sub-btn', function(ev) {

You are passing the event as ev and you are not using it inside the function. If you're not going to use it, omit it.

This way the links will be grouped together. I am talking about the links on the footer

Congratulations. So far you are the best student to use document outline. I would suggest convert the footer h1s to h2 and use a visually hidden h1 that have the text Sitemap inside it :)

https://github.com/jihan2032/UI-Shopping-cart/blob/master/shopping_cart.html#L30

This way it will be marked as a title

This assignment is going to grow. What you are building here is the homepage. It should be renamed to index.html :)

You are missing the type attribute :)

https://github.com/jihan2032/UI-Shopping-cart/blob/master/shopping_cart.html#L101

It should be set to email. This way the browser will validate the input as an email without using any 3rd party library

I see that you are using the class container on every section. Why not use a common div with the class container to wrap them all? That's better.

I love what you did with this:

    <script>
      window.jQuery ||
      document.write('<script src="scripts/vendor/jquery.min.js"><\/script>')
    </script>
    <script src="scripts/main.js"></script>

But please move it to the bottom of the page :D It's a good practice to move JavaScript to the bottom