Code Monkey home page Code Monkey logo

Comments (4)

trusktr avatar trusktr commented on July 28, 2024

Should we at least move this repo into the Docsify org now, so that maintainers can be aware of it? At the moment there are only 4 people watching the repo, and only two (you and me) are maintaining Docsify. So they aren't keeping track of anything going on here.

from docsify-themeable.

jhildenbiddle avatar jhildenbiddle commented on July 28, 2024

I don't want to move code from this repo into the docsify repo until the integration is actually going to start. This will happen after v4 has stabilized because I don't want to integrate against a moving target. There's no value in having code in the docsify repo unless we're going to do something with it (as the saying goes, "don't confuse activity for progress"). For now, having the code in a separate repo is an effective way to prevent folks from diving in and trying to tackle the integration before it's time.

As far as CSS targeting various screen sizes, what styles would you like to add/modify that are not present today? I'm not implying everything is covered in the current batch of custom properties (it isn't). Just curious what you would like to see added.

It's also worth noting that the custom properties are only intended to surface the styles users are mostly likely to want to modify. Implementation details like how the sidebar opens/closes are intentionally hidden from the user. It's by design. If someone really wants to know how the sidebar menu opens/closes, there's nothing preventing them from looking at the code and writing their own CSS to override it (just as docsify theme authors not using docsify-themeable do today).

from docsify-themeable.

jhildenbiddle avatar jhildenbiddle commented on July 28, 2024

@trusktr --

FYI, @media rules are generated using a sass mixin called include-media, which may explain why a search for @media in this repo doesn't return the expected results and give the impression that media properties aren't used in this project. This search will be more helpful:

https://github.com/jhildenbiddle/docsify-themeable/search?q=%22%40include+media%22&unscoped_q=%22%40include+media%22

Breakpoints are defined here:

$breakpoints: (
xsmall : 26em, // 416px / phone @ portrait
small : 30em, // 480px / phone @ landscape / small tablet (portrait)
medium : 48em, // 768px / small tablet (landscape) / large tablet (portrait)
large : 64em, // 1024px / large tablet (landscape) / small desktop
xlarge : 80em, // 1280px / standard desktop
xxlarge: 100em // 1600px / large desktop
);

FWIW, both the xlarge and xxlarge are not used in this project.

from docsify-themeable.

jhildenbiddle avatar jhildenbiddle commented on July 28, 2024

Closing due to inactivity. Hopefully the comments above help explain.

Thanks, @trusktr!

from docsify-themeable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.