Comments (4)
Should we at least move this repo into the Docsify org now, so that maintainers can be aware of it? At the moment there are only 4 people watching the repo, and only two (you and me) are maintaining Docsify. So they aren't keeping track of anything going on here.
from docsify-themeable.
I don't want to move code from this repo into the docsify repo until the integration is actually going to start. This will happen after v4 has stabilized because I don't want to integrate against a moving target. There's no value in having code in the docsify repo unless we're going to do something with it (as the saying goes, "don't confuse activity for progress"). For now, having the code in a separate repo is an effective way to prevent folks from diving in and trying to tackle the integration before it's time.
As far as CSS targeting various screen sizes, what styles would you like to add/modify that are not present today? I'm not implying everything is covered in the current batch of custom properties (it isn't). Just curious what you would like to see added.
It's also worth noting that the custom properties are only intended to surface the styles users are mostly likely to want to modify. Implementation details like how the sidebar opens/closes are intentionally hidden from the user. It's by design. If someone really wants to know how the sidebar menu opens/closes, there's nothing preventing them from looking at the code and writing their own CSS to override it (just as docsify theme authors not using docsify-themeable do today).
from docsify-themeable.
@trusktr --
FYI, @media
rules are generated using a sass mixin called include-media, which may explain why a search for @media
in this repo doesn't return the expected results and give the impression that media properties aren't used in this project. This search will be more helpful:
Breakpoints are defined here:
docsify-themeable/src/scss/app/_variables.scss
Lines 5 to 12 in 71309a6
FWIW, both the xlarge
and xxlarge
are not used in this project.
from docsify-themeable.
Closing due to inactivity. Hopefully the comments above help explain.
Thanks, @trusktr!
from docsify-themeable.
Related Issues (20)
- cannot change '>' and 'v' color HOT 2
- The drop-down arrow does not appear when using "routerMode: 'history'" HOT 2
- Changing the padding (top/bottom) on "blockquote" HOT 2
- expand/collapse icons in the sidebar not working when external link present HOT 3
- Browser console reports an uncaught error HOT 2
- Sidebar not aligning to left of page HOT 1
- sidebar not aligned between file and folder classes HOT 2
- Inactive chevron in multilevel menu show up as active HOT 6
- Inactive chevron in multilevel menu show up as active HOT 3
- Page content is not using all available space on large screens HOT 1
- Unexpected style of title when I come to the third level of the sidebar HOT 1
- Can we make the sidebar arrow in theme-simple point right if it has multiple sidebar .md files HOT 1
- On a phone brower, when touching any sidebar contents, the sidebar will hide automatically. HOT 5
- Top level sidebar items should always be collapsible HOT 2
- Table in small screens will render with CSS attribute `content`
- Switch button for dark/light mode HOT 2
- In the cover page Custom background is invalid HOT 5
- Quotation Marks Inconsistent HOT 5
- Unexplained 'TypeError: Attempted to assign to readonly property.' console error message HOT 8
- Keyboard focus is not visible at Hamburger menu present at the UI.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docsify-themeable.