jguerinet / morf Goto Github PK

Look into how to correctly use R (the library one vs. the app one)

background() is an example

0 is causing problems with the color filter

Hi Julian,
My name is Enrique de Miguel and I like your android form generator. I was wondering if you accept contributions to your project. I've got a few ideas and I would like to develop some of them.
I hope to hear from you soon.

Regards
Enrique de Miguel

This is because they all have the same Id so they all get updated with the last form item of that type's data.

This will allow us to use the Android colors in the Color class.

Allow the user to set a default drawable padding, and also change it per form item.

This is to allow a null background

It would have to be some sort of builder setup, where the user would specify the values that they would want for the given item.
This would eliminate the need to have methods that take so many inputs: the user could just pick the inputs they want.

If we do this, then you could deconstruct the FormGenerator, change one parameter, and then reconstruct it. For example:

• You set the default FG to a customized FG
• Then, for one activity, you need to change one detail
• You deconstruct the default FG, change that one parameter, and reconstruct it for that activity only.

Version
v5.0.0

Description
Library has great features but these aren't clear in the README. Also, you might want to add an issue template.

Since the old padding is in pixels, the new padding dimen is never checked. When setting a padding dimen, the padding field should be cleared.

Depends on #3

This will allow us to not set the icon over and over again, and remove the view() option. It'll also make it easy for the list stuff.

Version 4.0.1

Description
Compiler gives the warning Unchecked call to 'onClick(Function1<? super T, Unit>)' as a member of raw type 'com.guerinet.fg.base.BaseTextViewItem' when adding an onClick listener to a form item. This warning doesn't occur when theonClick is added via method chaining.

Code

BaseTextViewItem exampleItem= fg.text()
        .text("Form Item: Button")
        .icon(Position.START, R.drawable.ic_info, false)
        .icon(Position.END, R.drawable.ic_chevron_right)
        .build();

exampleItem.onClick(item -> {
    Toast.makeText(this, "Form Item: Button Clicked", Toast.LENGTH_SHORT).show();
    return Unit.INSTANCE;
});

.setDefaultBackground(android.R.attr.selectableItemBackground) crashes