jgardona / mhv Goto Github PK

Consider using a buffer instead of using print! macro to perform output, because print! will flush the buffer all time degrading performance.

Sometimes is usefull to pass a different unit in input to save too much characters like:

1000b
1kb

Update cargo toml version to 0.3.3

Seems that struct, cli error was forget in main. Remove it from main.rs.

In documentation there is an example that says read 32 bytes but image shows it reads 16

Enhance the error messages by translate them to human readable ones.

Missing coma on doc usage help near mb and M.

Update the documentation to fit version 0.3.0.

Update documentation to fit new version

Enhance documentation to fit the cli new features.

Implement units for hexadecimal input, that could be useful to search by offsets.

The stream diagram has an error in arrow pointing to the wrong direction (for data). Must point to read data process.

Consider use https://github.com/jam1garner/owo-colors, which dont allocate, to enhance performance.

There are a typo in the mhv usage last line. Print versio. Must be changed for print version.

Seria melhor distinguir 0x00 de 0xff.

The pipe separator is unecessary. Considir removing this character, leaving only spaces.

Implement stdin input if a file is not specified in command line.

Update version number to milestone 0.3.0

Refactor display_data function to better fit unit tests. Consider use dependency injection.

Skip empty data offsets when parsing the entire file, There is no need to print the entire file and its missing data.

Enhance documentation by add a diagram about stream workflow for better project clarity.

Remove dots from cli txt documentation as clap doesnt follow this pattern.

Update software version number for the new milestone.

❯ cargo clippy
Checking mhv v2.0.0 (/home/jgardona/Workspace/rust/hdump)
warning: to_string applied to a type that implements Display in eprintln! args
--> src/main.rs:7:52
|
7 | eprintln!("Something wrong happened: {}", e.to_string());
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: #[warn(clippy::to_string_in_format_args)] on by default

Enhance characters to better visualization. Another different characters, print 0x00 as 00 and 0xff as FF, and use in left panel more diferse characters.

Implement the M and K units to comprise 1024 * 1024 and 1024 patterns.

There are too much unwrap without proper error handling causing execution error prone, like the one in main function.