jftuga / less-windows Goto Github PK

The Winget Releaser workflow is failing. Just a reminder that you need to do the prerequisites mentioned in #17 (comment) and rerun the failed workflow.

Today, I had to manually build a beta version to check if a bug existed in the latest version. However, this repo doesn't take into account beta builds. It would be great if beta releases were auto-built as well.

Attached below is a git patch to add support for beta builds based on changes I had to make today.

I didn't open a PR because I wanted to leave the final implementation to the maintainers. However, I think just including the patch file in the current branch would be easier than changing/editing files for this purpose. It would also keep the support optional and not affect the current GH actions.

The patch can be applied as usual with git am -k.

From c5b576db9a2deb2a072b1a50baa615c85bb3bf38 Mon Sep 17 00:00:00 2001
From: Aniket Teredesai <[email protected]>
Date: Sat, 2 Apr 2022 23:19:36 +0530
Subject: add support to build beta releases

---
 build.py  | 2 +-
 shared.py | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/build.py b/build.py
index 389c249..00b0172 100644
--- a/build.py
+++ b/build.py
@@ -46,7 +46,7 @@ def extract_archive(archive: str) -> str:
     """
 
     # given "less-561.zip", return "less-561
-    zip_dest = os.path.splitext(archive)[0]
+    zip_dest = os.path.splitext(archive)[0].replace("-beta", "")
 
     if os.path.exists(zip_dest):
         print("Removing preexisting directory: %s" % (zip_dest))
diff --git a/shared.py b/shared.py
index 6232600..91411c7 100644
--- a/shared.py
+++ b/shared.py
@@ -13,7 +13,7 @@ import time
 import urllib.request
 
 LESSURL = "http://greenwoodsoftware.com/less/download.html"
-version_url_re = re.compile(r"""Download <strong>RECOMMENDED</strong> version (.*?) """, re.M | re.S | re.I)
+version_url_re = re.compile(r"""Download <strong>BETA</strong> version (.*?) """, re.M | re.S | re.I)
 NEWFILE = "new.txt"
 
 
@@ -56,6 +56,6 @@ def get_latest_version_url(page: str) -> tuple:
         return (None, None)
 
     version = match[0]
-    archive = "less-%s.zip" % version
+    archive = "less-%s-beta.zip" % version
     url = LESSURL.replace("download.html", archive)
     return version, url
-- 
2.35.1.windows.2

less.exe and lesskey.exe are win64 binary files.
I need the win32 binary files.
Thanks.

Are you willing to provide automated build when external repo changes ?

You can setup all prereqs from chocolatey

1. Open a file containing Chinese characters
2. Enter search mode by pressing /
3. Paste or enter from the keyboard Chinese character
4. Press Enter
5. Less is hanging

PS C:\Users\asdf> scoop update *
less: 590 -> 608
msys2: 2022-06-03 -> 2022-09-04
WARN Scoop uses 'aria2c' for multi-connection downloads.
WARN Should it cause issues, run 'scoop config aria2-enabled false' to disable it.
WARN To disable this warning, run 'scoop config aria2-warning-enabled false'.
Updating 2 outdated apps:
Updating 'less' (590 -> 608)
Downloading new version
Loading lesskey.exe from cache.
Starting download with aria2 ...
Download: Download Results:
Download: gid |stat|avg speed |path/URI
Download: ======+====+===========+=======================================================
Download: 0f5a10|OK | 3.9MiB/s|C:/Users/asdf/scoop/cache/less#608#https_github.com_jftuga_less-Windows_releases_download_less-v608_less.exe
Download: Status Legend:
Download: (OK):download completed.
Checking hash of less.exe ... ERROR Hash check failed!
App: main/less
URL: https://github.com/jftuga/less-Windows/releases/download/less-v608/less.exe
First bytes: 4D 5A 90 00 03 00 00 00
Expected: 921c950a97c3eb6a375245984319f368b5dcdd65f8e2eeb37d36fd9da71a388e
Actual: 10b401a1b13dfb334ea4139c6b2343d85e1eaa8b302bc071960a0685bbdae6e2

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Main/issues/new?title=less%40608%3a+hash+check+failed

• OS: Windows 10
• pkgman: Scoop

After updating to less 608 mouse scrolling is no longer working, and worked fine on 590.

Repro Steps

• Open any of: cmd, PowerShell (Windows or Core), Windows Terminal
• Run less --mouse --help
• Try scrolling with the mouse

Expected Behavior

Less should scroll the screen when scrolling with the mouse.

Actual Behavior

Less is not scrolling with the mouse.

Additional Notes

Possibly unrelated, but I have noticed that if I input j or k (the arrow keys do not exhibit this behavior) then try scrolling with the mouse it will scroll one-way only in that direction until another key is pressed (unless that other key is the opposite direction, j or k, which will then simply reverse the one-way scroll direction).

Versions

• Windows: Windows 10 21H2 (19044.2006)
• Less: 608

Dear @jftuga, less.exe worked and still works perfectly fine on Windows 7 x64. So the claim about compiled for Windows 10 is a bit confusing. One could think it's that limited and pass by, sighing sadly. Also there is no clear explanation on the fontpage what lesskey is, consider giving one.

Hello, there!

As part of the university research we are currently doing regarding the security of Github Actions, we noticed that one or many of the workflows that are part of this repository are referencing vulnerable versions of the third-party actions. As part of a disclosure process, we decided to open issues to notify GitHub Community.

Please note that there are could be some false positives in our methodology, thus not all of the open issues could be valid. If that is the case, please let us know, so that we can improve on our approach. You can contact me directly using an email: ikoishy [at] ncsu.edu

Thanks in advance

1. The workflow nightly.yaml is referencing action ilammy/msvc-dev-cmd using references v1.7.0. However this reference is missing the commit 74a501b which may contain fix to the vulnerability.

The vulnerability fix that is missing by actions' versions could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider updating the reference to the action.

If you end up updating the reference, please let us know. We need the stats for the paper :-)